mirror of
https://github.com/we-promise/sure.git
synced 2026-07-12 21:05:20 +00:00
* feat(mcp): add OAuth well-known discovery endpoints (RFC 8414 + RFC 9728) Serves /.well-known/oauth-protected-resource (RFC 9728) and /.well-known/oauth-authorization-server (RFC 8414) so MCP clients can auto-discover the authorization server. Both endpoints are unauthenticated and respect APP_URL for reverse-proxy deployments. * feat(mcp): add dynamic client registration endpoint (RFC 7591) POST /register creates a public Doorkeeper::Application on demand so MCP clients (e.g. Claude.ai) can self-register without manual setup. Validates redirect_uris (including blank entries), falls back to "MCP Client" name, returns no client_secret (public client, PKCE only). Rate-limited to 10 registrations/min/IP via Rack::Attack. * feat(mcp): authenticate via Doorkeeper OAuth2, keep MCP_API_TOKEN as fallback MCP endpoint now accepts OAuth2 Bearer tokens issued by Doorkeeper. Falls back to the existing MCP_API_TOKEN env-var flow so self-hosted deployments are not broken. Requires MCP_OAUTH_ENABLED or MCP_API_TOKEN to be set — the endpoint returns 503 otherwise. - OauthBase concern provides APP_URL-aware configured_base_url (trailing slash stripped to prevent double-slash URLs) - Bearer scheme parsed case-insensitively (RFC 7235) - Only read_write scope accepted — read scope would allow mutating tools (CreateGoal, ImportBankStatement), so read-only tokens are rejected - Deactivated users rejected even with a valid Doorkeeper token - WWW-Authenticate header on 401 points to RFC 9728 resource metadata - SHA-256 digest used for constant-time env-var comparison - Rack::Attack throttle added for POST /register - Routes wired: /.well-known/*, /register, use_doorkeeper * fix(mcp): disable Turbo on OAuth consent form for external redirect URIs Turbo was intercepting the authorization form POST and XHR-fetching the redirect_uri (e.g. https://claude.ai/api/mcp/auth_callback), which CORS blocks. Extend the existing turbo_disabled guard to cover any redirect_uri that doesn't originate from the app itself. * feat(mcp): add Settings::McpController with connected clients view - Settings > MCP page (under Advanced) shows the MCP server URL with copy button and step-by-step instructions for connecting Claude.ai - Lists active non-mobile OAuth tokens with app name and revoke action; mobile device tokens are excluded to prevent accidental disconnection - Removes the MCP_OAUTH_ENABLED env-var gate — OAuth auth is always available since Doorkeeper handles consent; MCP_API_TOKEN remains as a self-hosted fallback * fix(mcp): remove client_credentials from grant_types_supported metadata Only authorization_code is supported by the registration endpoint. Advertising client_credentials was misleading — a client that reads the metadata and attempts that flow would get an application with the wrong grant type.
177 lines
4.8 KiB
Ruby
177 lines
4.8 KiB
Ruby
class McpController < ApplicationController
|
|
include OauthBase
|
|
|
|
PROTOCOL_VERSION = "2025-03-26"
|
|
|
|
# Skip session-based auth and CSRF — this is a token-authenticated API
|
|
skip_authentication
|
|
skip_before_action :verify_authenticity_token
|
|
skip_before_action :require_onboarding_and_upgrade
|
|
skip_before_action :set_default_chat
|
|
skip_before_action :detect_os
|
|
|
|
before_action :authenticate_mcp_token!
|
|
|
|
def handle
|
|
body = parse_request_body
|
|
return if performed?
|
|
|
|
unless valid_jsonrpc?(body)
|
|
render_jsonrpc_error(body&.dig("id"), -32600, "Invalid Request")
|
|
return
|
|
end
|
|
|
|
request_id = body["id"]
|
|
|
|
# JSON-RPC notifications omit the id field — server must not respond
|
|
unless body.key?("id")
|
|
return head(:no_content)
|
|
end
|
|
|
|
result = dispatch_jsonrpc(request_id, body["method"], body["params"])
|
|
return if performed?
|
|
|
|
render json: { jsonrpc: "2.0", id: request_id, result: result }
|
|
end
|
|
|
|
private
|
|
|
|
def parse_request_body
|
|
JSON.parse(request.raw_post)
|
|
rescue JSON::ParserError
|
|
render_jsonrpc_error(nil, -32700, "Parse error")
|
|
nil
|
|
end
|
|
|
|
def valid_jsonrpc?(body)
|
|
body.is_a?(Hash) && body["jsonrpc"] == "2.0" && body["method"].present?
|
|
end
|
|
|
|
def dispatch_jsonrpc(request_id, method, params)
|
|
case method
|
|
when "initialize"
|
|
handle_initialize
|
|
when "tools/list"
|
|
handle_tools_list
|
|
when "tools/call"
|
|
handle_tools_call(request_id, params)
|
|
else
|
|
render_jsonrpc_error(request_id, -32601, "Method not found: #{method}")
|
|
nil
|
|
end
|
|
end
|
|
|
|
def handle_initialize
|
|
{
|
|
protocolVersion: PROTOCOL_VERSION,
|
|
capabilities: { tools: {} },
|
|
serverInfo: { name: "sure", version: "1.0" }
|
|
}
|
|
end
|
|
|
|
def handle_tools_list
|
|
tools = Assistant.function_classes.map do |fn_class|
|
|
fn_instance = fn_class.new(mcp_user)
|
|
{
|
|
name: fn_instance.name,
|
|
description: fn_instance.description,
|
|
inputSchema: fn_instance.params_schema
|
|
}
|
|
end
|
|
|
|
{ tools: tools }
|
|
end
|
|
|
|
def handle_tools_call(request_id, params)
|
|
name = params&.dig("name")
|
|
arguments = params&.dig("arguments") || {}
|
|
|
|
fn_class = Assistant.function_classes.find { |fc| fc.name == name }
|
|
|
|
unless fn_class
|
|
render_jsonrpc_error(request_id, -32602, "Unknown tool: #{name}")
|
|
return nil
|
|
end
|
|
|
|
fn = fn_class.new(mcp_user)
|
|
result = fn.call(arguments)
|
|
|
|
{ content: [ { type: "text", text: result.to_json } ] }
|
|
rescue => e
|
|
Rails.logger.error "MCP tools/call error: #{e.message}"
|
|
{ content: [ { type: "text", text: { error: e.message }.to_json } ], isError: true }
|
|
end
|
|
|
|
def authenticate_mcp_token!
|
|
auth_header = request.authorization.to_s
|
|
token = auth_header[/\ABearer\s+(.+)\z/i, 1]&.strip&.presence # pipelock:ignore
|
|
|
|
return if token.present? && authenticate_via_doorkeeper(token)
|
|
return if token.present? && authenticate_via_env_token(token)
|
|
|
|
render_mcp_unauthorized
|
|
end
|
|
|
|
def authenticate_via_doorkeeper(token)
|
|
access_token = Doorkeeper::AccessToken.by_token(token)
|
|
return false unless access_token&.accessible?
|
|
return false unless access_token.scopes.include?("read_write")
|
|
|
|
user = User.find_by(id: access_token.resource_owner_id)
|
|
return false unless user&.active?
|
|
|
|
setup_mcp_session(user)
|
|
true
|
|
end
|
|
|
|
def authenticate_via_env_token(token)
|
|
expected = ENV["MCP_API_TOKEN"]
|
|
return false unless expected.present?
|
|
return false unless ActiveSupport::SecurityUtils.secure_compare(
|
|
OpenSSL::Digest::SHA256.hexdigest(token),
|
|
OpenSSL::Digest::SHA256.hexdigest(expected)
|
|
)
|
|
|
|
user = User.find_by(email: ENV["MCP_USER_EMAIL"])
|
|
|
|
unless user
|
|
Rails.logger.warn "[MCP] MCP_USER_EMAIL does not match any user — check environment configuration"
|
|
return false
|
|
end
|
|
|
|
setup_mcp_session(user)
|
|
true
|
|
end
|
|
|
|
def setup_mcp_session(user)
|
|
@mcp_user = user
|
|
# Build a fresh session to avoid inheriting impersonation state from
|
|
# existing sessions (Current.user resolves via active_impersonator_session
|
|
# first, which could leak another user's data into MCP tool calls).
|
|
Current.session = user.sessions.build(
|
|
user_agent: request.user_agent,
|
|
ip_address: request.ip
|
|
)
|
|
end
|
|
|
|
def mcp_user
|
|
@mcp_user
|
|
end
|
|
|
|
def render_mcp_unauthorized
|
|
response.set_header(
|
|
"WWW-Authenticate",
|
|
"Bearer resource_metadata=\"#{configured_base_url}/.well-known/oauth-protected-resource\""
|
|
)
|
|
render json: { error: "unauthorized" }, status: :unauthorized
|
|
end
|
|
|
|
def render_jsonrpc_error(id, code, message)
|
|
render json: {
|
|
jsonrpc: "2.0",
|
|
id: id,
|
|
error: { code: code, message: message }
|
|
}
|
|
end
|
|
end
|