mirror of
https://github.com/we-promise/sure.git
synced 2026-07-24 10:45:23 +00:00
5105752bbd
* feat(sync): family-facing cancellation for syncs, imports, and exports Users had no way to stop or recover any background operation: a mistaken "Sync all" runs to completion, and an import or export whose job died (hard worker kills lose in-flight Sidekiq jobs) wedges with a spinner forever. Sync cancellation (cooperative — nothing is ever killed): - New syncs.cancel_requested_at column. Only the cancelled sync carries the flag: pending descendants are marked stale immediately (their queued jobs no-op via the existing may_start? guard), while descendants whose jobs are already executing finish their work honestly. - Family::Syncer stops fanning out child syncs once the flag is set (fresh read per iteration — the flag comes from the web process). - Finalization resolves a cancel-requested sync to stale instead of completed, which also skips post-sync (transfer matching, rules, broadcasts) via the existing stale gate. - The `visible` scope excludes cancel-requested syncs, so spinners clear immediately and — fixing a latent bug this feature would have amplified — sync_later no longer piggybacks a new sync request onto a dying sync it would silently swallow. - Cancel button appears next to "Sync all" on the accounts page while a family sync is visible. SyncsController#cancel scopes through Sync.for_family with resource_owner, so cross-family ids 404 and account-level syncs respect per-user account access. Stuck import/export self-service: - Import#force_fail! / FamilyExport#force_fail!: allowed only once the record has been idle past PRESUMED_LOST_AFTER (1 hour — dwarfs any legitimate run), and applied inside with_lock with a status re-check, so a job finishing between page render and button click wins. Imports fail into the existing retry path (reverting -> revert_failed keeps the revert retryable); PdfImports release their processing claim back to pending; exports fail so a new one can be created. - "Mark as failed" buttons appear on the imports/exports index rows only when a record is presumed lost, behind the pages' existing permission gates (statement-import permission for imports, admin for exports). * fix(sync-cancel): cascade pending cancels, guard late finalizers, scope provider syncs Review feedback on #2685 (CodeRabbit, Codex): - request_cancel! now cascades finalization for pending syncs too: a pending child resolved to stale never runs its job, so nothing else would ever call finalize_if_all_children_finalized — its waiting parent hung in syncing until the 24h sweep (CodeRabbit critical) - SimplefinItem::Syncer#mark_completed re-reads the sync under a row lock and skips finalization once cancellation was requested or the row went terminal — its in-memory copy predates the cancel, and the unguarded complete! (plus the raw status fallback) resurrected a cancelled sync and re-ran post-sync (Codex) - Cancelling provider-item syncs now requires admin: for_family's resource_owner only scopes the Account branch, so a restricted member could cancel admin-managed provider syncs spanning accounts they cannot see. Family- and account-level syncs stay member-cancellable, matching the buttons the UI shows (Codex) - Lost-import error copy moved behind i18n (imports.errors.presumed_lost), resolved at call time (CodeRabbit) - Tests: pending-child cancel finalizes the parent; late provider complete! cannot resurrect a cancelled sync; provider-sync cancellation is admin-only * fix(sync-cancel): capture the skipped-finalization case via DebugLogEntry CodeRabbit round-2: the mark_completed skip (cancelled/terminal sync) is support-relevant — record it in the super-admin debug UI with the family and provider attached instead of a raw Rails.logger line. category: provider_sync, matching the other provider syncers.
55 lines
1.6 KiB
Ruby
55 lines
1.6 KiB
Ruby
require "test_helper"
|
|
|
|
class SyncsControllerTest < ActionDispatch::IntegrationTest
|
|
setup do
|
|
sign_in @user = users(:family_admin)
|
|
end
|
|
|
|
test "member can cancel their family's sync" do
|
|
sync = Sync.create!(syncable: @user.family, status: :syncing)
|
|
|
|
post cancel_sync_path(sync)
|
|
|
|
assert_redirected_to accounts_path
|
|
assert_not_nil sync.reload.cancel_requested_at
|
|
end
|
|
|
|
test "cancelling a finished sync is a no-op with an alert" do
|
|
sync = Sync.create!(syncable: @user.family, status: :completed)
|
|
|
|
post cancel_sync_path(sync)
|
|
|
|
assert_redirected_to accounts_path
|
|
assert_equal I18n.t("syncs.cancel.not_cancellable"), flash[:alert]
|
|
assert_equal "completed", sync.reload.status
|
|
end
|
|
|
|
test "cannot cancel another family's sync" do
|
|
other_family_sync = Sync.create!(syncable: users(:empty).family, status: :syncing)
|
|
|
|
post cancel_sync_path(other_family_sync)
|
|
|
|
assert_response :not_found
|
|
assert_equal "syncing", other_family_sync.reload.status
|
|
end
|
|
|
|
test "non-admin member cannot cancel a provider item sync" do
|
|
sign_in users(:family_member)
|
|
provider_sync = Sync.create!(syncable: plaid_items(:one), status: :syncing)
|
|
|
|
post cancel_sync_path(provider_sync)
|
|
|
|
assert_response :not_found
|
|
assert_equal "syncing", provider_sync.reload.status
|
|
end
|
|
|
|
test "admin can cancel a provider item sync" do
|
|
provider_sync = Sync.create!(syncable: plaid_items(:one), status: :syncing)
|
|
|
|
post cancel_sync_path(provider_sync)
|
|
|
|
assert_redirected_to accounts_path
|
|
assert_not_nil provider_sync.reload.cancel_requested_at
|
|
end
|
|
end
|