mirror of
https://github.com/we-promise/sure.git
synced 2026-05-25 21:44:56 +00:00
* refactor(transactions): migrate 5 transaction badges to DS::Pill (#1751 PR B) Migrates the hand-rolled "Pending" / "Review recommended" / "Potential duplicate" / "Split" badges across the transaction views to the extended DS::Pill primitive from #1902. **Visual contract for badge mode** In #1902 the badge mode (`marker: false`) used `rounded-md` (chip shape) because the marker mode does. But every existing pill / status badge in the codebase uses `rounded-full` — see `settings/providers/_status_pill.html.erb`, `settings/providers/_maturity_badge.html.erb`, and the inline transaction badges this PR is migrating. To keep the visual contract consistent, this PR shifts `DS::Pill`'s badge mode to `rounded-full` (marker mode stays `rounded-md`, unchanged from #1829). The shape distinction now reads: markers are tags, badges are pills. **Callsites migrated** (5): - `app/views/transactions/_transaction.html.erb` — Pending, Review-recommended, Possible-duplicate, Split badges - `app/views/transactions/_header.html.erb` — Pending badge - `app/views/transactions/_split_parent_row.html.erb` — Split badge **Tone mapping** | Badge | Tone | Notes | |---|---|---| | Pending | `:neutral` | unchanged copy/icon, gains subtle DS-controlled bg | | Review recommended | `:neutral` | matches existing `bg-surface-inset` look | | Possible duplicate | `:warning` | DS semantic alias for the existing `text-warning` | | Split | `:neutral` | matches existing `bg-surface-inset` look | **Deferred to follow-up PRs** - `app/views/transactions/_transfer_match.html.erb` — uses two responsive-visibility variants (`hidden lg:inline-flex` for long copy, `inline-flex lg:hidden` for short). DS::Pill currently has no `class:` arg for caller-controlled wrapper classes; deferring until that lands. - `app/views/transactions/searches/filters/_badge.html.erb` — has a close button alongside the label (`button_to clear_filter_*`) and uses `rounded-3xl p-1.5` instead of a true pill. Closer to a removable filter chip — better fit for a separate `DS::FilterChip` primitive than for `DS::Pill`. Refs #1751. * refactor(providers): migrate provider badges to DS::Pill (#1751 PR C) Migrates the provider-bucket pill/badge callsites to the extended DS::Pill primitive (badge mode, rounded-full) from #1917. Callsites migrated (3): - app/views/settings/providers/_status_pill.html.erb — provider connection status pill. Status → tone mapping: :ok → :success, :warn → :warning, :err → :error, else → :neutral. - app/views/settings/providers/_maturity_badge.html.erb — alpha/beta label. Tone :neutral, no dot. - app/views/sophtron_items/_sophtron_item.html.erb (line 27) — "manual sync" warning. Tone :warning, no dot. The settings/providers/_status_pill partial wraps DS::Pill rather than being deleted, since _connection_row still calls it via `render "settings/providers/status_pill", status: status` — keeping the partial preserves the seam without a wider refactor. Dead code removed: SettingsHelper#status_pill_classes (no remaining callers after the migration). Skipped: - app/views/simplefin_items/_activity_badge.html.erb — not actually a pill/badge. It renders <p> text with `text-warning` plus an inline icon below the heading; no rounded-full shape and no chip semantics. Migrating it would change the layout, not consolidate a pill pattern. Refs #1751. Stacks on #1917.
225 lines
9.5 KiB
Ruby
225 lines
9.5 KiB
Ruby
module SettingsHelper
|
|
SETTINGS_ORDER = [
|
|
# General section
|
|
{ name: -> { t("settings.settings_nav.accounts_label") }, path: :accounts_path },
|
|
{ name: -> { t("settings.settings_nav.bank_sync_label") }, path: :settings_providers_path, condition: :admin_user? },
|
|
{ name: -> { t("settings.settings_nav.preferences_label") }, path: :settings_preferences_path },
|
|
{ name: -> { t("settings.settings_nav.appearance_label") }, path: :settings_appearance_path },
|
|
{ name: -> { t("settings.settings_nav.profile_label") }, path: :settings_profile_path },
|
|
{ name: -> { t("settings.settings_nav.security_label") }, path: :settings_security_path },
|
|
{ name: -> { t("settings.settings_nav.payment_label") }, path: :settings_payment_path, condition: :not_self_hosted? },
|
|
# Transactions section
|
|
{ name: -> { t("settings.settings_nav.categories_label") }, path: :categories_path },
|
|
{ name: -> { t("settings.settings_nav.tags_label") }, path: :tags_path },
|
|
{ name: -> { t("settings.settings_nav.rules_label") }, path: :rules_path },
|
|
{ name: -> { t("settings.settings_nav.merchants_label") }, path: :family_merchants_path },
|
|
{ name: -> { t("settings.settings_nav.recurring_transactions_label") }, path: :recurring_transactions_path },
|
|
{ name: -> { t("settings.settings_nav.statement_vault_label") }, path: :account_statements_path, condition: :admin_user? },
|
|
# Advanced section
|
|
{ name: -> { t("settings.settings_nav.ai_prompts_label") }, path: :settings_ai_prompts_path, condition: :admin_user? },
|
|
{ name: -> { t("settings.settings_nav.llm_usage_label") }, path: :settings_llm_usage_path, condition: :admin_user? },
|
|
{ name: -> { t("settings.settings_nav.api_key_label") }, path: :settings_api_key_path, condition: :admin_user? },
|
|
{ name: -> { t("settings.settings_nav.self_hosting_label") }, path: :settings_hosting_path, condition: :self_hosted_and_admin? },
|
|
{ name: -> { t("settings.settings_nav.imports_label") }, path: :imports_path, condition: :admin_user? },
|
|
{ name: -> { t("settings.settings_nav.exports_label") }, path: :family_exports_path, condition: :admin_user? },
|
|
# More section
|
|
{ name: -> { t("settings.settings_nav.guides_label") }, path: :settings_guides_path },
|
|
{ name: -> { t("settings.settings_nav.whats_new_label") }, path: :changelog_path },
|
|
{ name: -> { t("settings.settings_nav.feedback_label") }, path: :feedback_path }
|
|
]
|
|
|
|
def adjacent_setting(current_path, offset)
|
|
visible_settings = SETTINGS_ORDER.select { |setting| setting[:condition].nil? || send(setting[:condition]) }
|
|
current_index = visible_settings.index { |setting| send(setting[:path]) == current_path }
|
|
return nil unless current_index
|
|
|
|
adjacent_index = current_index + offset
|
|
return nil if adjacent_index < 0 || adjacent_index >= visible_settings.size
|
|
|
|
adjacent = visible_settings[adjacent_index]
|
|
|
|
render partial: "settings/settings_nav_link_large", locals: {
|
|
path: send(adjacent[:path]),
|
|
direction: offset > 0 ? "next" : "previous",
|
|
title: setting_name(adjacent)
|
|
}
|
|
end
|
|
|
|
def settings_section(title:, subtitle: nil, collapsible: false, open: true, auto_open_param: nil, status: nil, meta: nil, actions: nil, badge: nil, &block)
|
|
content = capture(&block)
|
|
render partial: "settings/section", locals: { title: title, subtitle: subtitle, content: content, collapsible: collapsible, open: open, auto_open_param: auto_open_param, status: status, meta: meta, actions: actions, badge: badge }
|
|
end
|
|
|
|
def provider_summary(provider_key)
|
|
key = provider_key.to_s.downcase
|
|
|
|
case key
|
|
when "plaid", "plaid_eu"
|
|
configured = @provider_configurations&.find { |c| c.provider_key.to_s.casecmp(key).zero? }&.configured?
|
|
configured ? { status: :ok } : { status: :off }
|
|
when "simplefin"
|
|
return { status: :off } unless @simplefin_items&.any?
|
|
sync_based_summary(key)
|
|
when "lunchflow"
|
|
return { status: :off } unless @lunchflow_items&.any?
|
|
sync_based_summary(key)
|
|
when "enable_banking"
|
|
return { status: :off } unless @enable_banking_items&.any?
|
|
enable_banking_summary
|
|
when "coinstats"
|
|
return { status: :off } unless @coinstats_items&.any?
|
|
sync_based_summary(key)
|
|
when "mercury"
|
|
return { status: :off } unless @mercury_items&.any?
|
|
sync_based_summary(key)
|
|
when "brex"
|
|
return { status: :off } unless @brex_items&.any?
|
|
sync_based_summary(key)
|
|
when "coinbase"
|
|
return { status: :off } unless @coinbase_items&.any?
|
|
sync_based_summary(key)
|
|
when "binance"
|
|
return { status: :off } unless @binance_items&.any?
|
|
sync_based_summary(key)
|
|
when "kraken"
|
|
return { status: :off } unless @kraken_items&.any?
|
|
sync_based_summary(key)
|
|
when "snaptrade"
|
|
configured_item = @snaptrade_items&.find(&:credentials_configured?)
|
|
return { status: :off } unless configured_item
|
|
unless configured_item.user_registered?
|
|
return { status: :warn, meta: t("settings.providers.meta.registration_needed") }
|
|
end
|
|
sync_based_summary(key)
|
|
when "ibkr"
|
|
return { status: :off } unless @ibkr_items&.any?
|
|
sync_based_summary(key)
|
|
when "indexa_capital"
|
|
return { status: :off } unless @indexa_capital_items&.any?
|
|
sync_based_summary(key)
|
|
when "sophtron"
|
|
return { status: :off } unless @sophtron_items&.any?
|
|
sync_based_summary(key)
|
|
else
|
|
{ status: :off }
|
|
end
|
|
end
|
|
|
|
def settings_nav_footer
|
|
previous_setting = adjacent_setting(request.path, -1)
|
|
next_setting = adjacent_setting(request.path, 1)
|
|
|
|
content_tag :div, class: "hidden md:flex flex-row justify-between gap-4" do
|
|
concat(previous_setting)
|
|
concat(next_setting)
|
|
end
|
|
end
|
|
|
|
def settings_nav_footer_mobile
|
|
previous_setting = adjacent_setting(request.path, -1)
|
|
next_setting = adjacent_setting(request.path, 1)
|
|
|
|
content_tag :div, class: "md:hidden flex flex-col gap-4 pb-[env(safe-area-inset-bottom)]" do
|
|
concat(previous_setting)
|
|
concat(next_setting)
|
|
end
|
|
end
|
|
|
|
# Below this many synced accounts, the per-row pills already give the user
|
|
# enough at-a-glance signal and the strip is redundant chrome.
|
|
HEALTH_STRIP_MIN_ACCOUNTS = 10
|
|
|
|
# Slim health-strip data for the providers index. Pulls counts from the
|
|
# already-resolved entry summaries plus the family's distinct synced-account
|
|
# count for the trailing stat. Returns a hash consumed by the
|
|
# `settings/providers/_health_strip` partial, or nil when the family has
|
|
# fewer than HEALTH_STRIP_MIN_ACCOUNTS connected accounts.
|
|
def provider_health_strip(connected:, needs_attention:)
|
|
accounts_count = Current.family.accounts.joins(:account_providers).distinct.count
|
|
return nil if accounts_count < HEALTH_STRIP_MIN_ACCOUNTS
|
|
|
|
active_entries = connected + needs_attention
|
|
last_synced_at = active_entries.map { |e| e[:summary][:last_synced_at] }.compact.max
|
|
|
|
{
|
|
connected: active_entries.size,
|
|
needs_attention: needs_attention.size,
|
|
accounts_syncing: accounts_count,
|
|
last_synced_at: last_synced_at
|
|
}
|
|
end
|
|
|
|
# Strips the leading "about " from `time_ago_in_words` so copy reads as
|
|
# "Synced 6 hours ago" instead of "Synced about 6 hours ago".
|
|
def concise_time_ago(time)
|
|
time_ago_in_words(time).sub(/\Aabout /, "")
|
|
end
|
|
|
|
private
|
|
def sync_based_summary(provider_key)
|
|
health = @provider_sync_health&.dig(provider_key) || {}
|
|
last_synced_at = health[:last_synced_at]
|
|
|
|
base = if health[:error]
|
|
{ status: :err, meta: t("settings.providers.meta.sync_error") }
|
|
elsif health[:stale]
|
|
{ status: :warn, meta: t("settings.providers.meta.no_recent_sync") }
|
|
elsif last_synced_at.present?
|
|
{ status: :ok, meta: t("settings.providers.meta.last_synced", time: concise_time_ago(last_synced_at)) }
|
|
else
|
|
{ status: :ok }
|
|
end
|
|
|
|
base.merge(last_synced_at: last_synced_at)
|
|
end
|
|
|
|
def enable_banking_summary
|
|
health = @provider_sync_health&.dig("enable_banking") || {}
|
|
last_synced_at = health[:last_synced_at]
|
|
|
|
return { status: :err, meta: t("settings.providers.meta.sync_error"), last_synced_at: nil } if health[:error]
|
|
|
|
valid_items = @enable_banking_items&.select(&:session_valid?) || []
|
|
|
|
# All items have expired/missing sessions — need re-authorization
|
|
if valid_items.empty?
|
|
return { status: :warn, meta: t("settings.providers.meta.reconsent_required"), last_synced_at: last_synced_at }
|
|
end
|
|
|
|
expiring = valid_items.find do |item|
|
|
item.session_expires_at.present? && item.session_expires_at < 7.days.from_now
|
|
end
|
|
|
|
if expiring
|
|
days = [ ((expiring.session_expires_at - Time.current) / 1.day).ceil, 1 ].max
|
|
return { status: :warn, meta: t("settings.providers.meta.reconsent_needed", count: days), last_synced_at: last_synced_at }
|
|
end
|
|
|
|
return { status: :warn, meta: t("settings.providers.meta.no_recent_sync"), last_synced_at: last_synced_at } if health[:stale]
|
|
|
|
if last_synced_at.present?
|
|
{ status: :ok, meta: t("settings.providers.meta.last_synced", time: concise_time_ago(last_synced_at)), last_synced_at: last_synced_at }
|
|
else
|
|
{ status: :ok, last_synced_at: nil }
|
|
end
|
|
end
|
|
|
|
def not_self_hosted?
|
|
!self_hosted?
|
|
end
|
|
|
|
def setting_name(setting)
|
|
name = setting[:name]
|
|
name.respond_to?(:call) ? instance_exec(&name) : name
|
|
end
|
|
|
|
# Helper used by SETTINGS_ORDER conditions
|
|
def admin_user?
|
|
Current.user&.admin?
|
|
end
|
|
|
|
def self_hosted_and_admin?
|
|
self_hosted? && admin_user?
|
|
end
|
|
end
|