Files
sure/app/models/transfer.rb
arumaio eca8c6ce1f fix : account destroyed cascade transfer destruction then … (#1795)
* fix: cascade destroy transfers and reset transaction kind on account destruction.

* Add rescue no method to transfer transaction reset

---------

Co-authored-by: arumaio <aruma.pro+git@protonmail.com>
2026-05-24 13:27:27 +02:00

152 lines
4.0 KiB
Ruby

class Transfer < ApplicationRecord
belongs_to :inflow_transaction, class_name: "Transaction"
belongs_to :outflow_transaction, class_name: "Transaction"
enum :status, { pending: "pending", confirmed: "confirmed" }
validates :inflow_transaction_id, uniqueness: true
validates :outflow_transaction_id, uniqueness: true
validate :transfer_has_different_accounts
validate :transfer_has_opposite_amounts
validate :transfer_within_date_range
validate :transfer_has_same_family
class << self
def kind_for_account(account)
if account.loan?
"loan_payment"
elsif account.credit_card?
"cc_payment"
elsif account.investment? || account.crypto?
"investment_contribution"
elsif account.liability?
"cc_payment"
else
"funds_movement"
end
end
end
def reject!
Transfer.transaction do
RejectedTransfer.find_or_create_by!(inflow_transaction_id: inflow_transaction_id, outflow_transaction_id: outflow_transaction_id)
destroy!
end
end
# Once transfer is destroyed, we need to mark the denormalized kind fields on the transactions
def destroy!
Transfer.transaction do
[ inflow_transaction, outflow_transaction ].each do |transaction|
next if transaction.nil?
next unless Transaction.exists?(transaction.id)
begin
transaction.update!(kind: "standard")
rescue ActiveRecord::RecordNotFound
rescue NoMethodError
next
end
end
super
end
end
def confirm!
update!(status: "confirmed")
end
def date
inflow_transaction.entry.date
end
def sync_account_later
inflow_transaction&.entry&.sync_account_later
outflow_transaction&.entry&.sync_account_later
end
def to_account
inflow_transaction&.entry&.account
end
def from_account
outflow_transaction&.entry&.account
end
def amount_abs
inflow_transaction&.entry&.amount_money&.abs
end
def name
acc = to_account
if payment?
acc ? "Payment to #{acc.name}" : "Payment"
else
acc ? "Transfer to #{acc.name}" : "Transfer"
end
end
def payment?
to_account&.liability?
end
def loan_payment?
outflow_transaction&.kind == "loan_payment"
end
def liability_payment?
outflow_transaction&.kind == "cc_payment"
end
def regular_transfer?
outflow_transaction&.kind == "funds_movement"
end
def transfer_type
return "loan_payment" if loan_payment?
return "liability_payment" if liability_payment?
"transfer"
end
def categorizable?
to_account&.accountable_type == "Loan"
end
private
def transfer_has_different_accounts
return unless inflow_transaction&.entry && outflow_transaction&.entry
errors.add(:base, :different_accounts) if to_account == from_account
end
def transfer_has_same_family
return unless inflow_transaction&.entry && outflow_transaction&.entry
errors.add(:base, :same_family) unless to_account&.family == from_account&.family
end
def transfer_has_opposite_amounts
return unless inflow_transaction&.entry && outflow_transaction&.entry
inflow_entry = inflow_transaction.entry
outflow_entry = outflow_transaction.entry
inflow_amount = inflow_entry.amount
outflow_amount = outflow_entry.amount
if inflow_entry.currency == outflow_entry.currency
# For same currency, amounts must be exactly opposite
errors.add(:base, :opposite_amounts) if inflow_amount + outflow_amount != 0
else
# For different currencies, just check the signs are opposite
errors.add(:base, :opposite_amounts) unless inflow_amount.negative? && outflow_amount.positive?
end
end
def transfer_within_date_range
return unless inflow_transaction&.entry && outflow_transaction&.entry
date_diff = (inflow_transaction.entry.date - outflow_transaction.entry.date).abs
max_days = status == "confirmed" ? 30 : 4
errors.add(:base, :within_days, count: max_days) if date_diff > max_days
end
end