buzzromainandClaude Opus 5 5594f8bc94 fix(holdings): an outbound transfer must not clear a cost basis (#3237)
* fix(holdings): an outbound transfer must not clear a cost basis

Found by Codex on #3154, reported after it merged.

The migration cleared any calculated basis on a position that had ever been
part of a Transfer, in either direction. The runtime does not: both
`Holding#calculate_avg_cost` and the calculators drop `qty <= 0` rows before
they look at the label, so only a transfer IN makes a position unknowable.

Shares sent elsewhere say nothing about what the remaining ones cost. That
figure came from real purchases and is correct, and the migration destroyed it
— irreversibly, on a position the app still stands behind.

The `EXISTS` clause gains the same `qty > 0` the runtime applies, and a test
holds both directions down: a transfer in clears, a transfer out does not, and
each asserts what the computed path says before running the migration so the
two cannot drift apart again. On the old SQL the outbound case fails.

Installs that already ran the previous version cannot have those figures
restored. A connected account recomputes its basis when it next materializes;
a manual or disconnected one will not, which is the case this migration was
written for in the first place.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016GTNba5qE5NwzaHzbp27ye

* test(holdings): reach the runtime through its public door

Review on #3237. The test asserted the runtime precondition by sending to
Holding's private calculate_avg_cost, which ties migration coverage to a
model's internals — the thing the repo's own guidance says not to do.

`avg_cost` answers the same question in public; it only returned the stored
figure first because this test had stored one. It now leaves the basis empty
until after the precondition, so the read path falls through to the
computation on its own, and each case stores the figure the migration is then
asked to judge.

The precondition stays rather than moving to the holding suite, because it is
the point: the migration and the runtime have to agree about which positions
are unknowable, and the bug was that they did not. A test on either side alone
would not fail if they drifted apart again.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016GTNba5qE5NwzaHzbp27ye

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-08-28 08:57:50 +02:00
2025-05-20 13:31:05 -05:00
2026-06-15 23:29:36 +02:00
2026-06-15 23:29:36 +02:00
2025-09-24 00:19:51 +02:00
2026-04-13 13:44:37 +02:00
2026-06-05 15:16:41 +02:00

Ask DeepWiki View performance data on Skylight Dosu Pipelock Security Scan

sure_shot

Deutsch | Español | Français | 日本語 | 한국어 | Português | Русский | 中文

Sure: The personal finance app for everyone

Get involved: DiscordWebsiteIssues

Important

This repository is a community fork of the now-abandoned Maybe Finance project.
Learn more in their final release doc.

Backstory

The Maybe Finance (archived/abandoned repo) team spent most of 20212022 building a full-featured personal finance and wealth management app. It even included an “Ask an Advisor” feature that connected users with a real CFP/CFA — all included with your subscription.

The business end of things didn't work out, and so they stopped developing the app in mid-2023.

After spending nearly $1 million on development (employees, contractors, data providers, infra, etc.), the team open-sourced the app. Their goal was to let users self-host it for free — and eventually launch a hosted version for a small fee.

They actually did launch that hosted version … briefly.

That also didnt work out — at least not as a sustainable B2C business — so now here we are: hosting a community-maintained fork to keep the codebase alive and see where this can go next.

Join us!

Hosting Sure

Sure is a fully working personal finance app that can be self hosted with Docker. Sure can be accessed from a browser, the macOS desktop app, the mobile app, API clients, and LLM agents. See Sure Clients for an overview.

Forking and Attribution

This repo is a community fork of the archived Maybe Finance repo. Youre free to fork it under the AGPLv3 license — but wed love it if you stuck around and contributed here instead.

To stay compliant and avoid trademark issues:

  • Be sure to include the original AGPLv3 license and clearly state in your README that your fork is based on Maybe Finance but is not affiliated with or endorsed by Maybe Finance Inc.
  • "Maybe" is a trademark of Maybe Finance Inc. and therefore, use of it is NOT allowed in forked repositories (or the logo)

Performance Issues

With data-heavy apps, inevitably, there are performance issues. We've set up a public dashboard showing the problematic requests seen on the demo site, along with the stacktraces to help debug them.

https://www.skylight.io/app/applications/s6PEZSKwcklL/recent/6h/endpoints

Any contributions that help improve performance are very much welcome.

Local Development Setup

If you are trying to self-host the app, read this guide to get started.

The instructions below are for developers to get started with contributing to the app.

Requirements

  • See .ruby-version file for required Ruby version
  • PostgreSQL >9.3 (latest stable version recommended)
  • Redis > 5.4 (latest stable version recommended)

Getting Started

cd sure
cp .env.local.example .env.local
bin/setup
bin/dev

# Optionally, load demo data
rake demo_data:default

Visit http://localhost:3000 to view the app.

If you loaded the optional demo data, log in with these credentials:

  • Email: user@example.com
  • Password: Password1!

For further instructions, see guides below.

Setup Guides

One-click Install

Run on PikaPods

Deploy on Railway

Deploy on Hostim

Managed OpenClaw for Sure Finances

Managed OpenClaw for Sure Finances

License and Trademarks

Maybe and Sure are both distributed under an AGPLv3 license.

  • "Maybe" is a trademark of Maybe Finance, Inc.
  • "Sure" is not, and refers to this community fork.

Alt

S
Description
No description provided
Readme AGPL-3.0
149 MiB
Languages
Ruby 77.6%
HTML 12.9%
Dart 5.7%
JavaScript 3.1%
Rust 0.2%
Other 0.2%