mirror of
https://github.com/we-promise/sure.git
synced 2026-04-09 07:14:47 +00:00
* Implement providers factory * Multiple providers sync support - Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced - Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility - Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex - Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.) * Add generic provider_import_adapter * Finish unified import strategy * Update app/models/plaid_account.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Update app/models/provider/factory.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Fix account linked by plaid_id instead of external_id * Parse numerics to BigDecimal Parse numerics to BigDecimal before computing amount; guard nils. Avoid String * String and float drift; also normalize date. * Fix incorrect usage of assert_raises. * Fix linter * Fix processor test. * Update current_balance_manager.rb * Test fixes * Fix plaid linked account test * Add support for holding per account_provider * Fix proper account access Also fix account deletion for simpefin too * FIX match tests for consistency * Some more factory updates * Fix account schema for multipe providers Can do: - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers) - Account #2 → PlaidAccount only - Account #3 → SimplefinAccount only Cannot do: - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type) - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts) * Fix account setup - An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type]) - Each provider should maintain its own separate entries - We should NOT update one provider's entry when another provider syncs * Fix linter and guard migration * FIX linter issues. * Fixes - Remove duplicated index - Pass account_provider_id - Guard holdings call to avoid NoMethodError * Update schema and provider import fix * Plaid doesn't allow holdings deletion * Use ClimateControl for proper env setup * No need for this in .git --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
106 lines
3.0 KiB
Ruby
106 lines
3.0 KiB
Ruby
class SimplefinEntry::Processor
|
|
# simplefin_transaction is the raw hash fetched from SimpleFin API and converted to JSONB
|
|
def initialize(simplefin_transaction, simplefin_account:)
|
|
@simplefin_transaction = simplefin_transaction
|
|
@simplefin_account = simplefin_account
|
|
end
|
|
|
|
def process
|
|
import_adapter.import_transaction(
|
|
external_id: external_id,
|
|
amount: amount,
|
|
currency: currency,
|
|
date: date,
|
|
name: name,
|
|
source: "simplefin",
|
|
merchant: merchant
|
|
)
|
|
end
|
|
|
|
private
|
|
attr_reader :simplefin_transaction, :simplefin_account
|
|
|
|
def import_adapter
|
|
@import_adapter ||= Account::ProviderImportAdapter.new(account)
|
|
end
|
|
|
|
def account
|
|
simplefin_account.current_account
|
|
end
|
|
|
|
def data
|
|
@data ||= simplefin_transaction.with_indifferent_access
|
|
end
|
|
|
|
def external_id
|
|
id = data[:id].presence
|
|
raise ArgumentError, "SimpleFin transaction missing id: #{data.inspect}" unless id
|
|
"simplefin_#{id}"
|
|
end
|
|
|
|
def name
|
|
# Use SimpleFin's rich, clean data to create informative transaction names
|
|
payee = data[:payee]
|
|
description = data[:description]
|
|
|
|
# Combine payee + description when both are present and different
|
|
if payee.present? && description.present? && payee != description
|
|
"#{payee} - #{description}"
|
|
elsif payee.present?
|
|
payee
|
|
elsif description.present?
|
|
description
|
|
else
|
|
data[:memo] || "Unknown transaction"
|
|
end
|
|
end
|
|
|
|
def amount
|
|
parsed_amount = case data[:amount]
|
|
when String
|
|
BigDecimal(data[:amount])
|
|
when Numeric
|
|
BigDecimal(data[:amount].to_s)
|
|
else
|
|
BigDecimal("0")
|
|
end
|
|
|
|
# SimpleFin uses banking convention (expenses negative, income positive)
|
|
# Maybe expects opposite convention (expenses positive, income negative)
|
|
# So we negate the amount to convert from SimpleFin to Maybe format
|
|
-parsed_amount
|
|
rescue ArgumentError => e
|
|
Rails.logger.error "Failed to parse SimpleFin transaction amount: #{data[:amount].inspect} - #{e.message}"
|
|
raise
|
|
end
|
|
|
|
def currency
|
|
data[:currency] || account.currency
|
|
end
|
|
|
|
def date
|
|
case data[:posted]
|
|
when String
|
|
Date.parse(data[:posted])
|
|
when Integer, Float
|
|
# Unix timestamp
|
|
Time.at(data[:posted]).to_date
|
|
when Time, DateTime
|
|
data[:posted].to_date
|
|
when Date
|
|
data[:posted]
|
|
else
|
|
Rails.logger.error("SimpleFin transaction has invalid date value: #{data[:posted].inspect}")
|
|
raise ArgumentError, "Invalid date format: #{data[:posted].inspect}"
|
|
end
|
|
rescue ArgumentError, TypeError => e
|
|
Rails.logger.error("Failed to parse SimpleFin transaction date '#{data[:posted]}': #{e.message}")
|
|
raise ArgumentError, "Unable to parse transaction date: #{data[:posted].inspect}"
|
|
end
|
|
|
|
|
|
def merchant
|
|
@merchant ||= SimplefinAccount::Transactions::MerchantDetector.new(data).detect_merchant
|
|
end
|
|
end
|