mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
* Providers factory (#250) * Implement providers factory * Multiple providers sync support - Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced - Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility - Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex - Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.) * Add generic provider_import_adapter * Finish unified import strategy * Update app/models/plaid_account.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Update app/models/provider/factory.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Fix account linked by plaid_id instead of external_id * Parse numerics to BigDecimal Parse numerics to BigDecimal before computing amount; guard nils. Avoid String * String and float drift; also normalize date. * Fix incorrect usage of assert_raises. * Fix linter * Fix processor test. * Update current_balance_manager.rb * Test fixes * Fix plaid linked account test * Add support for holding per account_provider * Fix proper account access Also fix account deletion for simpefin too * FIX match tests for consistency * Some more factory updates * Fix account schema for multipe providers Can do: - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers) - Account #2 → PlaidAccount only - Account #3 → SimplefinAccount only Cannot do: - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type) - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts) * Fix account setup - An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type]) - Each provider should maintain its own separate entries - We should NOT update one provider's entry when another provider syncs * Fix linter and guard migration * FIX linter issues. * Fixes - Remove duplicated index - Pass account_provider_id - Guard holdings call to avoid NoMethodError * Update schema and provider import fix * Plaid doesn't allow holdings deletion * Use ClimateControl for proper env setup * No need for this in .git --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com> * Update pages/dashboard locales (#255) * Localization for an accountable group and sidebar - Added localization for account types - Updated account localization for en and ca --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
62 lines
1.9 KiB
Ruby
62 lines
1.9 KiB
Ruby
class BalanceSheet::ClassificationGroup
|
|
include Monetizable
|
|
|
|
monetize :total, as: :total_money
|
|
|
|
attr_reader :classification, :currency
|
|
|
|
def initialize(classification:, currency:, accounts:)
|
|
@classification = normalize_classification!(classification)
|
|
@name = name
|
|
@currency = currency
|
|
@accounts = accounts
|
|
end
|
|
|
|
def name
|
|
classification.titleize.pluralize
|
|
end
|
|
|
|
def icon
|
|
classification == "asset" ? "plus" : "minus"
|
|
end
|
|
|
|
def total
|
|
accounts.sum(&:converted_balance)
|
|
end
|
|
|
|
def syncing?
|
|
accounts.any?(&:syncing?)
|
|
end
|
|
|
|
# For now, we group by accountable type. This can be extended in the future to support arbitrary user groupings.
|
|
def account_groups
|
|
groups = accounts.group_by(&:accountable_type)
|
|
.transform_keys { |at| Accountable.from_type(at) }
|
|
.map do |accountable, account_rows|
|
|
BalanceSheet::AccountGroup.new(
|
|
name: I18n.t("accounts.types.#{accountable.name.underscore}", default: accountable.display_name),
|
|
color: accountable.color,
|
|
accountable_type: accountable,
|
|
accounts: account_rows,
|
|
classification_group: self
|
|
)
|
|
end
|
|
|
|
# Sort the groups using the manual order defined by Accountable::TYPES so that
|
|
# the UI displays account groups in a predictable, domain-specific sequence.
|
|
groups.sort_by do |group|
|
|
manual_order = Accountable::TYPES
|
|
type_name = group.key.camelize
|
|
manual_order.index(type_name) || Float::INFINITY
|
|
end
|
|
end
|
|
|
|
private
|
|
attr_reader :accounts
|
|
|
|
def normalize_classification!(classification)
|
|
raise ArgumentError, "Invalid classification: #{classification}" unless %w[asset liability].include?(classification)
|
|
classification
|
|
end
|
|
end
|