Files
sure/test/models/assistant/function/get_budget_test.rb
Wes 7685650e63 feat(assistant): add get_budget function for budget tracking (#1966)
* feat(assistant): add get_budget function for budget tracking

Exposes the existing Budget / BudgetCategory pacing data to the AI
assistant as a `get_budget` function. Supports a target month and an
optional `prior_months` window for trend comparison, with the response
shape matching the budget UI (totals, income, per-category status,
suggested daily spend on the current month).

Honors custom month_start_day by matching `Budget.param_to_date`
semantics for explicit slug input, so `month` round-trips with the
response's `month` field.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(assistant): use fixture reference for Food & Drink lookup

Replace fragile string match on `bc.category.name == "Food & Drink"`
with the `categories(:food_and_drink)` fixture so the test setup
isn't sensitive to category-name translations.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(assistant): enforce strict month format in get_budget

`Date.strptime` is lenient about trailing characters, so inputs like
`"2026-05-01"` or `"may-2026foo"` were parsing successfully and being
silently truncated to May 2026. Pre-validate the raw string with anchored
regex patterns for the documented YYYY-MM and MMM-YYYY shapes so
malformed tool arguments raise Assistant::Error instead.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(budgets): suggested_daily_spending handles custom-month periods

The helper compared `budget.start_date.month/year` against
`Date.current.month/year` and returned nil whenever the current period
straddled two calendar months — common for families with
`month_start_day != 1` (e.g., May 15–Jun 14 viewed on Jun 1). Replace
the calendar-month check with `budget.current?` and compute remaining
days from `budget.end_date` so the helper works for both standard and
custom periods. This also restores the daily pacing row in the budget
UI for custom-month families.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(assistant): make get_budget read-only for prior months

`prior_months: N` was calling `Budget.find_or_bootstrap` for every
month, which created empty `Budget` rows (and synced `BudgetCategory`
children) as a side effect of an AI query. Only the explicit target
month now bootstraps; prior months use `Budget.find_by` and are
dropped from the response if they don't exist. The response now
includes `months_unavailable: N` so the LLM can phrase a sensible
answer when fewer months come back than requested.

Extract `Budget.period_for(date, family:)` to share the date-bracket
math between `find_or_bootstrap`, `budget_date_valid?`, and the new
read-only path in `get_budget`.

Adds two tests covering the no-bootstrap behavior for prior months
and the `prior_months` clamp at `MAX_PRIOR_MONTHS`. Updates the
existing N+1 sorted-months test to seed prior budgets explicitly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: wolstad <wesleyolstad@protonmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-30 00:51:16 +02:00

172 lines
5.7 KiB
Ruby

require "test_helper"
class Assistant::Function::GetBudgetTest < ActiveSupport::TestCase
setup do
@user = users(:family_admin)
@family = @user.family
@function = Assistant::Function::GetBudget.new(@user)
end
test "has correct name" do
assert_equal "get_budget", @function.name
end
test "has a description" do
assert_not_empty @function.description
end
test "is not in strict mode" do
refute @function.strict_mode?
end
test "params_schema declares optional month and prior_months" do
schema = @function.params_schema
assert schema[:properties].key?(:month)
assert schema[:properties].key?(:prior_months)
assert_empty schema[:required]
end
test "returns current month when no month given" do
result = @function.call({})
assert_equal @family.currency, result[:currency]
assert_equal 1, result[:months].length
month = result[:months].first
assert month[:is_current]
assert_equal Date.current.beginning_of_month, month[:period][:start_date]
assert_equal Date.current.end_of_month, month[:period][:end_date]
end
test "returns N+1 months sorted oldest first when prior_months is set" do
current_start = Date.current.beginning_of_month
2.times do |i|
prior_start = current_start << (i + 1)
Budget.create!(
family: @family,
start_date: prior_start,
end_date: prior_start.end_of_month,
currency: @family.currency
)
end
result = @function.call("prior_months" => 2)
assert_equal 3, result[:months].length
starts = result[:months].map { |m| m[:period][:start_date] }
assert_equal starts.sort, starts
assert_equal current_start, starts.last
end
test "does not bootstrap budgets for prior_months that do not exist" do
initial_count = Budget.count
result = @function.call("prior_months" => 3)
assert_equal initial_count, Budget.count, "no prior budgets should be created as a side effect"
assert_equal 1, result[:months].length
assert_equal 3, result[:months_unavailable]
end
test "clamps prior_months above MAX_PRIOR_MONTHS" do
result = @function.call("prior_months" => 99)
considered = result[:months].length + (result[:months_unavailable] || 0)
assert_operator considered, :<=, Assistant::Function::GetBudget::MAX_PRIOR_MONTHS + 1
end
test "accepts YYYY-MM month format" do
target = Date.current.beginning_of_month << 1
result = @function.call("month" => target.strftime("%Y-%m"))
assert_equal 1, result[:months].length
assert_equal target, result[:months].first[:period][:start_date]
end
test "accepts MMM-YYYY month format" do
target = Date.current.beginning_of_month << 1
result = @function.call("month" => target.strftime("%b-%Y").downcase)
assert_equal target, result[:months].first[:period][:start_date]
end
test "respects custom month_start_day so slug input roundtrips" do
@family.update!(month_start_day: 15)
target = Date.new(Date.current.year, Date.current.month, 15) - 2.months
slug = target.strftime("%b-%Y").downcase
result = @function.call("month" => slug)
assert_equal 1, result[:months].length
month = result[:months].first
assert_equal slug, month[:month]
assert_equal target, month[:period][:start_date]
end
test "raises on invalid month format" do
assert_raises(Assistant::Error) do
@function.call("month" => "not-a-month")
end
end
test "rejects month strings with trailing characters" do
[ "2026-05-01", "2026-05foo", "may-2026foo" ].each do |raw|
assert_raises(Assistant::Error, "Expected #{raw.inspect} to be rejected") do
@function.call("month" => raw)
end
end
end
test "nests subcategories under their parent" do
result = @function.call({})
categories = result[:months].first[:categories]
food = categories.find { |c| c[:name] == "Food & Drink" }
assert food, "Food & Drink parent should be present"
sub_names = food[:subcategories].map { |s| s[:name] }
assert_includes sub_names, "Restaurants"
end
test "category status reflects over_budget helper" do
budget = Budget.find_or_bootstrap(@family, start_date: Date.current.beginning_of_month, user: @user)
food_bc = budget.budget_categories.find { |bc| bc.category == categories(:food_and_drink) }
food_bc.update!(budgeted_spending: 100)
BudgetCategory.any_instance.stubs(:actual_spending).returns(150)
result = @function.call({})
food = result[:months].first[:categories].find { |c| c[:name] == "Food & Drink" }
assert_equal "over_budget", food[:status]
end
test "suggested_daily_spending omitted on non-current months" do
target = Date.current.beginning_of_month << 1
result = @function.call("month" => target.strftime("%Y-%m"))
past = result[:months].first
refute past[:is_current]
past[:categories].each do |cat|
refute cat.key?(:suggested_daily_spending), "Past months should not include suggested_daily_spending"
cat[:subcategories].each do |sub|
refute sub.key?(:suggested_daily_spending), "Past month subcategories should not include suggested_daily_spending"
end
end
end
test "includes color on parent categories" do
result = @function.call({})
result[:months].first[:categories].each do |cat|
assert cat.key?(:color), "Each parent category should expose a color"
end
end
test "totals expose budget pacing fields" do
result = @function.call({})
totals = result[:months].first[:totals]
%i[budgeted_spending allocated_spending available_to_allocate actual_spending
available_to_spend percent_of_budget_spent overage_percent].each do |key|
assert totals.key?(key), "totals should include #{key}"
end
end
end