Guillem Arias
eb7ef50eed
fix(goals): CI green — schema, brakeman, pledge modal, error class
...
Regenerate schema.rb after the three v2 migrations so CI's db:schema:load
picks up goal_pledges, the dropped goal_contributions, and the partial
unique pledge_id index.
Brakeman:
- Drop :account_id and :kind from goal_pledge permit; look the account
up via @goal.linked_accounts.find_by(id:) instead and set kind
server-side from goal.any_connected_account?.
- Rename goals.show.projection.on_track to .on_track_html so I18n
marks the result html_safe automatically; drop the unconditional
.html_safe call in show.html.erb.
Pledge modal: rewrite app/views/goal_pledges/new.html.erb to use
DS::Dialog (the Sure convention for create modals — matches
categories/transfers).
Error handling: replace `raise ActiveRecord::RecordInvalid, "string"`
in GoalPledge#extend!/cancel! with a dedicated GoalPledge::NotOpenError;
the controller rescues that specifically.
Tests: rewrite the "pace is zero" test to create a fresh account with
no entries (the fixture's depository accounts carry transaction history
that produces a non-zero pace). All goal tests now green (73 runs,
157 assertions, 0 failures).
2026-05-14 17:54:08 +02:00
..
2026-05-13 21:27:50 +02:00
2026-05-14 16:07:14 +02:00
2026-05-13 21:27:50 +02:00
2026-04-07 14:43:17 +02:00
2026-04-07 14:43:17 +02:00
2026-05-13 18:13:48 +02:00
2026-05-13 18:13:48 +02:00
2026-05-13 18:13:48 +02:00
2026-04-01 20:25:06 +02:00
2026-04-01 20:25:06 +02:00
2026-04-11 21:37:07 +02:00
2026-02-06 18:04:03 +01:00
2026-05-13 14:03:37 +02:00
2026-05-12 00:17:49 +02:00
2026-05-13 17:54:09 +02:00
2026-02-06 18:04:03 +01:00
2026-04-13 00:51:23 +02:00
2026-05-13 20:07:00 +02:00
2026-05-14 16:07:14 +02:00
2026-05-12 23:45:19 +02:00
2026-05-12 23:45:19 +02:00
2026-05-12 23:45:19 +02:00
2026-04-27 18:33:22 +02:00
2026-05-12 00:22:37 +02:00
2026-05-12 00:22:37 +02:00
2026-01-09 13:14:14 +01:00
2026-02-19 18:58:01 +01:00
2026-01-23 00:53:24 +01:00
2026-03-11 15:54:01 +01:00
2025-10-28 19:32:27 +01:00
2025-05-24 19:16:55 -04:00
2026-05-13 18:13:48 +02:00
2026-03-23 12:34:43 +01:00
2026-03-26 19:01:35 +01:00
2026-02-16 13:50:06 +01:00
2026-04-10 17:42:16 +02:00
2025-11-24 14:07:14 +01:00
2026-05-13 18:17:10 +02:00
2026-04-07 14:43:17 +02:00
2026-04-18 09:50:34 +02:00
2026-05-12 00:55:46 +02:00
2026-05-09 21:55:20 +02:00
2026-05-12 23:45:19 +02:00
2026-04-08 21:05:58 +02:00
2025-07-15 11:42:41 -04:00
2026-03-20 17:01:31 +01:00
2026-05-12 23:45:19 +02:00
2026-05-13 20:07:00 +02:00
2026-01-07 15:59:04 +01:00
2026-03-25 10:50:23 +01:00
2025-11-24 14:07:14 +01:00
2026-05-13 21:05:11 +02:00
2026-05-13 21:05:11 +02:00
2026-04-29 15:30:04 +02:00
2026-02-06 21:25:52 +01:00
2026-03-14 20:14:18 +01:00
2026-05-03 20:33:29 +02:00
2026-05-03 20:33:29 +02:00
2025-11-01 10:15:33 +01:00
2026-04-07 14:43:17 +02:00
2026-04-07 14:43:17 +02:00
2026-05-13 18:13:48 +02:00
2026-05-13 18:13:48 +02:00
2026-04-13 20:03:55 +02:00
2026-04-23 21:28:38 +02:00
2026-03-11 15:54:01 +01:00
2026-04-01 20:27:29 +02:00
2026-05-03 20:33:29 +02:00
2026-01-21 22:56:39 +01:00
2026-01-21 22:56:39 +01:00
2026-04-11 21:37:07 +02:00
2026-01-07 15:59:04 +01:00
2026-02-19 19:51:42 +01:00
2024-10-03 14:42:22 -04:00
2026-04-10 23:19:48 +02:00
2026-05-09 12:36:41 +02:00
2026-04-13 00:51:23 +02:00
2026-02-19 18:07:47 +01:00
2026-02-11 15:22:56 +01:00
2025-09-24 00:19:51 +02:00
2026-04-13 19:53:04 +02:00
2026-05-14 17:54:08 +02:00
2026-05-14 17:54:08 +02:00
2026-05-12 23:45:19 +02:00
2026-05-12 23:45:19 +02:00
2026-05-12 23:45:19 +02:00
2026-05-12 23:45:19 +02:00
2026-05-12 23:45:19 +02:00
2025-09-24 00:19:51 +02:00
2026-01-12 14:40:30 +01:00
2026-03-25 17:47:04 +01:00
2026-02-08 18:19:37 +01:00
2026-02-08 18:19:37 +01:00
2026-04-11 15:09:59 +02:00
2026-05-05 01:04:29 +02:00
2026-03-10 13:44:53 +01:00
2024-02-02 19:37:10 -06:00
2026-05-12 00:22:37 +02:00
2026-04-18 00:06:24 +02:00
2026-05-12 12:18:17 +02:00
2026-04-07 20:46:05 +02:00
2026-05-03 10:56:31 +02:00
2026-05-03 10:56:31 +02:00
2026-05-12 00:00:49 +02:00
2026-02-06 18:04:29 +01:00
2026-05-12 21:55:22 +02:00
2026-05-05 01:12:48 +02:00
2025-11-11 19:51:07 +01:00
2026-03-19 15:17:55 +01:00
2025-10-31 13:29:44 +01:00
2026-05-12 00:22:37 +02:00
2025-04-01 08:41:49 -04:00
2026-04-05 09:27:24 +02:00
2026-05-12 00:37:47 +02:00
2026-04-03 12:38:37 +02:00
2026-03-13 07:59:45 +01:00
2026-04-10 17:42:16 +02:00
2025-11-11 19:51:07 +01:00
2026-04-29 13:00:38 +02:00
2025-08-12 02:59:16 +02:00
2025-11-17 21:51:37 +01:00
2025-10-22 19:51:24 +02:00
2026-05-12 23:45:19 +02:00
2026-03-20 14:52:09 +01:00
2026-01-23 00:27:00 +01:00
2026-05-12 12:17:00 +02:00
2026-05-08 15:15:23 +02:00
2026-05-09 21:55:20 +02:00
2026-02-10 23:14:58 +01:00
2026-05-05 00:47:45 +02:00
2025-05-13 15:53:13 -04:00
2026-05-12 00:00:49 +02:00
2026-05-06 22:02:21 +02:00
2024-07-10 11:22:59 -04:00
2026-05-13 20:07:00 +02:00
2026-05-12 23:45:19 +02:00
2026-03-14 23:56:27 +01:00
2026-05-13 20:07:00 +02:00
2026-05-12 23:45:19 +02:00
2026-01-12 15:35:14 -05:00
2025-02-21 11:57:59 -05:00
2026-05-03 20:33:29 +02:00
2026-05-05 01:20:57 +02:00