mirror of
https://github.com/we-promise/sure.git
synced 2026-05-07 12:54:04 +00:00
560c9fbff3
* Initial account sharing changes * Update schema.rb * Update schema.rb * Change sharing UI to modal * UX fixes and sharing controls * Scope include in finances better * Update totals.rb * Update totals.rb * Scope reports to finance account scope * Update impersonation_sessions_controller_test.rb * Review fixes * Update schema.rb * Update show.html.erb * FIX db validation * Refine edit permissions * Review items * Review * Review * Add application level helper * Critical review * Address remaining review items * Fix modals * more scoping * linter * small UI fix * Fix: Sync broadcasts push unscoped balance sheet to all users * Update sync_complete_event.rb The fix removes the sidebar broadcasts (which rendered unscoped account groups using family.balance_sheet without user context) along with the now-unused sidebar_targets, account_group, and family_balance_sheet private methods. The sidebar will still update correctly — when the sync completes, Family::SyncCompleteEvent#broadcast fires family.broadcast_refresh, which triggers a morph-based page refresh for each user with their own authenticated session, rendering properly scoped sidebar content.
23 lines
818 B
Ruby
23 lines
818 B
Ruby
class Family::SyncCompleteEvent
|
|
attr_reader :family
|
|
|
|
def initialize(family)
|
|
@family = family
|
|
end
|
|
|
|
def broadcast
|
|
# Broadcast a refresh signal instead of rendered HTML. Each user's browser
|
|
# re-fetches via their own authenticated request, so the balance sheet and
|
|
# net worth chart are correctly scoped to the current user (Current.user is
|
|
# nil in background jobs, which would produce an unscoped family-wide view).
|
|
family.broadcast_refresh
|
|
|
|
# Schedule recurring transaction pattern identification (debounced to run after all syncs complete)
|
|
begin
|
|
RecurringTransaction.identify_patterns_for(family)
|
|
rescue => e
|
|
Rails.logger.error("Family::SyncCompleteEvent recurring transaction identification failed: #{e.message}\n#{e.backtrace&.join("\n")}")
|
|
end
|
|
end
|
|
end
|