mirror of
https://github.com/we-promise/sure.git
synced 2026-05-08 05:04:59 +00:00
0a96bf199d
* SimpleFIN: setup UX + same-provider relink + card-replacement detection Fixes three bugs and adds auto-detection for credit-card fraud replacement. Bugs: - Importer: per-institution auth errors no longer flip the whole item to requires_update. Partial errors stay on sync_stats so other institutions keep syncing. - Setup page: new activity badges (recent / dormant / empty / likely-closed) via SimplefinAccount::ActivitySummary. Likely-closed (dormant + near-zero balance + prior history) defaults to "skip" in the type picker. - Relink: link_existing_account allows SimpleFIN to SimpleFIN swaps by atomically detaching the old AccountProvider inside a transaction. Adds "Change SimpleFIN account" menu item on linked-account dropdowns. Feature (credit-card scope only): - SimplefinItem::ReplacementDetector runs post-sync. Pairs a linked dormant zero-balance sfa with an unlinked active sfa at the same institution and account type. Persists suggestions on Sync#sync_stats. - Inline banner on the SimpleFIN item card prompts relink via CustomConfirm. Per-pair dismiss button scoped to the current sync (resurfaces on next sync if still applicable). Auto-suppresses once the relink has landed. Dev tooling: - bin/rails simplefin:seed_fraud_scenario[email] creates a realistic broken pair for manual QA; cleanup_fraud_scenario reverses it. * Address review feedback on #1493 - ReplacementDetector: symmetric one-to-one matching. Two dormant cards pointing at the same active card are now both skipped — previously the detector could emit two suggestions that would clobber each other if the user accepted both. - ReplacementDetector: require non-blank institution names on both sides before matching. Blank-vs-blank was accidentally treated as equal, risking cross-provider false matches when SimpleFIN omitted org_data. - ActivitySummary: fall back to "posted" when "transacted_at" is 0 (SimpleFIN's "unknown" sentinel). Integer 0 is truthy in Ruby, so the previous `|| fallback` short-circuited and ignored posted. - Controller: dismiss key is now the (dormant, active) pair so dismissing one candidate for a dormant card doesn't suppress others. - Helper test: freeze time around "6.hours.ago" and "5.days.ago" assertions so they don't flake when the suite runs before 06:00. * Address second review pass on #1493 - ReplacementDetector: canonicalize account_type in one place so filtering (supported_type?) and matching (type_matches?) agree on "credit card" vs "credit_card" variants. - ReplacementDetector: skip candidates with nil current_balance. nil is "unknown," not "zero" — previously fell back to 0 and passed the near- zero gate, allowing suggestions without balance evidence.
69 lines
3.9 KiB
Plaintext
69 lines
3.9 KiB
Plaintext
<%# locals: (simplefin_item:, suggestions:)
|
|
Banner rendered at the top of the SimpleFIN item card when the importer
|
|
detects a likely card-replacement pair (old card + new card, same
|
|
institution, same type). "Relink" reuses the existing link_existing_account
|
|
controller action to atomically swap the AccountProvider on the linked
|
|
Sure account. "Dismiss" persists a per-(dormant_sfa_id) dismissal on the
|
|
latest sync's sync_stats so the banner stops showing for that pair.
|
|
Suggestions are also auto-suppressed once the relink has already landed. %>
|
|
<% latest_sync = simplefin_item.syncs.order(created_at: :desc).first %>
|
|
<% dismissed_ids = Array(latest_sync&.sync_stats&.dig("dismissed_replacement_suggestions")) %>
|
|
<div class="space-y-2">
|
|
<% suggestions.each do |suggestion| %>
|
|
<% old_sfa = simplefin_item.simplefin_accounts.find_by(id: suggestion["dormant_sfa_id"]) %>
|
|
<% new_sfa = simplefin_item.simplefin_accounts.find_by(id: suggestion["active_sfa_id"]) %>
|
|
<% sure_account = Current.family.accounts.find_by(id: suggestion["sure_account_id"]) %>
|
|
<% next unless old_sfa && new_sfa && sure_account %>
|
|
<%# Hide once the relink has landed: new sfa already linked to the target account. %>
|
|
<% next if new_sfa.current_account&.id == sure_account.id %>
|
|
<%# Hide if the user has dismissed this specific pair. %>
|
|
<% dismissal_key = "#{old_sfa.id}:#{new_sfa.id}" %>
|
|
<% next if dismissed_ids.include?(dismissal_key) %>
|
|
|
|
<div class="bg-yellow-50 theme-dark:bg-yellow-900/20 border border-yellow-200 theme-dark:border-yellow-800 rounded-lg p-4">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "credit-card", size: "sm", color: "warning", class: "shrink-0 mt-0.5" %>
|
|
<div class="flex-1 space-y-2">
|
|
<div class="flex items-start justify-between gap-2">
|
|
<p class="text-sm font-medium text-primary">
|
|
<%= t("simplefin_items.replacement_prompt.title",
|
|
institution: suggestion["institution_name"].presence || simplefin_item.name) %>
|
|
</p>
|
|
<%= button_to dismiss_replacement_suggestion_simplefin_item_path(simplefin_item),
|
|
params: { dormant_sfa_id: old_sfa.id, active_sfa_id: new_sfa.id },
|
|
method: :post,
|
|
form: { class: "inline shrink-0" },
|
|
class: "-mt-1 -mr-1 p-1 rounded hover:bg-yellow-100 theme-dark:hover:bg-yellow-900/40 text-secondary",
|
|
aria: { label: t("simplefin_items.replacement_prompt.dismiss_aria") } do %>
|
|
<%= icon "x", size: "sm" %>
|
|
<% end %>
|
|
</div>
|
|
<p class="text-xs text-secondary">
|
|
<%= t("simplefin_items.replacement_prompt.description",
|
|
account_name: sure_account.name,
|
|
old_name: old_sfa.name,
|
|
new_name: new_sfa.name) %>
|
|
</p>
|
|
<div class="pt-1">
|
|
<% confirm = CustomConfirm.new(
|
|
title: t("simplefin_items.replacement_prompt.confirm_title"),
|
|
body: t("simplefin_items.replacement_prompt.confirm_body",
|
|
account_name: sure_account.name,
|
|
new_name: new_sfa.name),
|
|
btn_text: t("simplefin_items.replacement_prompt.relink")
|
|
) %>
|
|
<%= button_to t("simplefin_items.replacement_prompt.relink"),
|
|
link_existing_account_simplefin_items_path(
|
|
account_id: sure_account.id,
|
|
simplefin_account_id: new_sfa.id
|
|
),
|
|
method: :post,
|
|
data: { turbo_confirm: confirm.to_data_attribute },
|
|
class: "inline-flex items-center gap-1.5 text-sm font-medium px-3 py-2 rounded-lg text-inverse bg-inverse hover:bg-inverse-hover" %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
</div>
|