mirror of
https://github.com/we-promise/sure.git
synced 2026-05-07 12:54:04 +00:00
* SimpleFIN: setup UX + same-provider relink + card-replacement detection Fixes three bugs and adds auto-detection for credit-card fraud replacement. Bugs: - Importer: per-institution auth errors no longer flip the whole item to requires_update. Partial errors stay on sync_stats so other institutions keep syncing. - Setup page: new activity badges (recent / dormant / empty / likely-closed) via SimplefinAccount::ActivitySummary. Likely-closed (dormant + near-zero balance + prior history) defaults to "skip" in the type picker. - Relink: link_existing_account allows SimpleFIN to SimpleFIN swaps by atomically detaching the old AccountProvider inside a transaction. Adds "Change SimpleFIN account" menu item on linked-account dropdowns. Feature (credit-card scope only): - SimplefinItem::ReplacementDetector runs post-sync. Pairs a linked dormant zero-balance sfa with an unlinked active sfa at the same institution and account type. Persists suggestions on Sync#sync_stats. - Inline banner on the SimpleFIN item card prompts relink via CustomConfirm. Per-pair dismiss button scoped to the current sync (resurfaces on next sync if still applicable). Auto-suppresses once the relink has landed. Dev tooling: - bin/rails simplefin:seed_fraud_scenario[email] creates a realistic broken pair for manual QA; cleanup_fraud_scenario reverses it. * Address review feedback on #1493 - ReplacementDetector: symmetric one-to-one matching. Two dormant cards pointing at the same active card are now both skipped — previously the detector could emit two suggestions that would clobber each other if the user accepted both. - ReplacementDetector: require non-blank institution names on both sides before matching. Blank-vs-blank was accidentally treated as equal, risking cross-provider false matches when SimpleFIN omitted org_data. - ActivitySummary: fall back to "posted" when "transacted_at" is 0 (SimpleFIN's "unknown" sentinel). Integer 0 is truthy in Ruby, so the previous `|| fallback` short-circuited and ignored posted. - Controller: dismiss key is now the (dormant, active) pair so dismissing one candidate for a dormant card doesn't suppress others. - Helper test: freeze time around "6.hours.ago" and "5.days.ago" assertions so they don't flake when the suite runs before 06:00. * Address second review pass on #1493 - ReplacementDetector: canonicalize account_type in one place so filtering (supported_type?) and matching (type_matches?) agree on "credit card" vs "credit_card" variants. - ReplacementDetector: skip candidates with nil current_balance. nil is "unknown," not "zero" — previously fell back to 0 and passed the near- zero gate, allowing suggestions without balance evidence.
165 lines
7.9 KiB
Plaintext
165 lines
7.9 KiB
Plaintext
<% content_for :title, "Set Up SimpleFin Accounts" %>
|
|
|
|
<%= render DS::Dialog.new do |dialog| %>
|
|
<% dialog.with_header(title: "Set Up Your SimpleFin Accounts") do %>
|
|
<div class="flex items-center gap-2">
|
|
<%= icon "building-2", class: "text-primary" %>
|
|
<span class="text-primary">Choose the correct account types for your imported accounts</span>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% dialog.with_body do %>
|
|
<%= form_with url: complete_account_setup_simplefin_item_path(@simplefin_item),
|
|
method: :post,
|
|
local: true,
|
|
data: {
|
|
controller: "loading-button",
|
|
action: "submit->loading-button#showLoading",
|
|
loading_button_loading_text_value: "Creating Accounts...",
|
|
turbo_frame: "_top"
|
|
},
|
|
class: "space-y-6" do |form| %>
|
|
|
|
<div class="space-y-4">
|
|
<div class="bg-surface border border-primary p-4 rounded-lg">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "info", size: "sm", class: "text-primary mt-0.5 flex-shrink-0" %>
|
|
<div>
|
|
<p class="text-sm text-primary mb-2">
|
|
<strong>Choose the correct account type for each SimpleFin account:</strong>
|
|
</p>
|
|
<ul class="text-xs text-secondary space-y-1 list-disc list-inside">
|
|
<li><strong>Checking or Savings</strong> - Regular bank accounts</li>
|
|
<li><strong>Credit Card</strong> - Credit card accounts</li>
|
|
<li><strong>Investment</strong> - Brokerage, 401(k), IRA accounts</li>
|
|
<li><strong>Loan or Mortgage</strong> - Debt accounts</li>
|
|
<li><strong>Other Asset</strong> - Everything else</li>
|
|
</ul>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<!-- Sync Data Information -->
|
|
<div class="bg-surface border border-primary p-4 rounded-lg">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "clock", size: "sm", class: "text-primary mt-0.5 flex-shrink-0" %>
|
|
<div class="flex-1">
|
|
<p class="text-sm text-primary mb-2">
|
|
<strong>Transaction History:</strong>
|
|
</p>
|
|
<p class="text-xs text-secondary">
|
|
SimpleFin typically provides <strong>60-90 days</strong> of transaction history, depending on your bank.
|
|
After initial setup, new transactions will sync automatically going forward.
|
|
Historical data availability varies by institution and account type.
|
|
</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<% @simplefin_accounts.each do |simplefin_account| %>
|
|
<% inferred = @inferred_map[simplefin_account.id] || {} %>
|
|
<% activity = simplefin_account.activity_summary %>
|
|
<% near_zero_balance = (simplefin_account.current_balance || 0).to_d.abs <= 1 %>
|
|
<%# "Likely closed" requires evidence of prior activity that has since stopped.
|
|
An empty payload carries no signal (could be a brand-new card) so it renders
|
|
the neutral "no transactions imported yet" badge instead. %>
|
|
<% likely_closed = activity.last_transacted_at.present? && activity.dormant? && near_zero_balance %>
|
|
<%# Default likely-closed accounts (dormant AND near-zero balance) to "skip" so
|
|
users don't accidentally create empty Sure accounts for closed/replaced cards. %>
|
|
<% selected_type = if likely_closed
|
|
"skip"
|
|
else
|
|
inferred[:confidence] == :high ? inferred[:type] : "skip"
|
|
end %>
|
|
<%# Check if this account needs user attention (type selected but subtype missing) %>
|
|
<% types_with_subtypes = %w[Depository Investment Loan] %>
|
|
<% needs_subtype_attention = selected_type != "skip" && types_with_subtypes.include?(selected_type) && inferred[:subtype].blank? %>
|
|
|
|
<% card_class = if needs_subtype_attention
|
|
"border-2 border-warning bg-warning/5"
|
|
elsif likely_closed
|
|
"border border-secondary/40 bg-surface-inset/30"
|
|
else
|
|
"border border-primary"
|
|
end %>
|
|
<div class="rounded-lg p-4 <%= card_class %>">
|
|
<div class="flex items-center justify-between mb-3">
|
|
<div class="flex-1">
|
|
<h3 class="font-medium <%= likely_closed ? "text-secondary" : "text-primary" %>">
|
|
<%= simplefin_account.name %>
|
|
<% if simplefin_account.org_data.present? && simplefin_account.org_data['name'].present? %>
|
|
<span class="text-secondary">• <%= simplefin_account.org_data["name"] %></span>
|
|
<% end %>
|
|
</h3>
|
|
<p class="text-sm text-secondary">
|
|
<%= t(".account_card.balance") %>: <%= number_to_currency(simplefin_account.current_balance || 0, unit: simplefin_account.currency) %>
|
|
</p>
|
|
<%= render "activity_badge", activity: activity, likely_closed: likely_closed %>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="space-y-3" data-controller="account-type-selector" data-account-type-selector-account-id-value="<%= simplefin_account.id %>">
|
|
<div>
|
|
<%= label_tag "account_types[#{simplefin_account.id}]", "Account Type:",
|
|
class: "block text-sm font-medium text-primary mb-2" %>
|
|
<%= select_tag "account_types[#{simplefin_account.id}]",
|
|
options_for_select(@account_type_options, selected_type),
|
|
{ class: "appearance-none bg-container border border-primary rounded-md px-3 py-2 text-sm leading-6 text-primary focus:border-primary focus:ring-1 focus:ring-primary focus:outline-none w-full",
|
|
data: {
|
|
action: "change->account-type-selector#updateSubtype"
|
|
} } %>
|
|
</div>
|
|
|
|
<!-- Subtype dropdowns (shown/hidden based on account type) -->
|
|
<div data-account-type-selector-target="subtypeContainer">
|
|
<% @subtype_options.each do |account_type, subtype_config| %>
|
|
<%= render "subtype_select", account_type: account_type, subtype_config: subtype_config, simplefin_account: simplefin_account %>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% if @stale_simplefin_accounts&.any? %>
|
|
<!-- Stale Accounts Section -->
|
|
<div class="border-t border-primary mt-6 pt-6">
|
|
<div class="bg-warning/10 border border-warning rounded-lg p-4 mb-4">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "alert-triangle", size: "sm", class: "text-warning mt-0.5 flex-shrink-0" %>
|
|
<div>
|
|
<p class="text-sm text-primary font-medium mb-1">
|
|
<%= t("simplefin_items.setup_accounts.stale_accounts.title") %>
|
|
</p>
|
|
<p class="text-xs text-secondary">
|
|
<%= t("simplefin_items.setup_accounts.stale_accounts.description") %>
|
|
</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<% @stale_simplefin_accounts.each do |simplefin_account| %>
|
|
<%= render "stale_account_row", simplefin_account: simplefin_account, target_accounts: @target_accounts %>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
|
|
<div class="flex gap-3">
|
|
<%= render DS::Button.new(
|
|
text: "Create Accounts",
|
|
variant: "primary",
|
|
icon: "plus",
|
|
type: "submit",
|
|
class: "flex-1",
|
|
data: { loading_button_target: "button" }
|
|
) %>
|
|
<%= render DS::Link.new(
|
|
text: "Cancel",
|
|
variant: "secondary",
|
|
href: accounts_path
|
|
) %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|