mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 14:54:49 +00:00
3658e812a8
* Add pending transaction handling and duplicate reconciliation logic - Implemented logic to exclude pending transactions from budgets and analytics calculations. - Introduced mechanisms for reconciling pending transactions with posted versions. - Added duplicate detection with support for merging or dismissing matches. - Updated transaction search filters to include a `status_filter` for pending/confirmed transactions. - Introduced UI elements for reviewing and resolving duplicates. - Enhanced `ProviderSyncSummary` with stats for reconciled and stale pending transactions. * Refactor translation handling and enhance transaction and sync logic - Moved hardcoded strings to locale files for improved translation support. - Refined styling for duplicate transaction indicators and sync summaries. - Improved logic for excluding stale pending transactions and updating timestamps on batch exclusion. - Added unique IDs to status filters for better element targeting in UI. - Optimized database queries to avoid N+1 issues in stale pending calculations. * Add sync settings and enhance pending transaction handling - Introduced a new "Sync Settings" section in hosting settings with UI to toggle inclusion of pending transactions. - Updated handling of pending transactions with improved inference logic for `posted=0` and `transacted_at` in processors. - Added priority order for pending transaction inclusion: explicit argument > environment variable > runtime configurable setting. - Refactored settings and controllers to store updated sync preferences. * Refactor sync settings and pending transaction reconciliation - Extracted logic for pending transaction reconciliation, stale exclusion, and unmatched tracking into dedicated methods for better maintainability. - Updated sync settings to infer defaults from multiple provider environment variables (`SIMPLEFIN_INCLUDE_PENDING`, `PLAID_INCLUDE_PENDING`). - Refined UI and messaging to handle multi-provider configurations in sync settings. # Conflicts: # app/models/simplefin_item/importer.rb * Debounce transaction reconciliation during imports - Added per-run reconciliation debouncing to prevent repeated scans for the same account during chunked history imports. - Trimmed size of reconciliation stats to retain recent details only. - Introduced error tracking for reconciliation steps to improve UI visibility of issues. * Apply ABS() in pending transaction queries and improve error handling - Updated pending transaction logic to use ABS() for consistent handling of negative amounts. - Adjusted amount bounds calculations to ensure accuracy for both positive and negative values. - Refined exception handling in `merge_duplicate` to log failures and update user alert. - Replaced `Date.today` with `Date.current` in tests to ensure timezone consistency. - Minor optimization to avoid COUNT queries by loading limited records directly. * Improve error handling in duplicate suggestion and dismissal logic - Added exception handling for `store_duplicate_suggestion` to log failures and prevent crashes during fuzzy/low-confidence matches. - Enhanced `dismiss_duplicate` action to handle `ActiveRecord::RecordInvalid` and display appropriate user alerts. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com>
80 lines
2.6 KiB
Ruby
80 lines
2.6 KiB
Ruby
module TransactionsHelper
|
|
def transaction_search_filters
|
|
[
|
|
{ key: "account_filter", label: t("transactions.search.filters.account"), icon: "layers" },
|
|
{ key: "date_filter", label: t("transactions.search.filters.date"), icon: "calendar" },
|
|
{ key: "type_filter", label: t("transactions.search.filters.type"), icon: "tag" },
|
|
{ key: "status_filter", label: t("transactions.search.filters.status"), icon: "clock" },
|
|
{ key: "amount_filter", label: t("transactions.search.filters.amount"), icon: "hash" },
|
|
{ key: "category_filter", label: t("transactions.search.filters.category"), icon: "shapes" },
|
|
{ key: "tag_filter", label: t("transactions.search.filters.tag"), icon: "tags" },
|
|
{ key: "merchant_filter", label: t("transactions.search.filters.merchant"), icon: "store" }
|
|
]
|
|
end
|
|
|
|
def get_transaction_search_filter_partial_path(filter)
|
|
"transactions/searches/filters/#{filter[:key]}"
|
|
end
|
|
|
|
def get_default_transaction_search_filter
|
|
transaction_search_filters[0]
|
|
end
|
|
|
|
# ---- Transaction extra details helpers ----
|
|
# Returns a structured hash describing extra details for a transaction.
|
|
# Input can be a Transaction or an Entry (responds_to :transaction).
|
|
# Structure:
|
|
# {
|
|
# kind: :simplefin | :raw,
|
|
# simplefin: { payee:, description:, memo: },
|
|
# provider_extras: [ { key:, value:, title: } ],
|
|
# raw: String (pretty JSON or string)
|
|
# }
|
|
def build_transaction_extra_details(obj)
|
|
tx = obj.respond_to?(:transaction) ? obj.transaction : obj
|
|
return nil unless tx.respond_to?(:extra) && tx.extra.present?
|
|
|
|
extra = tx.extra
|
|
|
|
if extra.is_a?(Hash) && extra["simplefin"].present?
|
|
sf = extra["simplefin"]
|
|
simple = {
|
|
payee: sf.is_a?(Hash) ? sf["payee"].presence : nil,
|
|
description: sf.is_a?(Hash) ? sf["description"].presence : nil,
|
|
memo: sf.is_a?(Hash) ? sf["memo"].presence : nil
|
|
}.compact
|
|
|
|
extras = []
|
|
if sf.is_a?(Hash) && sf["extra"].is_a?(Hash) && sf["extra"].present?
|
|
sf["extra"].each do |k, v|
|
|
display = (v.is_a?(Hash) || v.is_a?(Array)) ? v.to_json : v
|
|
extras << {
|
|
key: k.to_s.humanize,
|
|
value: display,
|
|
title: (v.is_a?(String) ? v : display.to_s)
|
|
}
|
|
end
|
|
end
|
|
|
|
{
|
|
kind: :simplefin,
|
|
simplefin: simple,
|
|
provider_extras: extras,
|
|
raw: nil
|
|
}
|
|
else
|
|
pretty = begin
|
|
JSON.pretty_generate(extra)
|
|
rescue StandardError
|
|
extra.to_s
|
|
end
|
|
{
|
|
kind: :raw,
|
|
simplefin: {},
|
|
provider_extras: [],
|
|
raw: pretty
|
|
}
|
|
end
|
|
end
|
|
end
|