mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 14:54:49 +00:00
* Implement API v1 Imports controller - Add Api::V1::ImportsController with index, show, and create actions - Add Jbuilder views for index and show - Add integration tests - Implement row generation logic in create action - Update routes * Validate import account belongs to family - Add validation to Import model to ensure account belongs to the same family - Add regression test case in Api::V1::ImportsControllerTest * updating docs to be more detailed * Rescue StandardError instead of bare rescue in ImportsController * Optimize Imports API and fix documentation - Implement rows_count counter cache for Imports - Preload rows in Api::V1::ImportsController#show - Update documentation to show correct OAuth scopes * Fix formatting in ImportsControllerTest * Permit all import parameters and fix unknown attribute error * Restore API routes for auth, chats, and messages * removing pr summary * Fix trailing whitespace and configured? test failure - Update Import#configured? to use rows_count for performance and consistency - Mock rows_count in TransactionImportTest - Fix trailing whitespace in migration * Harden security and fix mass assignment in ImportsController - Handle type and account_id explicitly in create action - Rename import_params to import_config_params for clarity - Validate type against Import::TYPES * Fix MintImport rows_count update and migration whitespace - Update MintImport#generate_rows_from_csv to update rows_count counter cache - Fix trailing whitespace and final newline in AddRowsCountToImports migration * Implement full-screen Drag and Drop CSV import on Transactions page - Add DragAndDropImport Stimulus controller listening on document - Add full-screen overlay with icon and text to Transactions index - Update ImportsController to handle direct file uploads via create action - Add system test for drag and drop functionality * Implement Drag and Drop CSV upload on Import Upload page - Add drag-and-drop-import controller to import/uploads/show - Add full-screen overlay to import/uploads/show - Annotate upload form and input with drag-and-drop targets - Add PR_SUMMARY.md * removing pr summary * Add file validation to ImportsController - Validate file size (max 10MB) and MIME type in create action - Prevent memory exhaustion and invalid file processing - Defined MAX_CSV_SIZE and ALLOWED_MIME_TYPES in Import model * Refactor dragLeave logic with counter pattern to prevent flickering * Extract shared drag-and-drop overlay partial - Create app/views/imports/_drag_drop_overlay.html.erb - Update transactions/index and import/uploads/show to use the partial - Reduce code duplication in views * Update Brakeman and harden ImportsController security - Update brakeman to 7.1.2 - Explicitly handle type assignment in ImportsController#create to avoid mass assignment - Remove :type from permitted import parameters * Fix trailing whitespace in DragAndDropImportTest * Don't commit LLM comments as file * FIX add api validation --------- Co-authored-by: Carlos Adames <cj@Carloss-MacBook-Air.local> Co-authored-by: Juan José Mata <jjmata@jjmata.com> Co-authored-by: sokie <sokysrm@gmail.com>
96 lines
2.4 KiB
Ruby
96 lines
2.4 KiB
Ruby
class Import::Row < ApplicationRecord
|
|
belongs_to :import, counter_cache: true
|
|
|
|
validates :amount, numericality: true, allow_blank: true
|
|
validates :currency, presence: true
|
|
|
|
validate :date_valid
|
|
validate :required_columns
|
|
validate :currency_is_valid
|
|
|
|
scope :ordered, -> { order(:id) }
|
|
|
|
def tags_list
|
|
if tags.blank?
|
|
[ "" ]
|
|
else
|
|
tags.split("|").map(&:strip)
|
|
end
|
|
end
|
|
|
|
def date_iso
|
|
Date.strptime(date, import.date_format).iso8601
|
|
end
|
|
|
|
def signed_amount
|
|
if import.type == "TradeImport"
|
|
price.to_d * apply_trade_signage_convention(qty.to_d)
|
|
else
|
|
apply_transaction_signage_convention(amount.to_d)
|
|
end
|
|
end
|
|
|
|
def update_and_sync(params)
|
|
assign_attributes(params)
|
|
save!(validate: false)
|
|
import.sync_mappings
|
|
end
|
|
|
|
private
|
|
# In the Sure system, positive quantities == "inflows"
|
|
def apply_trade_signage_convention(value)
|
|
value * (import.signage_convention == "inflows_positive" ? 1 : -1)
|
|
end
|
|
|
|
# In the Sure system, positive amounts == "outflows", so we must reverse signage
|
|
def apply_transaction_signage_convention(value)
|
|
if import.amount_type_strategy == "signed_amount"
|
|
value * (import.signage_convention == "inflows_positive" ? -1 : 1)
|
|
elsif import.amount_type_strategy == "custom_column"
|
|
inflow_value = import.amount_type_inflow_value
|
|
|
|
if entity_type == inflow_value
|
|
value * -1
|
|
else
|
|
value
|
|
end
|
|
else
|
|
raise "Unknown amount type strategy for import: #{import.amount_type_strategy}"
|
|
end
|
|
end
|
|
|
|
def required_columns
|
|
import.required_column_keys.each do |required_key|
|
|
errors.add(required_key, "is required") if self[required_key].blank?
|
|
end
|
|
end
|
|
|
|
def date_valid
|
|
return if date.blank?
|
|
|
|
parsed_date = Date.strptime(date, import.date_format) rescue nil
|
|
|
|
if parsed_date.nil?
|
|
errors.add(:date, "must exactly match the format: #{import.date_format}")
|
|
return
|
|
end
|
|
|
|
min_date = Entry.min_supported_date
|
|
max_date = Date.current
|
|
|
|
if parsed_date < min_date || parsed_date > max_date
|
|
errors.add(:date, "must be between #{min_date} and #{max_date}")
|
|
end
|
|
end
|
|
|
|
def currency_is_valid
|
|
return true if currency.blank?
|
|
|
|
begin
|
|
Money::Currency.new(currency)
|
|
rescue Money::Currency::UnknownCurrencyError
|
|
errors.add(:currency, "is not a valid currency code")
|
|
end
|
|
end
|
|
end
|