mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 14:54:49 +00:00
* Add pending transaction handling and duplicate reconciliation logic - Implemented logic to exclude pending transactions from budgets and analytics calculations. - Introduced mechanisms for reconciling pending transactions with posted versions. - Added duplicate detection with support for merging or dismissing matches. - Updated transaction search filters to include a `status_filter` for pending/confirmed transactions. - Introduced UI elements for reviewing and resolving duplicates. - Enhanced `ProviderSyncSummary` with stats for reconciled and stale pending transactions. * Refactor translation handling and enhance transaction and sync logic - Moved hardcoded strings to locale files for improved translation support. - Refined styling for duplicate transaction indicators and sync summaries. - Improved logic for excluding stale pending transactions and updating timestamps on batch exclusion. - Added unique IDs to status filters for better element targeting in UI. - Optimized database queries to avoid N+1 issues in stale pending calculations. * Add sync settings and enhance pending transaction handling - Introduced a new "Sync Settings" section in hosting settings with UI to toggle inclusion of pending transactions. - Updated handling of pending transactions with improved inference logic for `posted=0` and `transacted_at` in processors. - Added priority order for pending transaction inclusion: explicit argument > environment variable > runtime configurable setting. - Refactored settings and controllers to store updated sync preferences. * Refactor sync settings and pending transaction reconciliation - Extracted logic for pending transaction reconciliation, stale exclusion, and unmatched tracking into dedicated methods for better maintainability. - Updated sync settings to infer defaults from multiple provider environment variables (`SIMPLEFIN_INCLUDE_PENDING`, `PLAID_INCLUDE_PENDING`). - Refined UI and messaging to handle multi-provider configurations in sync settings. # Conflicts: # app/models/simplefin_item/importer.rb * Debounce transaction reconciliation during imports - Added per-run reconciliation debouncing to prevent repeated scans for the same account during chunked history imports. - Trimmed size of reconciliation stats to retain recent details only. - Introduced error tracking for reconciliation steps to improve UI visibility of issues. * Apply ABS() in pending transaction queries and improve error handling - Updated pending transaction logic to use ABS() for consistent handling of negative amounts. - Adjusted amount bounds calculations to ensure accuracy for both positive and negative values. - Refined exception handling in `merge_duplicate` to log failures and update user alert. - Replaced `Date.today` with `Date.current` in tests to ensure timezone consistency. - Minor optimization to avoid COUNT queries by loading limited records directly. * Improve error handling in duplicate suggestion and dismissal logic - Added exception handling for `store_duplicate_suggestion` to log failures and prevent crashes during fuzzy/low-confidence matches. - Enhanced `dismiss_duplicate` action to handle `ActiveRecord::RecordInvalid` and display appropriate user alerts. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com>
74 lines
2.1 KiB
Ruby
74 lines
2.1 KiB
Ruby
class PlaidAccount::Transactions::Processor
|
|
def initialize(plaid_account)
|
|
@plaid_account = plaid_account
|
|
end
|
|
|
|
def process
|
|
# Each entry is processed inside a transaction, but to avoid locking up the DB when
|
|
# there are hundreds or thousands of transactions, we process them individually.
|
|
modified_transactions.each do |transaction|
|
|
PlaidEntry::Processor.new(
|
|
transaction,
|
|
plaid_account: plaid_account,
|
|
category_matcher: category_matcher
|
|
).process
|
|
end
|
|
|
|
PlaidAccount.transaction do
|
|
removed_transactions.each do |transaction|
|
|
remove_plaid_transaction(transaction)
|
|
end
|
|
end
|
|
end
|
|
|
|
private
|
|
attr_reader :plaid_account
|
|
|
|
def category_matcher
|
|
@category_matcher ||= PlaidAccount::Transactions::CategoryMatcher.new(family_categories)
|
|
end
|
|
|
|
def family_categories
|
|
@family_categories ||= begin
|
|
if account.family.categories.none?
|
|
account.family.categories.bootstrap!
|
|
end
|
|
|
|
account.family.categories
|
|
end
|
|
end
|
|
|
|
def account
|
|
plaid_account.current_account
|
|
end
|
|
|
|
def remove_plaid_transaction(raw_transaction)
|
|
account.entries.find_by(plaid_id: raw_transaction["transaction_id"])&.destroy
|
|
end
|
|
|
|
# Since we find_or_create_by transactions, we don't need a distinction between added/modified
|
|
def modified_transactions
|
|
modified = plaid_account.raw_transactions_payload["modified"] || []
|
|
added = plaid_account.raw_transactions_payload["added"] || []
|
|
|
|
transactions = modified + added
|
|
|
|
# Filter out pending transactions based on env var or Setting
|
|
# Priority: env var > Setting (allows runtime changes via UI)
|
|
include_pending = if ENV["PLAID_INCLUDE_PENDING"].present?
|
|
Rails.configuration.x.plaid.include_pending
|
|
else
|
|
Setting.syncs_include_pending
|
|
end
|
|
unless include_pending
|
|
transactions = transactions.reject { |t| t["pending"] == true }
|
|
end
|
|
|
|
transactions
|
|
end
|
|
|
|
def removed_transactions
|
|
plaid_account.raw_transactions_payload["removed"] || []
|
|
end
|
|
end
|