mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 23:04:49 +00:00
* Implement API v1 Imports controller - Add Api::V1::ImportsController with index, show, and create actions - Add Jbuilder views for index and show - Add integration tests - Implement row generation logic in create action - Update routes * Validate import account belongs to family - Add validation to Import model to ensure account belongs to the same family - Add regression test case in Api::V1::ImportsControllerTest * updating docs to be more detailed * Rescue StandardError instead of bare rescue in ImportsController * Optimize Imports API and fix documentation - Implement rows_count counter cache for Imports - Preload rows in Api::V1::ImportsController#show - Update documentation to show correct OAuth scopes * Fix formatting in ImportsControllerTest * Permit all import parameters and fix unknown attribute error * Restore API routes for auth, chats, and messages * removing pr summary * Fix trailing whitespace and configured? test failure - Update Import#configured? to use rows_count for performance and consistency - Mock rows_count in TransactionImportTest - Fix trailing whitespace in migration * Harden security and fix mass assignment in ImportsController - Handle type and account_id explicitly in create action - Rename import_params to import_config_params for clarity - Validate type against Import::TYPES * Fix MintImport rows_count update and migration whitespace - Update MintImport#generate_rows_from_csv to update rows_count counter cache - Fix trailing whitespace and final newline in AddRowsCountToImports migration * Implement full-screen Drag and Drop CSV import on Transactions page - Add DragAndDropImport Stimulus controller listening on document - Add full-screen overlay with icon and text to Transactions index - Update ImportsController to handle direct file uploads via create action - Add system test for drag and drop functionality * Implement Drag and Drop CSV upload on Import Upload page - Add drag-and-drop-import controller to import/uploads/show - Add full-screen overlay to import/uploads/show - Annotate upload form and input with drag-and-drop targets - Add PR_SUMMARY.md * removing pr summary * Add file validation to ImportsController - Validate file size (max 10MB) and MIME type in create action - Prevent memory exhaustion and invalid file processing - Defined MAX_CSV_SIZE and ALLOWED_MIME_TYPES in Import model * Refactor dragLeave logic with counter pattern to prevent flickering * Extract shared drag-and-drop overlay partial - Create app/views/imports/_drag_drop_overlay.html.erb - Update transactions/index and import/uploads/show to use the partial - Reduce code duplication in views * Update Brakeman and harden ImportsController security - Update brakeman to 7.1.2 - Explicitly handle type assignment in ImportsController#create to avoid mass assignment - Remove :type from permitted import parameters * Fix trailing whitespace in DragAndDropImportTest * Don't commit LLM comments as file * FIX add api validation --------- Co-authored-by: Carlos Adames <cj@Carloss-MacBook-Air.local> Co-authored-by: Juan José Mata <jjmata@jjmata.com> Co-authored-by: sokie <sokysrm@gmail.com>
110 lines
2.9 KiB
Ruby
110 lines
2.9 KiB
Ruby
class TradeImport < Import
|
|
def import!
|
|
transaction do
|
|
mappings.each(&:create_mappable!)
|
|
|
|
trades = rows.map do |row|
|
|
mapped_account = if account
|
|
account
|
|
else
|
|
mappings.accounts.mappable_for(row.account)
|
|
end
|
|
|
|
# Try to find or create security with ticker only
|
|
security = find_or_create_security(
|
|
ticker: row.ticker,
|
|
exchange_operating_mic: row.exchange_operating_mic
|
|
)
|
|
|
|
Trade.new(
|
|
security: security,
|
|
qty: row.qty,
|
|
currency: row.currency.presence || mapped_account.currency,
|
|
price: row.price,
|
|
category: investment_category_for(row.qty, mapped_account.family),
|
|
entry: Entry.new(
|
|
account: mapped_account,
|
|
date: row.date_iso,
|
|
amount: row.signed_amount,
|
|
name: row.name,
|
|
currency: row.currency.presence || mapped_account.currency,
|
|
import: self
|
|
),
|
|
)
|
|
end
|
|
|
|
Trade.import!(trades, recursive: true)
|
|
end
|
|
end
|
|
|
|
def mapping_steps
|
|
base = []
|
|
base << Import::AccountMapping if account.nil?
|
|
base
|
|
end
|
|
|
|
def required_column_keys
|
|
%i[date ticker qty price]
|
|
end
|
|
|
|
def column_keys
|
|
base = %i[date ticker exchange_operating_mic currency qty price name]
|
|
base.unshift(:account) if account.nil?
|
|
base
|
|
end
|
|
|
|
def dry_run
|
|
mappings = { transactions: rows_count }
|
|
|
|
mappings.merge(
|
|
accounts: Import::AccountMapping.for_import(self).creational.count
|
|
) if account.nil?
|
|
|
|
mappings
|
|
end
|
|
|
|
def csv_template
|
|
template = <<-CSV
|
|
date*,ticker*,exchange_operating_mic,currency,qty*,price*,account,name
|
|
05/15/2024,AAPL,XNAS,USD,10,150.00,Trading Account,Apple Inc. Purchase
|
|
05/16/2024,GOOGL,XNAS,USD,-5,2500.00,Investment Account,Alphabet Inc. Sale
|
|
05/17/2024,TSLA,XNAS,USD,2,700.50,Retirement Account,Tesla Inc. Purchase
|
|
CSV
|
|
|
|
csv = CSV.parse(template, headers: true)
|
|
csv.delete("account") if account.present?
|
|
csv
|
|
end
|
|
|
|
private
|
|
def investment_category_for(qty, family)
|
|
# Buy trades (positive qty) are categorized as "Savings & Investments"
|
|
# Sell trades are left uncategorized - users will be prompted to categorize
|
|
return nil unless qty.to_d.positive?
|
|
|
|
family.categories.find_by(name: "Savings & Investments")
|
|
end
|
|
|
|
def find_or_create_security(ticker: nil, exchange_operating_mic: nil)
|
|
return nil unless ticker.present?
|
|
|
|
# Avoids resolving the same security over and over again (resolver potentially makes network calls)
|
|
@security_cache ||= {}
|
|
|
|
cache_key = [ ticker, exchange_operating_mic ].compact.join(":")
|
|
|
|
security = @security_cache[cache_key]
|
|
|
|
return security if security.present?
|
|
|
|
security = Security::Resolver.new(
|
|
ticker,
|
|
exchange_operating_mic: exchange_operating_mic.presence
|
|
).resolve
|
|
|
|
@security_cache[cache_key] = security
|
|
|
|
security
|
|
end
|
|
end
|