mirror of
https://github.com/we-promise/sure.git
synced 2026-04-09 07:14:47 +00:00
dfe60fa07d
* Providers factory (#250) * Implement providers factory * Multiple providers sync support - Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced - Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility - Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex - Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.) * Add generic provider_import_adapter * Finish unified import strategy * Update app/models/plaid_account.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Update app/models/provider/factory.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Fix account linked by plaid_id instead of external_id * Parse numerics to BigDecimal Parse numerics to BigDecimal before computing amount; guard nils. Avoid String * String and float drift; also normalize date. * Fix incorrect usage of assert_raises. * Fix linter * Fix processor test. * Update current_balance_manager.rb * Test fixes * Fix plaid linked account test * Add support for holding per account_provider * Fix proper account access Also fix account deletion for simpefin too * FIX match tests for consistency * Some more factory updates * Fix account schema for multipe providers Can do: - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers) - Account #2 → PlaidAccount only - Account #3 → SimplefinAccount only Cannot do: - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type) - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts) * Fix account setup - An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type]) - Each provider should maintain its own separate entries - We should NOT update one provider's entry when another provider syncs * Fix linter and guard migration * FIX linter issues. * Fixes - Remove duplicated index - Pass account_provider_id - Guard holdings call to avoid NoMethodError * Update schema and provider import fix * Plaid doesn't allow holdings deletion * Use ClimateControl for proper env setup * No need for this in .git --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com> * Update pages/dashboard locales (#255) * Localization for an accountable group and sidebar - Added localization for account types - Updated account localization for en and ca --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
91 lines
3.2 KiB
Plaintext
91 lines
3.2 KiB
Plaintext
<%# locals: (family:, active_tab:, mobile: false) %>
|
|
|
|
<div id="account-sidebar-tabs">
|
|
<% if family.missing_data_provider? %>
|
|
<details class="group bg-yellow-tint-10 rounded-lg p-2 text-yellow-600 mb-3 text-xs">
|
|
<summary class="flex items-center justify-between gap-2">
|
|
<div class="flex items-center gap-2">
|
|
<%= icon "triangle-alert", size: "sm", color: "warning" %>
|
|
<p class="font-medium"><%= t("accounts.sidebar.missing_data") %></p>
|
|
</div>
|
|
|
|
<%= icon("chevron-down", color: "warning", class: "group-open:transform group-open:rotate-180") %>
|
|
</summary>
|
|
<div class="text-xs py-2 space-y-2">
|
|
<p><%= t("accounts.sidebar.missing_data_description", product: product_name) %></p>
|
|
<p>
|
|
<%= link_to t("accounts.sidebar.configure_providers"), settings_hosting_path, class: "text-yellow-600 underline" %>
|
|
</p>
|
|
</div>
|
|
</details>
|
|
<% end %>
|
|
|
|
<%= render DS::Tabs.new(active_tab: active_tab, session_key: "account_sidebar_tab", testid: "account-sidebar-tabs") do |tabs| %>
|
|
<% tabs.with_nav do |nav| %>
|
|
<% nav.with_btn(id: "all", label: t("accounts.sidebar.tabs.all")) %>
|
|
<% nav.with_btn(id: "asset", label: t("accounts.sidebar.tabs.assets")) %>
|
|
<% nav.with_btn(id: "liability", label: t("accounts.sidebar.tabs.debts")) %>
|
|
<% end %>
|
|
|
|
<% tabs.with_panel(tab_id: "asset") do %>
|
|
<div class="space-y-2">
|
|
<%= render DS::Link.new(
|
|
text: t("accounts.sidebar.new_asset"),
|
|
variant: "ghost",
|
|
href: new_account_path(step: "method_select", classification: "asset"),
|
|
icon: "plus",
|
|
frame: :modal,
|
|
full_width: true,
|
|
class: "justify-start"
|
|
) %>
|
|
|
|
<div>
|
|
<% family.balance_sheet.assets.account_groups.each do |group| %>
|
|
<%= render "accounts/accountable_group", account_group: group, mobile: mobile %>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% tabs.with_panel(tab_id: "liability") do %>
|
|
<div class="space-y-2">
|
|
<%= render DS::Link.new(
|
|
text: t("accounts.sidebar.new_debt"),
|
|
variant: "ghost",
|
|
href: new_account_path(step: "method_select", classification: "liability"),
|
|
icon: "plus",
|
|
frame: :modal,
|
|
full_width: true,
|
|
class: "justify-start"
|
|
) %>
|
|
|
|
<div>
|
|
<% family.balance_sheet.liabilities.account_groups.each do |group| %>
|
|
<%= render "accounts/accountable_group", account_group: group, mobile: mobile %>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% tabs.with_panel(tab_id: "all") do %>
|
|
<div class="space-y-2">
|
|
<%= render DS::Link.new(
|
|
text: t("accounts.sidebar.new_account"),
|
|
variant: "ghost",
|
|
full_width: true,
|
|
href: new_account_path(step: "method_select"),
|
|
icon: "plus",
|
|
frame: :modal,
|
|
class: "justify-start"
|
|
) %>
|
|
|
|
<div>
|
|
<% family.balance_sheet.account_groups.each do |group| %>
|
|
<%= render "accounts/accountable_group", account_group: group, mobile: mobile, all_tab: true %>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
</div>
|