mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 14:54:49 +00:00
* Add stale account detection and handling in SimpleFin setup - Introduced UI for managing stale accounts during SimpleFin setup. - Added logic to detect accounts no longer provided by SimpleFin. - Implemented actions to delete, move transactions, or skip stale accounts. - Updated `simplefin_items_controller` with stale account processing and handling. - Enhanced tests to validate stale account scenarios, including detection, deletion, moving transactions, and skipping. * Update SimpleFin to SimpleFIN in locale file Signed-off-by: Juan José Mata <jjmata@jjmata.com> * Silly changes break things ... Signed-off-by: Juan José Mata <jjmata@jjmata.com> * Refactor stale account processing and UI handling - Moved `target_account.sync_later` to execute after commit for proper recalculation of balances. - Added additional safeguard in JavaScript to check for `moveRadioTarget` before updating target visibility. * More silly capitalization changes * Enhance stale account action handling in SimpleFIN setup - Introduced `permitted_stale_account_actions` to validate and permit nested `stale_account_actions` parameters. - Updated `complete_account_setup` to use the new method for safer processing. - Corrected capitalization in SimpleFIN update success and error messages. * Add error tracking and UI feedback for stale account actions - Updated `process_stale_account_actions` to track errors for delete and move actions. - Enhanced UI to display success and error messages for stale account processing. - Implemented destruction of conflicting transfers during account move to maintain data integrity. * Refactor transfer destruction and improve SimpleFIN account setup messages - Updated `simplefin_items_controller` to use `find_each(&:destroy!)` for transfer deletions, ensuring callbacks are invoked. - Enhanced localization for success messages in account creation to handle singular and plural cases. --------- Signed-off-by: Juan José Mata <jjmata@jjmata.com> Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com> Co-authored-by: Juan José Mata <jjmata@jjmata.com>
145 lines
6.8 KiB
Plaintext
145 lines
6.8 KiB
Plaintext
<% content_for :title, "Set Up SimpleFin Accounts" %>
|
|
|
|
<%= render DS::Dialog.new do |dialog| %>
|
|
<% dialog.with_header(title: "Set Up Your SimpleFin Accounts") do %>
|
|
<div class="flex items-center gap-2">
|
|
<%= icon "building-2", class: "text-primary" %>
|
|
<span class="text-primary">Choose the correct account types for your imported accounts</span>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% dialog.with_body do %>
|
|
<%= form_with url: complete_account_setup_simplefin_item_path(@simplefin_item),
|
|
method: :post,
|
|
local: true,
|
|
data: {
|
|
controller: "loading-button",
|
|
action: "submit->loading-button#showLoading",
|
|
loading_button_loading_text_value: "Creating Accounts...",
|
|
turbo_frame: "_top"
|
|
},
|
|
class: "space-y-6" do |form| %>
|
|
|
|
<div class="space-y-4">
|
|
<div class="bg-surface border border-primary p-4 rounded-lg">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "info", size: "sm", class: "text-primary mt-0.5 flex-shrink-0" %>
|
|
<div>
|
|
<p class="text-sm text-primary mb-2">
|
|
<strong>Choose the correct account type for each SimpleFin account:</strong>
|
|
</p>
|
|
<ul class="text-xs text-secondary space-y-1 list-disc list-inside">
|
|
<li><strong>Checking or Savings</strong> - Regular bank accounts</li>
|
|
<li><strong>Credit Card</strong> - Credit card accounts</li>
|
|
<li><strong>Investment</strong> - Brokerage, 401(k), IRA accounts</li>
|
|
<li><strong>Loan or Mortgage</strong> - Debt accounts</li>
|
|
<li><strong>Other Asset</strong> - Everything else</li>
|
|
</ul>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<!-- Sync Data Information -->
|
|
<div class="bg-surface border border-primary p-4 rounded-lg">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "clock", size: "sm", class: "text-primary mt-0.5 flex-shrink-0" %>
|
|
<div class="flex-1">
|
|
<p class="text-sm text-primary mb-2">
|
|
<strong>Transaction History:</strong>
|
|
</p>
|
|
<p class="text-xs text-secondary">
|
|
SimpleFin typically provides <strong>60-90 days</strong> of transaction history, depending on your bank.
|
|
After initial setup, new transactions will sync automatically going forward.
|
|
Historical data availability varies by institution and account type.
|
|
</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<% @simplefin_accounts.each do |simplefin_account| %>
|
|
<% inferred = @inferred_map[simplefin_account.id] || {} %>
|
|
<% selected_type = inferred[:confidence] == :high ? inferred[:type] : "skip" %>
|
|
<%# Check if this account needs user attention (type selected but subtype missing) %>
|
|
<% types_with_subtypes = %w[Depository Investment Loan] %>
|
|
<% needs_subtype_attention = selected_type != "skip" && types_with_subtypes.include?(selected_type) && inferred[:subtype].blank? %>
|
|
|
|
<div class="rounded-lg p-4 <%= needs_subtype_attention ? "border-2 border-warning bg-warning/5" : "border border-primary" %>">
|
|
<div class="flex items-center justify-between mb-3">
|
|
<div>
|
|
<h3 class="font-medium text-primary">
|
|
<%= simplefin_account.name %>
|
|
<% if simplefin_account.org_data.present? && simplefin_account.org_data['name'].present? %>
|
|
<span class="text-secondary">• <%= simplefin_account.org_data["name"] %></span>
|
|
<% end %>
|
|
</h3>
|
|
<p class="text-sm text-secondary">
|
|
Balance: <%= number_to_currency(simplefin_account.current_balance || 0, unit: simplefin_account.currency) %>
|
|
</p>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="space-y-3" data-controller="account-type-selector" data-account-type-selector-account-id-value="<%= simplefin_account.id %>">
|
|
<div>
|
|
<%= label_tag "account_types[#{simplefin_account.id}]", "Account Type:",
|
|
class: "block text-sm font-medium text-primary mb-2" %>
|
|
<%= select_tag "account_types[#{simplefin_account.id}]",
|
|
options_for_select(@account_type_options, selected_type),
|
|
{ class: "appearance-none bg-container border border-primary rounded-md px-3 py-2 text-sm leading-6 text-primary focus:border-primary focus:ring-1 focus:ring-primary focus:outline-none w-full",
|
|
data: {
|
|
action: "change->account-type-selector#updateSubtype"
|
|
} } %>
|
|
</div>
|
|
|
|
<!-- Subtype dropdowns (shown/hidden based on account type) -->
|
|
<div data-account-type-selector-target="subtypeContainer">
|
|
<% @subtype_options.each do |account_type, subtype_config| %>
|
|
<%= render "subtype_select", account_type: account_type, subtype_config: subtype_config, simplefin_account: simplefin_account %>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% if @stale_simplefin_accounts&.any? %>
|
|
<!-- Stale Accounts Section -->
|
|
<div class="border-t border-primary mt-6 pt-6">
|
|
<div class="bg-warning/10 border border-warning rounded-lg p-4 mb-4">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "alert-triangle", size: "sm", class: "text-warning mt-0.5 flex-shrink-0" %>
|
|
<div>
|
|
<p class="text-sm text-primary font-medium mb-1">
|
|
<%= t("simplefin_items.setup_accounts.stale_accounts.title") %>
|
|
</p>
|
|
<p class="text-xs text-secondary">
|
|
<%= t("simplefin_items.setup_accounts.stale_accounts.description") %>
|
|
</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<% @stale_simplefin_accounts.each do |simplefin_account| %>
|
|
<%= render "stale_account_row", simplefin_account: simplefin_account, target_accounts: @target_accounts %>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
|
|
<div class="flex gap-3">
|
|
<%= render DS::Button.new(
|
|
text: "Create Accounts",
|
|
variant: "primary",
|
|
icon: "plus",
|
|
type: "submit",
|
|
class: "flex-1",
|
|
data: { loading_button_target: "button" }
|
|
) %>
|
|
<%= render DS::Link.new(
|
|
text: "Cancel",
|
|
variant: "secondary",
|
|
href: accounts_path
|
|
) %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|