mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 14:31:25 +00:00
7ae9077935
* Add default family selection for invite-only onboarding mode When onboarding is set to invite-only, admins can now choose a default family that new users without an invitation are automatically placed into as members, instead of creating a new family for each signup. https://claude.ai/code/session_01U9KgikKjV6xbyBZ5wMYsYx * Restrict invite codes and onboarding settings to super_admin only The Invite Codes section on /settings/hosting was visible to any authenticated user via the show action, leaking all family names/IDs through the default-family dropdown. This tightens access: - Hide the entire Invite Codes section in the view behind super_admin? - Add before_action :ensure_super_admin to InviteCodesController for all actions (index, create, destroy), replacing the inline admin? check - Add ensure_super_admin_for_onboarding filter on hostings#update that blocks non-super_admin users from changing onboarding_state or invite_only_default_family_id https://claude.ai/code/session_01U9KgikKjV6xbyBZ5wMYsYx * Fix tests for super_admin-only invite codes and onboarding settings - Hostings controller test: sign in as sure_support_staff (super_admin) for the onboarding_state update test, since ensure_super_admin_for_onboarding now requires super_admin role - Invite codes tests: use super_admin fixture for the success case and verify that a regular admin gets redirected instead of raising StandardError https://claude.ai/code/session_01U9KgikKjV6xbyBZ5wMYsYx * Fix system test to use super_admin for self-hosting settings The invite codes section is now only visible to super_admin users, so the system test needs to sign in as sure_support_staff to find the onboarding_state select element. https://claude.ai/code/session_01U9KgikKjV6xbyBZ5wMYsYx * Skip invite code requirement when a default family is configured When onboarding is invite-only but a default family is set, the claim_invite_code before_action was blocking registration before the create action could assign the user to the default family. Now invite_code_required? returns false when invite_only_default_family_id is present, allowing codeless signups to land in the configured default family. https://claude.ai/code/session_01U9KgikKjV6xbyBZ5wMYsYx --------- Co-authored-by: Claude <noreply@anthropic.com>
30 lines
677 B
Ruby
30 lines
677 B
Ruby
class InviteCodesController < ApplicationController
|
|
before_action :ensure_self_hosted
|
|
before_action :ensure_super_admin
|
|
|
|
def index
|
|
@invite_codes = InviteCode.all
|
|
end
|
|
|
|
def create
|
|
InviteCode.generate!
|
|
redirect_back_or_to invite_codes_path, notice: "Code generated"
|
|
end
|
|
|
|
def destroy
|
|
code = InviteCode.find(params[:id])
|
|
code.destroy
|
|
redirect_back_or_to invite_codes_path, notice: "Code deleted"
|
|
end
|
|
|
|
private
|
|
|
|
def ensure_self_hosted
|
|
redirect_to root_path unless self_hosted?
|
|
end
|
|
|
|
def ensure_super_admin
|
|
redirect_to root_path, alert: t("settings.hostings.not_authorized") unless Current.user.super_admin?
|
|
end
|
|
end
|