mirror of
https://github.com/we-promise/sure.git
synced 2026-05-30 15:59:02 +00:00
Brings the savings goals UI closer to the Claude Design reference shared
by the user. Changes:
- Sidebar nav label: "Savings goals" → "Savings".
- Status pill copy: "Behind" → "Behind pace" (matches Pill component
from GoalsCommon.jsx).
- Empty state rewritten with a large target icon, "No goals yet"
heading, and the descriptive body copy from the design.
Goal detail page (matches GoalDetail.jsx):
- New "← All goals" back link above the header.
- 2-column hero: ring card on the left (320px column), Projection card
on the right.
- Projection card uses a new D3 Stimulus controller
(`savings-goal-projection-chart`) that draws:
· saved area + line from goal creation → today (solid, primary)
· dashed projection segment from today → target date (yellow when
behind, green when on track)
· horizontal dashed target line with label
· today marker (vertical dashed line + dot)
Data shape comes from `SavingsGoal#projection_payload`.
- Card subtitle generates a contextual sentence ("At $X/mo you'll fall
short. Bump to $Y/mo to hit it on time." / "At your current pace
you'll reach this goal around Month YYYY." / "Goal reached. Nice
work.") with a strong tag highlighting the actionable figure.
- Stat row now shows Linked balance (sum across linked accounts) +
"N accounts" sub-caption instead of duplicate "Target date" stat.
New goal modal (matches the design images 2 + 3):
- DS::Dialog custom header: DS::FilledIcon target glyph + title + step
subtitle ("Step 1 of 2 · Goal details" / "Step 2 of 2 · Review &
start") that updates as the user advances.
- Connected stepper at top of body: numbered circles connected by a
bar, step-1 circle flips to ✓ when complete.
- Step 1 heading "What are you saving for?" + supporting copy.
- Name field paired with a target glyph affordance on its left.
- Target amount + Target date in a 2-col grid.
- Funding accounts list now grouped by account subtype with uppercase
section headers (CHECKING / SAVINGS / HSA / CD / MONEY MARKET /
OTHER), each row showing avatar + name + subtype + balance.
- Step 2 heading "Looks good?" + Review card (goal target + funding
accounts summary + suggested monthly = target/months_remaining), and
a disclosure for the optional initial contribution.
- Footer: "Cancel" left text-button (closes modal) / "Back" left text
when on step 2; "Continue →" or "Create goal →" right arrow button.
Demo generator: Depository accounts now set `subtype` ("checking" /
"savings") on the accountable so they group correctly in the modal.
Tests: all green, 35 runs in the savings suite, 92 assertions.
245 lines
8.1 KiB
JavaScript
245 lines
8.1 KiB
JavaScript
import { Controller } from "@hotwired/stimulus";
|
|
|
|
// 2-step modal stepper for creating a savings goal.
|
|
//
|
|
// Single <form> with two panels. Step 1 collects identity (name, amount,
|
|
// date, color, notes, linked accounts). Step 2 reviews + optional initial
|
|
// contribution. All state lives in the DOM — no half-records, single POST.
|
|
export default class extends Controller {
|
|
static targets = [
|
|
"step1Panel",
|
|
"step2Panel",
|
|
"step1Indicator",
|
|
"step2Indicator",
|
|
"step1Circle",
|
|
"step2Circle",
|
|
"stepperLine",
|
|
"modalSubtitle",
|
|
"linkedAccountCheckbox",
|
|
"initialContributionAmount",
|
|
"initialContributionAccountSelect",
|
|
"reviewName",
|
|
"reviewSummary",
|
|
"reviewAccounts",
|
|
"reviewSuggested",
|
|
"footerLeftButton",
|
|
"footerLeftLabel",
|
|
"footerRightButton",
|
|
"submitButton",
|
|
];
|
|
|
|
static values = {
|
|
step1Subtitle: { type: String, default: "Step 1 of 2 · Goal details" },
|
|
step2Subtitle: { type: String, default: "Step 2 of 2 · Review & start" },
|
|
cancelLabel: { type: String, default: "Cancel" },
|
|
backLabel: { type: String, default: "Back" },
|
|
continueLabel: { type: String, default: "Continue" },
|
|
submitLabel: { type: String, default: "Create goal" },
|
|
};
|
|
|
|
connect() {
|
|
this.currentStep = 1;
|
|
this.refreshSubmitState();
|
|
}
|
|
|
|
footerLeft(event) {
|
|
event.preventDefault();
|
|
if (this.currentStep === 1) {
|
|
const dialog = this.element.closest("dialog");
|
|
if (dialog) dialog.close();
|
|
} else {
|
|
this.back();
|
|
}
|
|
}
|
|
|
|
footerRight(event) {
|
|
event.preventDefault();
|
|
if (this.currentStep === 1) {
|
|
this.next();
|
|
} else {
|
|
this.submitButtonTarget.click();
|
|
}
|
|
}
|
|
|
|
next() {
|
|
if (!this.validateStep1()) return;
|
|
if (!this.linkedAccountCheckboxTargets.some((cb) => cb.checked)) {
|
|
this.flashLinkedAccountsRequired();
|
|
return;
|
|
}
|
|
|
|
this.currentStep = 2;
|
|
this.step1PanelTarget.classList.add("hidden");
|
|
this.step2PanelTarget.classList.remove("hidden");
|
|
this.updateStepperState();
|
|
this.refreshAccountSelect();
|
|
this.updateReview();
|
|
this.updateFooter();
|
|
}
|
|
|
|
back() {
|
|
this.currentStep = 1;
|
|
this.step2PanelTarget.classList.add("hidden");
|
|
this.step1PanelTarget.classList.remove("hidden");
|
|
this.updateStepperState();
|
|
this.updateFooter();
|
|
}
|
|
|
|
linkedAccountChanged() {
|
|
this.refreshAccountSelect();
|
|
this.refreshSubmitState();
|
|
this.updateReview();
|
|
}
|
|
|
|
validateStep1() {
|
|
const requiredInputs = this.step1PanelTarget.querySelectorAll(
|
|
'input[name="savings_goal[name]"], input[name="savings_goal[target_amount]"]'
|
|
);
|
|
let ok = true;
|
|
requiredInputs.forEach((input) => {
|
|
if (typeof input.checkValidity === "function" && !input.checkValidity()) {
|
|
input.reportValidity();
|
|
ok = false;
|
|
}
|
|
});
|
|
return ok;
|
|
}
|
|
|
|
refreshSubmitState() {
|
|
if (!this.hasFooterRightButtonTarget) return;
|
|
const anyChecked = this.linkedAccountCheckboxTargets.some((cb) => cb.checked);
|
|
this.footerRightButtonTarget.disabled = false;
|
|
this.footerRightButtonTarget.classList.toggle("opacity-50", !anyChecked && this.currentStep === 1);
|
|
}
|
|
|
|
refreshAccountSelect() {
|
|
if (!this.hasInitialContributionAccountSelectTarget) return;
|
|
const select = this.initialContributionAccountSelectTarget;
|
|
const previous = select.value;
|
|
while (select.options.length > 1) select.remove(1);
|
|
|
|
this.linkedAccountCheckboxTargets
|
|
.filter((cb) => cb.checked)
|
|
.forEach((cb) => {
|
|
const opt = document.createElement("option");
|
|
opt.value = cb.value;
|
|
opt.textContent = cb.dataset.accountName || cb.value;
|
|
select.appendChild(opt);
|
|
});
|
|
|
|
if ([...select.options].some((o) => o.value === previous)) {
|
|
select.value = previous;
|
|
}
|
|
}
|
|
|
|
updateStepperState() {
|
|
if (this.hasStep1CircleTarget) {
|
|
this.step1CircleTarget.classList.toggle("bg-inverse", this.currentStep === 1);
|
|
this.step1CircleTarget.classList.toggle("text-inverse", this.currentStep === 1);
|
|
this.step1CircleTarget.classList.toggle("bg-success", this.currentStep > 1);
|
|
this.step1CircleTarget.classList.toggle("text-inverse", this.currentStep === 1);
|
|
if (this.currentStep > 1) {
|
|
this.step1CircleTarget.textContent = "✓";
|
|
} else {
|
|
this.step1CircleTarget.textContent = "1";
|
|
}
|
|
}
|
|
if (this.hasStep2CircleTarget) {
|
|
this.step2CircleTarget.classList.toggle("bg-inverse", this.currentStep === 2);
|
|
this.step2CircleTarget.classList.toggle("text-inverse", this.currentStep === 2);
|
|
this.step2CircleTarget.classList.toggle("bg-container-inset", this.currentStep < 2);
|
|
this.step2CircleTarget.classList.toggle("text-secondary", this.currentStep < 2);
|
|
}
|
|
if (this.hasStepperLineTarget) {
|
|
this.stepperLineTarget.classList.toggle("bg-inverse", this.currentStep > 1);
|
|
}
|
|
// Modal subtitle lives in the dialog header, outside this controller's
|
|
// DOM scope. Locate it by attribute and update directly.
|
|
const subtitle = document.querySelector('[data-savings-goal-stepper-modal-subtitle]');
|
|
if (subtitle) {
|
|
subtitle.textContent =
|
|
this.currentStep === 1 ? this.step1SubtitleValue : this.step2SubtitleValue;
|
|
}
|
|
}
|
|
|
|
updateFooter() {
|
|
if (this.hasFooterLeftLabelTarget) {
|
|
this.footerLeftLabelTarget.textContent =
|
|
this.currentStep === 1 ? this.cancelLabelValue : this.backLabelValue;
|
|
}
|
|
if (this.hasFooterRightButtonTarget) {
|
|
const labelSpan = this.footerRightButtonTarget.querySelector("span");
|
|
if (labelSpan) {
|
|
labelSpan.textContent =
|
|
this.currentStep === 1 ? this.continueLabelValue : this.submitLabelValue;
|
|
}
|
|
}
|
|
this.refreshSubmitState();
|
|
}
|
|
|
|
updateReview() {
|
|
if (!this.hasReviewNameTarget) return;
|
|
|
|
const name = this.element.querySelector('input[name="savings_goal[name]"]')?.value || "—";
|
|
const amountInput = this.element.querySelector('input[name="savings_goal[target_amount]"]');
|
|
const amount = amountInput?.value ? parseFloat(amountInput.value) : 0;
|
|
const dateInput = this.element.querySelector('input[type="date"][name="savings_goal[target_date]"]');
|
|
const dateValue = dateInput?.value;
|
|
|
|
this.reviewNameTarget.textContent = name;
|
|
|
|
if (this.hasReviewSummaryTarget) {
|
|
const currency = amountInput?.dataset?.currency || "$";
|
|
const formattedAmount = amountInput?.value ? `${currency}${amount.toLocaleString()}` : "—";
|
|
this.reviewSummaryTarget.textContent = dateValue
|
|
? `${formattedAmount} by ${this.#formatDate(dateValue)}`
|
|
: formattedAmount;
|
|
}
|
|
|
|
if (this.hasReviewAccountsTarget) {
|
|
const checked = this.linkedAccountCheckboxTargets.filter((cb) => cb.checked);
|
|
const total = checked.reduce(
|
|
(sum, cb) => sum + parseFloat(cb.dataset.accountBalance || 0),
|
|
0,
|
|
);
|
|
this.reviewAccountsTarget.textContent = checked.length
|
|
? `${checked.length} ${checked.length === 1 ? "account" : "accounts"} · $${total.toLocaleString()} balance`
|
|
: "—";
|
|
}
|
|
|
|
if (this.hasReviewSuggestedTarget) {
|
|
const months = dateValue ? this.#monthsBetween(new Date(), new Date(dateValue)) : 0;
|
|
if (amount > 0 && months > 0) {
|
|
const perMonth = Math.ceil(amount / months);
|
|
this.reviewSuggestedTarget.textContent = `$${perMonth.toLocaleString()}/mo over ${Math.max(1, Math.round(months))} months`;
|
|
} else if (amount > 0) {
|
|
this.reviewSuggestedTarget.textContent = `$${amount.toLocaleString()} (no target date)`;
|
|
} else {
|
|
this.reviewSuggestedTarget.textContent = "—";
|
|
}
|
|
}
|
|
}
|
|
|
|
flashLinkedAccountsRequired() {
|
|
const first = this.linkedAccountCheckboxTargets[0];
|
|
if (first) {
|
|
first.focus();
|
|
first.classList.add("ring-2", "ring-destructive");
|
|
setTimeout(() => first.classList.remove("ring-2", "ring-destructive"), 1200);
|
|
}
|
|
}
|
|
|
|
#monthsBetween(from, to) {
|
|
return (to - from) / (1000 * 60 * 60 * 24 * 30.44);
|
|
}
|
|
|
|
#formatDate(iso) {
|
|
try {
|
|
const d = new Date(iso);
|
|
return d.toLocaleDateString(undefined, { month: "short", day: "numeric", year: "numeric" });
|
|
} catch (e) {
|
|
return iso;
|
|
}
|
|
}
|
|
}
|