mirror of
https://github.com/we-promise/sure.git
synced 2026-04-12 00:27:21 +00:00
* Add Indexa Capital provider scaffold
Generate Indexa Capital provider scaffolding and align credential fields with the API authentication requirements.
* Fix PR 926 lint and schema CI failures
* Implement Indexa Capital provider with real API integration
- Rewrite all broken view templates (were meta-ERB from code generator)
- Create missing select_accounts.html.erb template
- Implement real API calls: list_accounts via /users/me, get_holdings
via /accounts/{number}/fiscal-results, get_account_balance via
/accounts/{number}/performance
- Add API token auth support (stored token > env token > credentials)
- Add api_token column with encryption support
- Redesign settings panel: API token prominent, credentials collapsible
- Fix account balances display using performance endpoint portfolios
- Fix accounts index empty-state guard missing indexa_capital_items
- Simplify activities fetch job (no activities API endpoint exists)
- Fix i18n interpolation (%%{ -> %{) throughout locale file
* Add tests for Indexa Capital provider integration
- IndexaCapitalItemTest: validations, credentials, scopes, sync status
- IndexaCapitalAccountTest: upsert, holdings, account provider linking
- Provider::IndexaCapitalTest: auth modes, API stubs, error handling
- IndexaCapitalItemsControllerTest: CRUD, setup, linking, authorization
- Fixtures for items (token + credentials) and accounts (mutual + pension)
52 tests, 98 assertions, 0 failures
* Address code review feedback from PR #933
- Fix zero balance bug: use `nil?` instead of `present?` so 0 is stored
- Fix has_indexa_capital_credentials? to check api_token (was ignored)
- Fix build_provider to delegate to Provided concern (was ignoring token)
- Fix IndexaCapital section outside encryption_error guard in settings
- Add account_number sanitization to prevent path traversal in API URLs
- Replace all skipped processor tests with real working tests
- Add zero-balance and path-traversal test coverage
61 tests, 107 assertions, 0 failures
* Address code review round 2: credentials validation, RuboCop, test quality
- Fix RuboCop SpaceInsideArrayLiteralBrackets in credentials check
- Chain where.not calls so all three username/document/password must be present
- Require all three credentials (||) instead of any one (&&) in validate_configuration!
- Move attr_reader to private to avoid exposing credentials publicly
- Parse dates with Date.parse in extract_balance for robustness
- Remove stale TODO and Crypto from supported_account_types
- Order build_provider query deterministically by created_at
- Replace no-op holdings assertion with meaningful assert_difference
* Address code review round 3: JSON parse safety and test precision
- Rescue JSON::ParserError on 2xx responses for clearer error messages
- Fix weak balance assertion: set balance to 0 before processing, assert
expected value (27093.01 = sum of holdings amounts)
* Include Indexa Capital in automatic family sync
Add indexa_capital_items to Family::Syncer#child_syncables so balances
and holdings refresh on daily auto-sync and login sync, not only on
manual sync button clicks.
---------
Signed-off-by: Juan José Mata <juanjo.mata@gmail.com>
Co-authored-by: Juan José Mata <jjmata@jjmata.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
117 lines
4.5 KiB
Ruby
117 lines
4.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class IndexaCapitalAccount::Processor
|
|
include IndexaCapitalAccount::DataHelpers
|
|
|
|
attr_reader :indexa_capital_account
|
|
|
|
def initialize(indexa_capital_account)
|
|
@indexa_capital_account = indexa_capital_account
|
|
end
|
|
|
|
def process
|
|
account = indexa_capital_account.current_account
|
|
return unless account
|
|
|
|
Rails.logger.info "IndexaCapitalAccount::Processor - Processing account #{indexa_capital_account.id} -> Sure account #{account.id}"
|
|
|
|
# Update account balance FIRST (before processing transactions/holdings/activities)
|
|
update_account_balance(account)
|
|
|
|
# Process holdings
|
|
holdings_count = indexa_capital_account.raw_holdings_payload&.size || 0
|
|
Rails.logger.info "IndexaCapitalAccount::Processor - Holdings payload has #{holdings_count} items"
|
|
|
|
if indexa_capital_account.raw_holdings_payload.present?
|
|
Rails.logger.info "IndexaCapitalAccount::Processor - Processing holdings..."
|
|
IndexaCapitalAccount::HoldingsProcessor.new(indexa_capital_account).process
|
|
else
|
|
Rails.logger.warn "IndexaCapitalAccount::Processor - No holdings payload to process"
|
|
end
|
|
|
|
# Process activities (trades, dividends, etc.)
|
|
activities_count = indexa_capital_account.raw_activities_payload&.size || 0
|
|
Rails.logger.info "IndexaCapitalAccount::Processor - Activities payload has #{activities_count} items"
|
|
|
|
if indexa_capital_account.raw_activities_payload.present?
|
|
Rails.logger.info "IndexaCapitalAccount::Processor - Processing activities..."
|
|
IndexaCapitalAccount::ActivitiesProcessor.new(indexa_capital_account).process
|
|
else
|
|
Rails.logger.warn "IndexaCapitalAccount::Processor - No activities payload to process"
|
|
end
|
|
|
|
# Trigger immediate UI refresh so entries appear in the activity feed
|
|
account.broadcast_sync_complete
|
|
Rails.logger.info "IndexaCapitalAccount::Processor - Broadcast sync complete for account #{account.id}"
|
|
|
|
{ holdings_processed: holdings_count > 0, activities_processed: activities_count > 0 }
|
|
end
|
|
|
|
private
|
|
|
|
def update_account_balance(account)
|
|
# Calculate total balance and cash balance from provider data
|
|
total_balance = calculate_total_balance
|
|
cash_balance = calculate_cash_balance
|
|
|
|
Rails.logger.info "IndexaCapitalAccount::Processor - Balance update: total=#{total_balance}, cash=#{cash_balance}"
|
|
|
|
# Update the cached fields on the account
|
|
account.assign_attributes(
|
|
balance: total_balance,
|
|
cash_balance: cash_balance,
|
|
currency: indexa_capital_account.currency || account.currency
|
|
)
|
|
account.save!
|
|
|
|
# Create or update the current balance anchor valuation for linked accounts
|
|
# This is critical for reverse sync to work correctly
|
|
account.set_current_balance(total_balance)
|
|
end
|
|
|
|
def calculate_total_balance
|
|
# Calculate total from holdings + cash for accuracy
|
|
holdings_value = calculate_holdings_value
|
|
cash_value = indexa_capital_account.cash_balance || 0
|
|
|
|
calculated_total = holdings_value + cash_value
|
|
|
|
# Use calculated total if we have holdings, otherwise trust API value
|
|
if holdings_value > 0
|
|
Rails.logger.info "IndexaCapitalAccount::Processor - Using calculated total: holdings=#{holdings_value} + cash=#{cash_value} = #{calculated_total}"
|
|
calculated_total
|
|
elsif indexa_capital_account.current_balance.present?
|
|
Rails.logger.info "IndexaCapitalAccount::Processor - Using API total: #{indexa_capital_account.current_balance}"
|
|
indexa_capital_account.current_balance
|
|
else
|
|
calculated_total
|
|
end
|
|
end
|
|
|
|
def calculate_cash_balance
|
|
# Use provider's cash_balance directly
|
|
# Note: Can be negative for margin accounts
|
|
cash = indexa_capital_account.cash_balance
|
|
Rails.logger.info "IndexaCapitalAccount::Processor - Cash balance from API: #{cash.inspect}"
|
|
cash || BigDecimal("0")
|
|
end
|
|
|
|
def calculate_holdings_value
|
|
holdings_data = indexa_capital_account.raw_holdings_payload || []
|
|
return 0 if holdings_data.empty?
|
|
|
|
holdings_data.sum do |holding|
|
|
data = holding.is_a?(Hash) ? holding.with_indifferent_access : {}
|
|
# Indexa Capital: amount = total market value, or titles * price
|
|
amount = parse_decimal(data[:amount])
|
|
if amount
|
|
amount
|
|
else
|
|
titles = parse_decimal(data[:titles] || data[:quantity] || data[:units]) || 0
|
|
price = parse_decimal(data[:price]) || 0
|
|
titles * price
|
|
end
|
|
end
|
|
end
|
|
end
|