mirror of
https://github.com/we-promise/sure.git
synced 2026-05-07 21:04:12 +00:00
ccd6a53071
* fix(chat): persist eager pending assistant message to fix subscribe race When the LLM replies in ~1-2s the assistant message broadcast could fire before the client's Turbo stream subscription was established, leaving the UI stuck on the thinking indicator while the response was already persisted. Create the AssistantMessage as `pending` synchronously in `Chat#ask_assistant_later`, so it is rendered server-side on the chat show page with a "Thinking ..." inline placeholder. The worker then finds and updates the existing row via `append_text!`, which flips the status to `complete` and broadcasts updates against a DOM id that is already in the page — no race possible. On error, the placeholder is destroyed if no content streamed, otherwise demoted to `failed`. Replaces the standalone thinking indicator partial and the `Assistant::Broadcastable` thinking helpers, both now redundant. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(chat): bind each assistant job to its specific pending placeholder Addressing review feedback on #1658: 1. The pending placeholder lookup based on `last pending` was racy — back-to-back user messages would let one job fill another job's placeholder. Pass the placeholder through the job arguments (`AssistantResponseJob.perform_later(user_message, pending)`) so each turn is bound to its own row. 2. In `Assistant::External#respond_to`, the configured/authorized guards raise before the local was bound, leaving rescue cleanup with `nil` and the placeholder visible forever. Bind the parameter first so cleanup can destroy it on the misconfigured path. The kwarg defaults to nil so the API#retry path (`AssistantResponseJob.perform_later(new_message)`) and the model-level test calls continue to work — they fall back to an in-memory new message, restoring the original test count assertions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(chat): i18n the pending assistant placeholder string Move the hardcoded "Thinking ..." indicator into the locale file per CLAUDE.md i18n guidelines. With i18n.fallbacks enabled, non-en locales fall back to English until translated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Add thinking label translations * Fix chat pending assistant expectations * Fix external assistant pending test lookup * Scope chat stream targets per chat * Update message broadcast target tests --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
30 lines
1.1 KiB
Plaintext
30 lines
1.1 KiB
Plaintext
<%# locals: (assistant_message:) %>
|
|
|
|
<div id="<%= dom_id(assistant_message) %>">
|
|
<% if assistant_message.pending? %>
|
|
<div class="flex items-start gap-3 mb-6">
|
|
<%= render "chats/ai_avatar" %>
|
|
<p class="text-sm text-secondary animate-pulse"><%= t("chats.thinking") %></p>
|
|
</div>
|
|
<% elsif assistant_message.reasoning? %>
|
|
<details class="group mb-1">
|
|
<summary class="flex items-center gap-2">
|
|
<p class="text-secondary text-sm">Assistant reasoning</p>
|
|
<%= icon("chevron-down", class: "group-open:transform group-open:rotate-180") %>
|
|
</summary>
|
|
|
|
<div class="prose prose--ai-chat"><%= markdown(assistant_message.content) %></div>
|
|
</details>
|
|
<% else %>
|
|
<% if assistant_message.chat.debug_mode? && assistant_message.tool_calls.any? %>
|
|
<%= render "assistant_messages/tool_calls", message: assistant_message %>
|
|
<% end %>
|
|
|
|
<div class="flex items-start gap-3 mb-6">
|
|
<%= render "chats/ai_avatar" %>
|
|
|
|
<div class="prose prose--ai-chat"><%= markdown(assistant_message.content) %></div>
|
|
</div>
|
|
<% end %>
|
|
</div>
|