mirror of
https://github.com/we-promise/sure.git
synced 2026-08-05 16:42:18 +00:00
ba0e169f6b
* fix(sync): don't persist zero balances when a provider balance fetch fails A nil current_balance means the sync's balance fetch did not succeed (the snapshot upsert clears it; only a successful fetch repopulates it). The Lunchflow and Enable Banking processors coerced nil to 0 and write it (plus a currency fallback) onto the linked account, so any transient provider failure persists wrong data with no user-visible signal. Instead, treat nil as no-data: skip the account update. Also stop the Lunchflow snapshot upsert resetting an established account's currency to USD when the accounts endpoint omits currency. * fix(lunchflow): normalize the preserved currency in snapshot upsert Addresses the review comment on #2617: the preserved fallback reused the record's raw in-memory currency, so a blank value would fail the presence validation and break import, and an invalid code would persist instead of falling back to USD. Run it through parse_currency like the payload value. Regression test added. * fix(lunchflow,eb): review round 2 — failure visibility and currency parity Addresses the three review findings on #2617: 1. Capture the Lunch Flow balance-fetch failure via DebugLogEntry (the sync otherwise reports success with no mention of the skip). This is Lunch Flow only: Enable Banking's importer already surfaces the failure through transactions_failed/@sync_error. 2. Apply the currency-preservation fix to Enable Banking's snapshot upsert (same shape as the Lunch Flow fix: parity/safety). Regression test added. 3. Label the Enable Banking processor currency assertion as a parity check — it also passes on main, since the reset defect was Lunch Flow-specific.
74 lines
2.5 KiB
Ruby
74 lines
2.5 KiB
Ruby
class LunchflowAccount < ApplicationRecord
|
|
include CurrencyNormalizable, Encryptable
|
|
|
|
# Encrypt raw payloads if ActiveRecord encryption is configured
|
|
if encryption_ready?
|
|
encrypts :raw_payload
|
|
encrypts :raw_transactions_payload
|
|
end
|
|
|
|
belongs_to :lunchflow_item
|
|
|
|
# New association through account_providers
|
|
has_one :account_provider, as: :provider, dependent: :destroy
|
|
has_one :account, through: :account_provider, source: :account
|
|
has_one :linked_account, through: :account_provider, source: :account
|
|
|
|
validates :name, :currency, presence: true
|
|
validates :account_id, uniqueness: { scope: :lunchflow_item_id, allow_nil: true }
|
|
|
|
# Helper to get account using account_providers system
|
|
def current_account
|
|
account
|
|
end
|
|
|
|
def upsert_lunchflow_snapshot!(account_snapshot)
|
|
# Convert to symbol keys or handle both string and symbol keys
|
|
snapshot = account_snapshot.with_indifferent_access
|
|
|
|
# Map Lunchflow field names to our field names
|
|
# Lunchflow API returns: { id, name, institution_name, institution_logo, provider, currency, status }
|
|
# Build display name: "Institution Name - Account Name" if institution is present
|
|
display_name = if snapshot[:institution_name].present?
|
|
"#{snapshot[:institution_name]} - #{snapshot[:name]}"
|
|
else
|
|
snapshot[:name]
|
|
end
|
|
|
|
assign_attributes(
|
|
current_balance: nil, # Balance not provided by accounts endpoint
|
|
# The accounts endpoint usually omits currency (the balance endpoint is
|
|
# the authoritative source) — preserve what we already know rather than
|
|
# resetting an established account to USD. Normalize the preserved value
|
|
# too: a blank/invalid stored currency must fall through to USD, not
|
|
# propagate (blank would fail the presence validation and break import).
|
|
currency: parse_currency(snapshot[:currency]) || parse_currency(currency) || "USD",
|
|
name: display_name,
|
|
account_id: snapshot[:id].to_s,
|
|
account_status: snapshot[:status],
|
|
provider: snapshot[:provider],
|
|
institution_metadata: {
|
|
name: snapshot[:institution_name],
|
|
logo: snapshot[:institution_logo]
|
|
}.compact,
|
|
raw_payload: account_snapshot
|
|
)
|
|
|
|
save!
|
|
end
|
|
|
|
def upsert_lunchflow_transactions_snapshot!(transactions_snapshot)
|
|
assign_attributes(
|
|
raw_transactions_payload: transactions_snapshot
|
|
)
|
|
|
|
save!
|
|
end
|
|
|
|
private
|
|
|
|
def log_invalid_currency(currency_value)
|
|
Rails.logger.warn("Invalid currency code '#{currency_value}' for LunchFlow account #{id}, defaulting to USD")
|
|
end
|
|
end
|