mirror of
https://github.com/we-promise/sure.git
synced 2026-08-05 16:42:18 +00:00
849578a84a
* Add support for trading212 integration in investments sync * Respect Trading 212 history rate limits * Replace hex colors with design tokens * Changed withdrawal to withdraw * Address PR review feedback for Trading 212 integration - Replace all Rails.logger calls with DebugLogEntry.capture across syncer, importer, processor, provider, controller, and unlinking - Fix destroy action to surface unlink errors via DebugLogEntry - Replace hardcoded 'GBP' currency fallback with Current.family.currency - Replace hardcoded English status strings in Syncer with i18n - Add config/initializers/trading212.rb with DEBUG_RAW ENV toggle - Add comprehensive test coverage: item, account, data_helpers, holdings_processor, activities_processor, importer, syncer, and controller tests - Rewrite syncer and controller tests to match actual interfaces * Fix tests and bugs found during local test execution - Fix standard_ticker: empty string caused nil.upcase via [].first - Fix parse_date: DateTime < Date, so when Date caught DateTime first - Fix ActivitiesProcessor/HoldingsProcessor: missing instruments_map in DataHelpers caused NameError when processing dividends - Fix test: security fixture ticker collision with test data - Fix test: sync_status_summary i18n matching in assertions - Fix test: trading212_provider ConfigurationError test path - Fix test: controller invalid params needs Turbo-Frame header - Fix test: syncer test uses stubs instead of strict expects 116 tests, 257 assertions, 0 failures, 0 errors * Keep raw provider response bodies out of exception messages. * Fix Secrets leak into page HTML, prevents the API key/secret from appearing in the HTML source while keeping the "leave blank to keep existing" UX. * Address review findings: env gate, sync test, uniqueness test, destroy flow - Gate TRADING212_DEBUG_RAW behind Rails.env.local? so staging/production cannot accidentally enable raw payload logging - Assert SyncJob enqueue in sync controller test, not just redirect - Fix cross-item uniqueness test to actually use two different items - Remove rescue in destroy so unlink failures stop the flow (matching Brex/Akahu pattern) instead of proceeding to destroy_later silently * Add Trading212 tables to db/schema.rb for CI test database CI runs db:test:prepare which loads db/schema.rb, not migrations. Without these table definitions, fixture loading fails with PG::UndefinedTable: relation "trading212_accounts" does not exist. * Removed lint complaint * Register Trading212 in ProviderConnectionStatus::PROVIDERS Fixes CI failure: test_provider_registry_covers_syncable_family_provider_item_associations * Fixed bad merge --------- Signed-off-by: jdcdp <47483528+jdcdp@users.noreply.github.com> Co-authored-by: jdcdp <jdcdp@cdm4.net>
50 lines
1.2 KiB
YAML
50 lines
1.2 KiB
YAML
# Minimal fixtures for Trading212 items
|
|
# Per CLAUDE.md: Keep fixtures minimal (2-3 per model for base cases)
|
|
|
|
configured_item:
|
|
family: dylan_family
|
|
name: "Trading 212 Connection"
|
|
status: good
|
|
environment: live
|
|
currency: USD
|
|
scheduled_for_deletion: false
|
|
pending_account_setup: false
|
|
api_key: "test_api_key"
|
|
api_secret: "test_api_secret"
|
|
raw_instruments_payload: []
|
|
|
|
pending_setup_item:
|
|
family: dylan_family
|
|
name: "Trading 212 Setup Pending"
|
|
status: good
|
|
environment: live
|
|
currency: USD
|
|
scheduled_for_deletion: false
|
|
pending_account_setup: true
|
|
api_key: "test_api_key_pending"
|
|
api_secret: "test_api_secret_pending"
|
|
raw_instruments_payload: []
|
|
|
|
requires_update_item:
|
|
family: dylan_family
|
|
name: "Trading 212 Needs Update"
|
|
status: requires_update
|
|
environment: live
|
|
currency: USD
|
|
scheduled_for_deletion: false
|
|
pending_account_setup: false
|
|
api_key: "bad_key"
|
|
api_secret: "bad_secret"
|
|
raw_instruments_payload: []
|
|
|
|
no_credentials_item:
|
|
family: dylan_family
|
|
name: "Trading 212 No Credentials"
|
|
status: good
|
|
environment: demo
|
|
currency: USD
|
|
scheduled_for_deletion: false
|
|
pending_account_setup: true
|
|
# api_key and api_secret intentionally blank
|
|
raw_instruments_payload: []
|