mirror of
https://github.com/we-promise/sure.git
synced 2026-08-05 16:42:18 +00:00
* feat(insights): proactive financial intelligence feed Adds a nightly job that analyzes each family's finances in pure Ruby and surfaces typed, stateful insights on the dashboard and a new /insights page. - Insight model (active/read/dismissed) with a per-family dedup_key unique index so nightly re-runs refresh rows instead of duplicating them - Seven generators (spending anomaly, cash-flow warning, net worth milestone, subscription audit, savings rate change, idle cash, budget health) built on IncomeStatement, BalanceSheet, RecurringTransaction, and BudgetCategory - LLM used as a writer, not a reasoner: Insight::BodyWriter narrates pre-computed facts via the configured provider, with an i18n template fallback so self-hosted installs without API keys work identically; bodies are only (re)written when an insight is new or its numbers changed - GenerateInsightsJob: cron fan-out per family, per-family advisory lock, metadata-diff upsert that preserves read/dismissed state for unchanged signals and reactivates on material change - Dashboard insights_feed section (top 3, collapsible/reorderable) and an /insights feed page with turbo-stream dismissal; viewing the feed marks insights read - Tests for the model, job upsert semantics, and controller flows Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6ZRA6cgCRM4UdFKct3wm4 * fix(insights): address Codex review — expiry, budget metadata, LLM usage - Expire visible insights whose condition cleared: generators declare the insight types they produce, the registry reports which generators ran to completion, and the job expires visible insights of those types whose dedup_key was not regenerated. A crashing generator can't wipe out its healthy insights, and an expired insight reactivates when its condition returns — unlike a user-dismissed one, which stays dismissed. - Include a bucketed budget-spent percent in budget_at_risk metadata so the body refreshes when overall usage moves >=10 points even if the same categories remain flagged. - Pass family to chat_response so LLM narration is recorded in llm_usages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6ZRA6cgCRM4UdFKct3wm4 * fix(insights): address CodeRabbit review - Skip the mark-as-read write for Turbo hover-prefetch requests (X-Sec-Purpose) so unread badges don't clear before a real visit - Show the New pill on the dashboard feed (active = unread there; the feed never marks insights read) - Filter idle accounts in SQL instead of a per-account exists? loop - Eager-load merchants in the subscription audit query - Widen the advisory-lock key to the signed-bigint range and log when acquisition fails so a skipped nightly run is observable - Mirror the dedup_key unique index as a model validation - Assert the refresh action enqueues for the signed-in family Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6ZRA6cgCRM4UdFKct3wm4 * fix(insights): clear stale lifecycle timestamps on reactivation When an insight resurfaces, the row now leaves no contradictory state behind: the material-change path clears both read_at and dismissed_at, and the expired-recovery path clears read_at. Tests assert the contract, and the dashboard feed test now also locks in the unread "New" badge. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6ZRA6cgCRM4UdFKct3wm4 * fix(insights): drop redundant standalone family_id index Every composite index on insights already leads with family_id, so the auto-created single-column index was pure write overhead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6ZRA6cgCRM4UdFKct3wm4 * fix(insights): stop nightly drift from resurrecting dismissed insights Three generators stored continuously drifting values (projected amounts, starting balance, current net worth) in metadata, and any metadata diff counts as a material change: the body is rewritten (an LLM call when a provider is configured) and read/dismissed state is cleared. Dismissing a cash-flow warning was undone at the next 6:00 run. Metadata now carries only the signal identity plus a coarse bucket, the same damping the budget generators already use; display values live in facts. Also orders the idle-cash pick by balance so the selected accounts don't flip between runs, and documents the dollar-scale threshold assumption on the relevant constants. * fix(ds): map DS::Button aria_label into the aria hash A bare aria_label: option reaches the tag helpers as a literal aria_label attribute (Rails only dasherizes the nested aria: hash), so the icon-only fallback overrode it and screen readers announced the insight dismiss button and the popover trigger as "X". * fix(insights): gate LLM narration behind AI consent The nightly job runs unprompted for every family, so narration now requires someone in the family to have AI enabled: consent to share financial facts with the provider, and a cost cap in managed mode. The template fallback keeps behavior identical otherwise. Narration failures are captured via DebugLogEntry so support can see them. Adds BodyWriter coverage, including a template-interpolation test for every generator template key. * feat(insights): rework the dashboard feed The feed rendered full insight cards inside the section shell — the only widget nesting card-on-card — and appended below the fold for every family with a saved section order. It now mirrors the outflows and balance-sheet list idiom (inset well with an uppercase mini-header, white row block, 28px sentiment-tinted icon circles via color-mix on the DS CSS variables, right-aligned key figures) and leads the dashboard for saved orders that predate it. Icon color comes from sentiment, not priority — a savings-rate improvement is high priority AND good news, and must not render red; red is reserved for a projected-negative balance. Rows have no hover wash (cursor plus a gentle icon scale, like the sibling widgets), links to /insights disable Turbo prefetch so the mark-as-read actually fires for mouse users, and the standard widget-size popover offers Half/Full. Full stays the default: the feed is far shorter than any other single-width widget, so a half default leaves a grid hole the masonry cannot backfill. * feat(insights): actionable cards, dismiss undo, live refresh Each row now persists its display facts (new jsonb column) alongside the change-detection metadata. Facts refresh every run without touching the body or user state, which is exactly why they are not part of the material-change comparison. The card gains what the stored data always supported: a type-and-period meta line replacing "x minutes ago", a right-aligned key figure (green only for good news), and a contextual link resolved from the subject ids in metadata — category, account, recurring transaction, budget month — omitted when the subject no longer exists. Dismiss is forgiving: a toast in the notification tray offers undo, and undismissing restores the row as read rather than re-badging it. Milestone insights can never regenerate once dismissed, so this closes a real loss path. Upsert failures are captured via DebugLogEntry. Manual refresh gets feedback: the button swaps to a disabled checking state, the page subscribes to a family-scoped stream, and the job broadcasts the refreshed list and the idle button when it finishes (also after a lock-skipped run, so the button cannot stay stuck). Savings copy is sign-aware: a negative rate reads "you spent more than you earned" with true minus signs. The empty state swaps Lucide sparkles for the brand assistant glyph (DS::EmptyState learns icon_custom:). * feat(insights): top-bar entry with unread count The dashboard feed hides at zero insights and nothing else linked to /insights, so the manual refresh (and the empty state) were unreachable for exactly the families who need them: fresh setups before the first 6:00 run. The sticky top bar travels to every screen and its right cluster had room, so insights get an icon entry there with a monochrome unread badge. Prefetch is disabled on the link for the same mark-as-read reason as the feed. --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Guillem Arias <accounts@gariasf.com>
122 lines
4.3 KiB
Ruby
122 lines
4.3 KiB
Ruby
require "test_helper"
|
|
|
|
class InsightsHelperTest < ActionView::TestCase
|
|
test "positive types render success regardless of priority" do
|
|
insight = build_insight("net_worth_milestone", priority: "high", metadata: { "milestone" => 500_000 })
|
|
|
|
assert_equal :positive, insight_sentiment(insight)
|
|
assert_equal "success", insight_icon_color(insight)
|
|
end
|
|
|
|
test "savings rate improvement is positive even at high priority" do
|
|
insight = build_insight(
|
|
"savings_rate_change",
|
|
priority: "high",
|
|
metadata: { "current_rate" => 32.5, "previous_rate" => 20.1 }
|
|
)
|
|
|
|
assert_equal :positive, insight_sentiment(insight)
|
|
assert_equal "success", insight_icon_color(insight)
|
|
end
|
|
|
|
test "savings rate drop warns without going red" do
|
|
insight = build_insight(
|
|
"savings_rate_change",
|
|
priority: "high",
|
|
metadata: { "current_rate" => -5.4, "previous_rate" => 45.2 }
|
|
)
|
|
|
|
assert_equal :warning, insight_sentiment(insight)
|
|
assert_equal "warning", insight_icon_color(insight)
|
|
end
|
|
|
|
test "spending anomaly direction decides sentiment" do
|
|
above = build_insight("spending_anomaly", metadata: { "direction" => "above" })
|
|
below = build_insight("spending_anomaly", metadata: { "direction" => "below" })
|
|
|
|
assert_equal :warning, insight_sentiment(above)
|
|
assert_equal :positive, insight_sentiment(below)
|
|
end
|
|
|
|
test "only a projected-negative balance renders destructive" do
|
|
negative = build_insight("cash_flow_warning", priority: "high", metadata: { "negative" => true })
|
|
low = build_insight("cash_flow_warning", priority: "medium", metadata: { "negative" => false })
|
|
|
|
assert_equal "destructive", insight_icon_color(negative)
|
|
assert_equal "warning", insight_icon_color(low)
|
|
end
|
|
|
|
test "informational types stay neutral" do
|
|
%w[subscription_audit idle_cash].each do |type|
|
|
assert_equal :neutral, insight_sentiment(build_insight(type))
|
|
assert_equal "default", insight_icon_color(build_insight(type))
|
|
end
|
|
end
|
|
|
|
test "rows written before the metadata shape change degrade safely" do
|
|
stale = build_insight("cash_flow_warning", priority: "high", metadata: { "projected_low_amount" => 320.0 })
|
|
|
|
assert_equal :warning, insight_sentiment(stale)
|
|
end
|
|
|
|
test "meta line shows the type and a month-aligned period as the month name" do
|
|
insight = build_insight(
|
|
"savings_rate_change",
|
|
period_start: Date.new(Date.current.year, 6, 1),
|
|
period_end: Date.new(Date.current.year, 6, 30)
|
|
)
|
|
|
|
assert_equal "Savings rate · June", insight_meta_line(insight)
|
|
end
|
|
|
|
test "meta line labels a forward-looking window as next N days" do
|
|
insight = build_insight(
|
|
"cash_flow_warning",
|
|
period_start: Date.current,
|
|
period_end: Date.current + 30
|
|
)
|
|
|
|
assert_equal "Cash flow · Next 30 days", insight_meta_line(insight)
|
|
end
|
|
|
|
test "meta line falls back to the subject when there is no period" do
|
|
insight = build_insight("idle_cash", facts: { "account" => "Emergency fund" })
|
|
|
|
assert_equal "Idle cash · Emergency fund", insight_meta_line(insight)
|
|
end
|
|
|
|
test "key figure comes from facts and hides for rows without them" do
|
|
with_facts = build_insight("idle_cash", facts: { "balance" => "$28,400.00", "idle_days" => 60 })
|
|
without_facts = build_insight("idle_cash")
|
|
|
|
assert_equal "$28,400.00", insight_key_figure(with_facts).first
|
|
assert_nil insight_key_figure(without_facts)
|
|
end
|
|
|
|
test "action link resolves the stored subject and disappears when it cannot" do
|
|
account = families(:dylan_family).accounts.visible.first
|
|
resolvable = build_insight("idle_cash", metadata: { "account_id" => account.id })
|
|
dangling = build_insight("idle_cash", metadata: { "account_id" => SecureRandom.uuid })
|
|
|
|
assert_equal account_path(account), insight_action(resolvable)[:href]
|
|
assert_nil insight_action(dangling)
|
|
end
|
|
|
|
private
|
|
def build_insight(insight_type, priority: "medium", metadata: {}, facts: {}, period_start: nil, period_end: nil)
|
|
Insight.new(
|
|
family: families(:dylan_family),
|
|
insight_type: insight_type,
|
|
priority: priority,
|
|
status: "active",
|
|
title: "t",
|
|
body: "b",
|
|
metadata: metadata,
|
|
facts: facts,
|
|
period_start: period_start,
|
|
period_end: period_end,
|
|
dedup_key: "#{insight_type}:test"
|
|
)
|
|
end
|
|
end
|