mirror of
https://github.com/we-promise/sure.git
synced 2026-08-05 16:42:18 +00:00
* Add send_email_notification rule action Adds a new rule action that emails a digest of transactions matching a rule. Re-syncs re-apply every active rule to all in-window matches, so a notification_deliveries table (unique on rule_id + transaction_id) backs deduplication and a per-rule watermark: - Rule::ActionExecutor::SendEmailNotification plucks candidate ids, drops ones already in notification_deliveries, records the remainder BEFORE enqueuing (fail-safe: a crash suppresses rather than double-sends), and returns the count of newly-notified transactions. - RuleEmailNotificationJob loads the rule + transactions and delivers the digest via RuleNotificationMailer. - Creating the action pre-seeds all currently-matching transactions as already-delivered (after_create_commit), so the rule only emails about transactions appearing after the action exists. Dedup keys on the DB row id, not provider identity, so a re-ingested transaction (new id) may re-notify; accepted as benign. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Add view transactions link to rule notification digest email Include a "View transactions" CTA (APP_DOMAIN/transactions) in both the HTML and text versions of the rule notification digest email. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Address review feedback on rule email notifications - Restrict digest delivery to family admins only (drop non-admin fallback) - Make NotificationDelivery.record_for return only inserted ids and enqueue off that result, preventing duplicate digests under concurrent rule runs - Seed the notification baseline when an existing action is changed to send_email_notification, so historical matches are not emailed - Strengthen tests: assert the transactions CTA/link in the digest and the enqueued job's transaction-id args Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Include super_admin owner as rule digest recipient The admin-only recipient lookup used find_by(role: :admin), which excluded super_admin owners. A self-hosted family is commonly a single super_admin, so the digest was silently skipped (NullMail no-op) and no email was sent. Match the recipient on %w[admin super_admin] (the same pattern used elsewhere, and consistent with User#admin?), while still excluding regular members/guests. Add tests for the super_admin recipient and the no-admin skip path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Add mixed-role digest recipient test Cover the case where a family has both an admin and a super_admin. The recipient lookup uses find_by(role: %w[admin super_admin]) with no ORDER BY, so which one is returned is non-deterministic; the contract is only that the recipient is an admin-level user (never a member). Assert recipient.admin? rather than a brittle precedence between the two roles. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Deliver rule digest via deliver_later and order in DB Use deliver_later so a slow/flaky SMTP connection doesn't tie up the Sidekiq worker, and push the entry-date sort into the query instead of materializing and sorting the result set in Ruby. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Replace raw hex colors with email-safe design tokens in digest template The rule digest email hardcoded Tailwind slate-100/200 hex values for table borders, which aren't part of this project's design system. Resolve to the actual border-primary/border-secondary token values and centralize them as a reusable .email-table class in the mailer layout. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
79 lines
4.1 KiB
Ruby
79 lines
4.1 KiB
Ruby
require "test_helper"
|
|
|
|
class RuleNotificationMailerTest < ActionMailer::TestCase
|
|
include EntriesTestHelper
|
|
|
|
test "digest" do
|
|
rule = rules(:one)
|
|
rule.update!(name: "Coffee rule")
|
|
family = rule.family
|
|
admin = family.users.find_by(role: %w[admin super_admin])
|
|
account = family.accounts.create!(name: "Mailer test", balance: 100, currency: "USD", accountable: Depository.new)
|
|
txn = create_transaction(date: Date.current, account: account, amount: 100, name: "Coffee").transaction
|
|
|
|
mail = RuleNotificationMailer.digest(rule: rule, transactions: [ txn ])
|
|
|
|
# The mailer derives the recipient from rule.family, so assert against that
|
|
# admin explicitly rather than an unrelated fixture.
|
|
assert_equal [ admin.email ], mail.to
|
|
assert_equal I18n.t(
|
|
"rule_notification_mailer.digest.subject",
|
|
count: 1,
|
|
product_name: Rails.configuration.x.product_name
|
|
), mail.subject
|
|
assert_match "Coffee", mail.body.encoded
|
|
|
|
# The "View transactions" CTA must link to the transactions page in both parts.
|
|
html = mail.html_part.body.encoded
|
|
text = mail.text_part.body.encoded
|
|
assert_match I18n.t("rule_notification_mailer.digest.cta"), html
|
|
assert_match %r{/transactions}, html
|
|
assert_match %r{/transactions}, text
|
|
end
|
|
|
|
test "digest is delivered to the super_admin owner when there is no plain admin" do
|
|
# A self-hosted family is commonly a single super_admin (the owner) with no
|
|
# :admin user. The owner must still receive the digest.
|
|
family = Family.create!(name: "Solo owner family", currency: "USD")
|
|
owner = User.create!(family: family, email: "solo-owner@example.com", password: "password123", role: :super_admin)
|
|
account = family.accounts.create!(name: "Mailer test", balance: 100, currency: "USD", accountable: Depository.new)
|
|
txn = create_transaction(date: Date.current, account: account, amount: 100, name: "Coffee").transaction
|
|
rule = Rule.new(family: family, resource_type: "transaction", name: "Coffee rule")
|
|
|
|
mail = RuleNotificationMailer.digest(rule: rule, transactions: [ txn ])
|
|
|
|
assert_equal [ owner.email ], mail.to
|
|
end
|
|
|
|
test "digest recipient is an admin-level user when both admin and super_admin exist" do
|
|
# find_by(role: %w[admin super_admin]) has no ORDER BY, so which of the two
|
|
# is returned is not deterministic and precedence is intentionally undefined.
|
|
# The contract is only that the recipient is admin-level, never a member.
|
|
family = Family.create!(name: "Mixed roles family", currency: "USD")
|
|
User.create!(family: family, email: "the-admin@example.com", password: "password123", role: :admin)
|
|
User.create!(family: family, email: "the-super-admin@example.com", password: "password123", role: :super_admin)
|
|
User.create!(family: family, email: "the-member@example.com", password: "password123", role: :member)
|
|
account = family.accounts.create!(name: "Mailer test", balance: 100, currency: "USD", accountable: Depository.new)
|
|
txn = create_transaction(date: Date.current, account: account, amount: 100, name: "Coffee").transaction
|
|
rule = Rule.new(family: family, resource_type: "transaction", name: "Coffee rule")
|
|
|
|
mail = RuleNotificationMailer.digest(rule: rule, transactions: [ txn ])
|
|
|
|
recipient = family.users.find_by!(email: mail.to.first)
|
|
assert recipient.admin?, "expected an admin-level recipient, got role=#{recipient.role}"
|
|
end
|
|
|
|
test "digest is skipped when the family has no admin or super_admin" do
|
|
# Transaction details must never go to a regular member/guest.
|
|
family = Family.create!(name: "No-admin family", currency: "USD")
|
|
User.create!(family: family, email: "member-only@example.com", password: "password123", role: :member)
|
|
account = family.accounts.create!(name: "Mailer test", balance: 100, currency: "USD", accountable: Depository.new)
|
|
txn = create_transaction(date: Date.current, account: account, amount: 100, name: "Coffee").transaction
|
|
rule = Rule.new(family: family, resource_type: "transaction", name: "Coffee rule")
|
|
|
|
assert_no_emails do
|
|
RuleNotificationMailer.digest(rule: rule, transactions: [ txn ]).deliver_now
|
|
end
|
|
end
|
|
end
|