mirror of
https://github.com/we-promise/sure.git
synced 2026-06-01 08:49:01 +00:00
174f7e6be6
* feat(binance): add full account sync and transaction processing - Fixed a bug that hindered Account setup - Wire up Binance accounts, sync statistics, and unlinked account tracking in the accounts dashboard. - Support setting a sync_start_date during Binance account setup. - Set Binance accounts' opening balance to zero to ensure the ledger builds cleanly from the actual trade history. - Expand the Binance importer and processor to handle Spot, Margin, Earn, P2P, and Futures trades and assets. - Implement TransactionBuilder to parse raw Binance trades, accurately calculating fees, base/quote asset amounts, and market values for proper ledger integration. - Update Binance API timeout (`recvWindow`) to 60,000ms to prevent connection drops. These changes provide comprehensive support for tracking Binance portfolios, ensuring accurate historical ledgers and proper visibility of sync statuses in the frontend dashboard. * refactor(binance): enforce strong params, double-entry safety, and native fiat currency support - Implement strong parameters in BinanceItemsController#complete_account_setup to satisfy Rails security guidelines. - Add robust date parsing with a grace fallback to prevent controller crashes on malformed sync start dates. - Wrap P2P transaction creations inside a database transaction block to guarantee ledger integrity and prevent orphan records. - Optimize P2P deduplication queries by batching checks for both transaction and funding external IDs. - Shift P2P entry persistence from forced USD tracking to native fiat values extracted directly from the Binance API payload. - Update BinanceAccount::ProcessorTest assertions and fixtures to validate native fiat and fee calculation logic. * fix(binance): process sync trades before caching transaction payload - Reorder Binance processor execution to insert trade records into the database prior to updating the `raw_transactions_payload` cache. This guarantees that if a database insertion fails, the cache won't prematurely mark the sync as successful, ensuring the data is retried on the next run. - Move `set_opening_anchor_balance(balance: 0)` out of the generic crypto exchange account builder and apply it specifically during Binance account creation. - Refactor date parsing in BinanceItemsController to explicitly catch `ArgumentError` via a block instead of using a blanket inline `rescue`. - Clean up the `setup_accounts` view template by removing hardcoded default translation strings. * fix(binance): enhance trade sync logic and error propagation - Pass `startTime` (from `sync_start_date`) to spot and futures trade endpoints on initial sync to optimize data fetching. - Include previously synced futures pairs alongside spot pairs when resolving relevant symbols to properly recover sold-out assets. - Re-raise exceptions in processor rescue blocks to prevent silent failures and ensure errors are correctly propagated to background jobs. - Decrease Binance API `recvWindow` from 60000ms to 5000ms to align with recommended default timeout values.
95 lines
2.8 KiB
Ruby
95 lines
2.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "test_helper"
|
|
|
|
class BinanceItem::ImporterTest < ActiveSupport::TestCase
|
|
setup do
|
|
@family = families(:dylan_family)
|
|
@item = BinanceItem.create!(family: @family, name: "B", api_key: "k", api_secret: "s")
|
|
@provider = mock
|
|
@provider.stubs(:get_spot_price).returns("50000.0")
|
|
|
|
stub_spot_result([ { symbol: "BTC", free: "1.0", locked: "0.0", total: "1.0" } ])
|
|
stub_margin_result([])
|
|
stub_earn_result([])
|
|
stub_futures_result([])
|
|
end
|
|
|
|
test "creates a binance_account of type combined" do
|
|
assert_difference "@item.binance_accounts.count", 1 do
|
|
BinanceItem::Importer.new(@item, binance_provider: @provider).import
|
|
end
|
|
|
|
ba = @item.binance_accounts.first
|
|
assert_equal "combined", ba.account_type
|
|
assert_equal "USD", ba.currency
|
|
end
|
|
|
|
test "calculates combined USD balance" do
|
|
@provider.stubs(:get_spot_price).with("BTCUSDT").returns("50000.0")
|
|
|
|
BinanceItem::Importer.new(@item, binance_provider: @provider).import
|
|
|
|
ba = @item.binance_accounts.first
|
|
assert_in_delta 50000.0, ba.current_balance.to_f, 0.01
|
|
end
|
|
|
|
test "stablecoins counted at 1.0 without API call" do
|
|
stub_spot_result([ { symbol: "USDT", free: "1000.0", locked: "0.0", total: "1000.0" } ])
|
|
|
|
@provider.expects(:get_spot_price).never
|
|
|
|
BinanceItem::Importer.new(@item, binance_provider: @provider).import
|
|
|
|
ba = @item.binance_accounts.first
|
|
assert_in_delta 1000.0, ba.current_balance.to_f, 0.01
|
|
end
|
|
|
|
test "skips BinanceAccount creation when all sources empty" do
|
|
stub_spot_result([])
|
|
stub_margin_result([])
|
|
stub_earn_result([])
|
|
stub_futures_result([])
|
|
|
|
assert_no_difference "@item.binance_accounts.count" do
|
|
BinanceItem::Importer.new(@item, binance_provider: @provider).import
|
|
end
|
|
end
|
|
|
|
test "stores source breakdown in raw_payload" do
|
|
BinanceItem::Importer.new(@item, binance_provider: @provider).import
|
|
|
|
ba = @item.binance_accounts.first
|
|
assert ba.raw_payload.key?("spot")
|
|
assert ba.raw_payload.key?("margin")
|
|
assert ba.raw_payload.key?("earn")
|
|
assert ba.raw_payload.key?("futures")
|
|
end
|
|
|
|
private
|
|
|
|
def stub_spot_result(assets)
|
|
BinanceItem::SpotImporter.any_instance.stubs(:import).returns(
|
|
{ assets: assets, raw: {}, source: "spot" }
|
|
)
|
|
end
|
|
|
|
def stub_margin_result(assets)
|
|
BinanceItem::MarginImporter.any_instance.stubs(:import).returns(
|
|
{ assets: assets, raw: {}, source: "margin" }
|
|
)
|
|
end
|
|
|
|
def stub_earn_result(assets)
|
|
BinanceItem::EarnImporter.any_instance.stubs(:import).returns(
|
|
{ assets: assets, raw: {}, source: "earn" }
|
|
)
|
|
end
|
|
|
|
def stub_futures_result(assets)
|
|
BinanceItem::FuturesImporter.any_instance.stubs(:import).returns(
|
|
{ assets: assets, raw: {}, source: "futures" }
|
|
)
|
|
end
|
|
end
|