mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 14:54:49 +00:00
* Add Google SSO onboarding flow for Flutter mobile app Previously, mobile users attempting Google SSO without a linked OIDC identity received an error telling them to link from the web app first. This adds the same account linking/creation flow that exists on the PWA. Backend changes: - sessions_controller: Cache pending OIDC auth with a linking code and redirect back to the app instead of returning an error - api/v1/auth_controller: Add sso_link endpoint to link Google identity to an existing account via email/password, and sso_create_account endpoint to create a new SSO-only account (respects JIT config) - routes: Add POST auth/sso_link and auth/sso_create_account Flutter changes: - auth_service: Detect account_not_linked callback status, add ssoLink and ssoCreateAccount API methods - auth_provider: Track SSO onboarding state, expose linking/creation methods and cancelSsoOnboarding - sso_onboarding_screen: New screen with tabs to link existing account or create new account, pre-filled with Google profile data - main.dart: Show SsoOnboardingScreen when ssoOnboardingPending is true https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Fix broken SSO tests: use MemoryStore cache and correct redirect param - Sessions test: check `status` param instead of `error` since handle_mobile_sso_onboarding sends linking info with status key - API auth tests: swap null_store for MemoryStore so cache-based linking code validation works in test environment https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Delay linking-code consumption until SSO link/create succeeds Split validate_and_consume_linking_code into validate_linking_code (read-only) and consume_linking_code! (delete). The code is now only consumed after password verification (sso_link) or successful user save (sso_create_account), so recoverable errors no longer burn the one-time code and force a full Google SSO roundtrip. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Make linking-code consumption atomic to prevent race conditions Move consume_linking_code! (backed by Rails.cache.delete) to after recoverable checks (bad password, policy rejection) but before side-effecting operations (identity/user creation). Only the first caller to delete the cache key gets true, so concurrent requests with the same code cannot both succeed. - sso_link: consume after password auth, before OidcIdentity creation - sso_create_account: consume after allow_account_creation check, before User creation - Bad password still preserves the code for retry - Add single-use regression tests for both endpoints https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Add missing sso_create_account test coverage for blank code and validation failure - Test blank linking_code returns 400 (bad_request) with proper error - Test duplicate email triggers user.save failure → 422 with validation errors https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Verify cache payload in mobile SSO onboarding test with MemoryStore The test environment uses :null_store which silently discards cache writes, so handle_mobile_sso_onboarding's Rails.cache.write was never verified. Swap in a MemoryStore for this test and assert the full cached payload (provider, uid, email, name, device_info, allow_account_creation) at the linking_code key from the redirect URL. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Add rswag/OpenAPI specs for sso_link and sso_create_account endpoints POST /api/v1/auth/sso_link: documents linking_code + email/password params, 200 (tokens), 400 (missing code), 401 (invalid creds/expired). POST /api/v1/auth/sso_create_account: documents linking_code + optional first_name/last_name params, 200 (tokens), 400 (missing code), 401 (expired code), 403 (creation disabled), 422 (validation errors). Note: RAILS_ENV=test bundle exec rake rswag:specs:swaggerize should be run to regenerate docs/api/openapi.yaml once the runtime environment matches the Gemfile Ruby version. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Preserve OIDC issuer through mobile SSO onboarding flow handle_mobile_sso_onboarding now caches the issuer from auth.extra.raw_info.iss so it survives the linking-code round trip. build_omniauth_hash populates extra.raw_info.iss from the cached issuer so OidcIdentity.create_from_omniauth stores it correctly. Previously the issuer was always nil for mobile SSO-created identities because build_omniauth_hash passed an empty raw_info OpenStruct. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Block MFA users from bypassing second factor via sso_link sso_link authenticated with email/password but never checked user.otp_required?, allowing MFA users to obtain tokens without a second factor. The mobile SSO callback already rejects MFA users with "mfa_not_supported"; apply the same guard in sso_link before consuming the linking code or creating an identity. Returns 401 with mfa_required: true, consistent with the login action's MFA response shape. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Fix NoMethodError in SSO link MFA test Replace non-existent User.generate_otp_secret class method with ROTP::Base32.random(32), matching the pattern used in User#setup_mfa!. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Assert linking code survives rejected SSO create account Add cache persistence assertion to "should reject SSO create account when not allowed" test, verifying the linking code is not consumed on the 403 path. This mirrors the pattern used in the invalid-password sso_link test. The other rejection tests (expired/missing linking code) don't have a valid cached code to check, so no assertion is needed there. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c --------- Co-authored-by: Claude <noreply@anthropic.com>
373 lines
13 KiB
Ruby
373 lines
13 KiB
Ruby
module Api
|
|
module V1
|
|
class AuthController < BaseController
|
|
include Invitable
|
|
|
|
skip_before_action :authenticate_request!
|
|
skip_before_action :check_api_key_rate_limit
|
|
skip_before_action :log_api_access
|
|
before_action :authenticate_request!, only: :enable_ai
|
|
before_action :ensure_write_scope, only: :enable_ai
|
|
before_action :check_api_key_rate_limit, only: :enable_ai
|
|
before_action :log_api_access, only: :enable_ai
|
|
|
|
def signup
|
|
# Check if invite code is required
|
|
if invite_code_required? && params[:invite_code].blank?
|
|
render json: { error: "Invite code is required" }, status: :forbidden
|
|
return
|
|
end
|
|
|
|
# Validate invite code if provided
|
|
if params[:invite_code].present? && !InviteCode.exists?(token: params[:invite_code]&.downcase)
|
|
render json: { error: "Invalid invite code" }, status: :forbidden
|
|
return
|
|
end
|
|
|
|
# Validate password
|
|
password_errors = validate_password(params[:user][:password])
|
|
if password_errors.any?
|
|
render json: { errors: password_errors }, status: :unprocessable_entity
|
|
return
|
|
end
|
|
|
|
# Validate device info
|
|
unless valid_device_info?
|
|
render json: { error: "Device information is required" }, status: :bad_request
|
|
return
|
|
end
|
|
|
|
user = User.new(user_signup_params)
|
|
|
|
# Create family for new user
|
|
# First user of an instance becomes super_admin
|
|
family = Family.new
|
|
user.family = family
|
|
user.role = User.role_for_new_family_creator
|
|
|
|
if user.save
|
|
# Claim invite code if provided
|
|
InviteCode.claim!(params[:invite_code]) if params[:invite_code].present?
|
|
|
|
# Create device and OAuth token
|
|
begin
|
|
device = MobileDevice.upsert_device!(user, device_params)
|
|
token_response = device.issue_token!
|
|
rescue ActiveRecord::RecordInvalid => e
|
|
render json: { error: "Failed to register device: #{e.message}" }, status: :unprocessable_entity
|
|
return
|
|
end
|
|
|
|
render json: token_response.merge(user: mobile_user_payload(user)), status: :created
|
|
else
|
|
render json: { errors: user.errors.full_messages }, status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
def login
|
|
user = User.find_by(email: params[:email])
|
|
|
|
if user&.authenticate(params[:password])
|
|
# Check MFA if enabled
|
|
if user.otp_required?
|
|
unless params[:otp_code].present? && user.verify_otp?(params[:otp_code])
|
|
render json: {
|
|
error: "Two-factor authentication required",
|
|
mfa_required: true
|
|
}, status: :unauthorized
|
|
return
|
|
end
|
|
end
|
|
|
|
# Validate device info
|
|
unless valid_device_info?
|
|
render json: { error: "Device information is required" }, status: :bad_request
|
|
return
|
|
end
|
|
|
|
# Create device and OAuth token
|
|
begin
|
|
device = MobileDevice.upsert_device!(user, device_params)
|
|
token_response = device.issue_token!
|
|
rescue ActiveRecord::RecordInvalid => e
|
|
render json: { error: "Failed to register device: #{e.message}" }, status: :unprocessable_entity
|
|
return
|
|
end
|
|
|
|
render json: token_response.merge(user: mobile_user_payload(user))
|
|
else
|
|
render json: { error: "Invalid email or password" }, status: :unauthorized
|
|
end
|
|
end
|
|
|
|
def sso_exchange
|
|
code = sso_exchange_params
|
|
|
|
if code.blank?
|
|
render json: { error: "invalid_or_expired_code", message: "Authorization code is required" }, status: :unauthorized
|
|
return
|
|
end
|
|
|
|
cache_key = "mobile_sso:#{code}"
|
|
cached = Rails.cache.read(cache_key)
|
|
|
|
unless cached.present?
|
|
render json: { error: "invalid_or_expired_code", message: "Authorization code is invalid or expired" }, status: :unauthorized
|
|
return
|
|
end
|
|
|
|
# Atomic delete — only the request that successfully deletes the key may proceed.
|
|
# This prevents a race where two concurrent requests both read the same code.
|
|
unless Rails.cache.delete(cache_key)
|
|
render json: { error: "invalid_or_expired_code", message: "Authorization code is invalid or expired" }, status: :unauthorized
|
|
return
|
|
end
|
|
|
|
render json: {
|
|
access_token: cached[:access_token],
|
|
refresh_token: cached[:refresh_token],
|
|
token_type: cached[:token_type],
|
|
expires_in: cached[:expires_in],
|
|
created_at: cached[:created_at],
|
|
user: {
|
|
id: cached[:user_id],
|
|
email: cached[:user_email],
|
|
first_name: cached[:user_first_name],
|
|
last_name: cached[:user_last_name],
|
|
ui_layout: cached[:user_ui_layout],
|
|
ai_enabled: cached[:user_ai_enabled]
|
|
}
|
|
}
|
|
end
|
|
|
|
def sso_link
|
|
linking_code = params[:linking_code]
|
|
cached = validate_linking_code(linking_code)
|
|
return unless cached
|
|
|
|
user = User.authenticate_by(email: params[:email], password: params[:password])
|
|
|
|
unless user
|
|
render json: { error: "Invalid email or password" }, status: :unauthorized
|
|
return
|
|
end
|
|
|
|
if user.otp_required?
|
|
render json: { error: "MFA users should sign in with email and password", mfa_required: true }, status: :unauthorized
|
|
return
|
|
end
|
|
|
|
# Atomically claim the code before creating the identity
|
|
return render json: { error: "Linking code is invalid or expired" }, status: :unauthorized unless consume_linking_code!(linking_code)
|
|
|
|
OidcIdentity.create_from_omniauth(build_omniauth_hash(cached), user)
|
|
|
|
SsoAuditLog.log_link!(
|
|
user: user,
|
|
provider: cached[:provider],
|
|
request: request
|
|
)
|
|
|
|
issue_mobile_tokens(user, cached[:device_info])
|
|
end
|
|
|
|
def sso_create_account
|
|
linking_code = params[:linking_code]
|
|
cached = validate_linking_code(linking_code)
|
|
return unless cached
|
|
|
|
email = cached[:email]
|
|
|
|
unless cached[:allow_account_creation]
|
|
render json: { error: "SSO account creation is disabled. Please contact an administrator." }, status: :forbidden
|
|
return
|
|
end
|
|
|
|
# Atomically claim the code before creating the user
|
|
return render json: { error: "Linking code is invalid or expired" }, status: :unauthorized unless consume_linking_code!(linking_code)
|
|
|
|
user = User.new(
|
|
email: email,
|
|
first_name: params[:first_name].presence || cached[:first_name],
|
|
last_name: params[:last_name].presence || cached[:last_name],
|
|
skip_password_validation: true
|
|
)
|
|
|
|
user.family = Family.new
|
|
|
|
provider_config = Rails.configuration.x.auth.sso_providers&.find { |p| p[:name] == cached[:provider] }
|
|
provider_default_role = provider_config&.dig(:settings, :default_role)
|
|
user.role = User.role_for_new_family_creator(fallback_role: provider_default_role || :admin)
|
|
|
|
if user.save
|
|
OidcIdentity.create_from_omniauth(build_omniauth_hash(cached), user)
|
|
|
|
SsoAuditLog.log_jit_account_created!(
|
|
user: user,
|
|
provider: cached[:provider],
|
|
request: request
|
|
)
|
|
|
|
issue_mobile_tokens(user, cached[:device_info])
|
|
else
|
|
render json: { errors: user.errors.full_messages }, status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
def enable_ai
|
|
user = current_resource_owner
|
|
|
|
unless user.ai_available?
|
|
render json: { error: "AI is not available for your account" }, status: :forbidden
|
|
return
|
|
end
|
|
|
|
if user.update(ai_enabled: true)
|
|
render json: { user: mobile_user_payload(user) }
|
|
else
|
|
render json: { errors: user.errors.full_messages }, status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
def refresh
|
|
# Find the refresh token
|
|
refresh_token = params[:refresh_token]
|
|
|
|
unless refresh_token.present?
|
|
render json: { error: "Refresh token is required" }, status: :bad_request
|
|
return
|
|
end
|
|
|
|
# Find the access token associated with this refresh token
|
|
access_token = Doorkeeper::AccessToken.by_refresh_token(refresh_token)
|
|
|
|
if access_token.nil? || access_token.revoked?
|
|
render json: { error: "Invalid refresh token" }, status: :unauthorized
|
|
return
|
|
end
|
|
|
|
# Create new access token
|
|
new_token = Doorkeeper::AccessToken.create!(
|
|
application: access_token.application,
|
|
resource_owner_id: access_token.resource_owner_id,
|
|
mobile_device_id: access_token.mobile_device_id,
|
|
expires_in: 30.days.to_i,
|
|
scopes: access_token.scopes,
|
|
use_refresh_token: true
|
|
)
|
|
|
|
# Revoke old access token
|
|
access_token.revoke
|
|
|
|
# Update device last seen
|
|
user = User.find(access_token.resource_owner_id)
|
|
device = user.mobile_devices.find_by(device_id: params[:device][:device_id])
|
|
device&.update_last_seen!
|
|
|
|
render json: {
|
|
access_token: new_token.plaintext_token,
|
|
refresh_token: new_token.plaintext_refresh_token,
|
|
token_type: "Bearer",
|
|
expires_in: new_token.expires_in,
|
|
created_at: new_token.created_at.to_i
|
|
}
|
|
end
|
|
|
|
private
|
|
|
|
def user_signup_params
|
|
params.require(:user).permit(:email, :password, :first_name, :last_name)
|
|
end
|
|
|
|
def validate_password(password)
|
|
errors = []
|
|
|
|
if password.blank?
|
|
errors << "Password can't be blank"
|
|
return errors
|
|
end
|
|
|
|
errors << "Password must be at least 8 characters" if password.length < 8
|
|
errors << "Password must include both uppercase and lowercase letters" unless password.match?(/[A-Z]/) && password.match?(/[a-z]/)
|
|
errors << "Password must include at least one number" unless password.match?(/\d/)
|
|
errors << "Password must include at least one special character" unless password.match?(/[!@#$%^&*(),.?":{}|<>]/)
|
|
|
|
errors
|
|
end
|
|
|
|
def valid_device_info?
|
|
device = params[:device]
|
|
return false if device.nil?
|
|
|
|
required_fields = %w[device_id device_name device_type os_version app_version]
|
|
required_fields.all? { |field| device[field].present? }
|
|
end
|
|
|
|
def device_params
|
|
params.require(:device).permit(:device_id, :device_name, :device_type, :os_version, :app_version)
|
|
end
|
|
|
|
def sso_exchange_params
|
|
params.require(:code)
|
|
end
|
|
|
|
def mobile_user_payload(user)
|
|
{
|
|
id: user.id,
|
|
email: user.email,
|
|
first_name: user.first_name,
|
|
last_name: user.last_name,
|
|
ui_layout: user.ui_layout,
|
|
ai_enabled: user.ai_enabled?
|
|
}
|
|
end
|
|
|
|
def build_omniauth_hash(cached)
|
|
OpenStruct.new(
|
|
provider: cached[:provider],
|
|
uid: cached[:uid],
|
|
info: OpenStruct.new(cached.slice(:email, :name, :first_name, :last_name)),
|
|
extra: OpenStruct.new(raw_info: OpenStruct.new(iss: cached[:issuer]))
|
|
)
|
|
end
|
|
|
|
def validate_linking_code(linking_code)
|
|
if linking_code.blank?
|
|
render json: { error: "Linking code is required" }, status: :bad_request
|
|
return nil
|
|
end
|
|
|
|
cache_key = "mobile_sso_link:#{linking_code}"
|
|
cached = Rails.cache.read(cache_key)
|
|
|
|
unless cached.present?
|
|
render json: { error: "Linking code is invalid or expired" }, status: :unauthorized
|
|
return nil
|
|
end
|
|
|
|
cached
|
|
end
|
|
|
|
# Atomically deletes the linking code from cache.
|
|
# Returns true only for the first caller; subsequent callers get false.
|
|
def consume_linking_code!(linking_code)
|
|
Rails.cache.delete("mobile_sso_link:#{linking_code}")
|
|
end
|
|
|
|
def issue_mobile_tokens(user, device_info)
|
|
device_info = device_info.symbolize_keys if device_info.respond_to?(:symbolize_keys)
|
|
device = MobileDevice.upsert_device!(user, device_info)
|
|
token_response = device.issue_token!
|
|
|
|
render json: token_response.merge(user: mobile_user_payload(user))
|
|
rescue ActiveRecord::RecordInvalid => e
|
|
render json: { error: "Failed to register device: #{e.message}" }, status: :unprocessable_entity
|
|
end
|
|
|
|
def ensure_write_scope
|
|
authorize_scope!(:write)
|
|
end
|
|
end
|
|
end
|
|
end
|