mirror of
https://github.com/apache/superset.git
synced 2026-05-07 08:54:23 +00:00
fix(chart & explore): Show labels for SliderControl (#19765)
* fix(chart & explore): make to show label of slidercontrol
* fix(chart & explore): make to update SliderControl props
* fix(chart & explore): make to fix lint
(cherry picked from commit dfbaba97c6)
This commit is contained in:
committed by
Ville Brofeldt
parent
8c8bbfb89f
commit
5567828ee8
@@ -18,19 +18,50 @@
|
||||
*/
|
||||
import React from 'react';
|
||||
import Slider from 'src/components/Slider';
|
||||
import ControlHeader from 'src/explore/components/ControlHeader';
|
||||
import ControlHeader, {
|
||||
ControlHeaderProps,
|
||||
} from 'src/explore/components/ControlHeader';
|
||||
|
||||
type SliderControlProps = {
|
||||
type SliderControlProps = ControlHeaderProps & {
|
||||
onChange: (value: number) => void;
|
||||
value: number;
|
||||
default?: number;
|
||||
};
|
||||
|
||||
export default function SliderControl(props: SliderControlProps) {
|
||||
const { onChange = () => {}, default: defaultValue, ...rest } = props;
|
||||
export default function SliderControl({
|
||||
default: defaultValue,
|
||||
name,
|
||||
label,
|
||||
description,
|
||||
renderTrigger,
|
||||
rightNode,
|
||||
leftNode,
|
||||
validationErrors,
|
||||
hovered,
|
||||
warning,
|
||||
danger,
|
||||
onClick,
|
||||
tooltipOnClick,
|
||||
onChange = () => {},
|
||||
...rest
|
||||
}: SliderControlProps) {
|
||||
const headerProps = {
|
||||
name,
|
||||
label,
|
||||
description,
|
||||
renderTrigger,
|
||||
rightNode,
|
||||
leftNode,
|
||||
validationErrors,
|
||||
onClick,
|
||||
hovered,
|
||||
tooltipOnClick,
|
||||
warning,
|
||||
danger,
|
||||
};
|
||||
return (
|
||||
<>
|
||||
<ControlHeader />
|
||||
<ControlHeader {...headerProps} />
|
||||
<Slider {...rest} onChange={onChange} defaultValue={defaultValue} />
|
||||
</>
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user