perf(dashboard): fix filter-box performance bug (#16702)

2026-04-19 16:14:52 +00:00 · 2021-09-15 13:40:46 +08:00
parent 7f804d62d1
commit b0ac5d1625
1 changed files with 8 additions and 1 deletions
--- a/superset-frontend/src/components/Select/DeprecatedSelect.tsx
+++ b/superset-frontend/src/components/Select/DeprecatedSelect.tsx
@@ -249,8 +249,15 @@ function styled<
    if (forceOverflow) {
      Object.assign(restProps, {
        closeMenuOnScroll: (e: Event) => {
+          // ensure menu is open
+          const menuIsOpen = (stateManager as BasicSelect<OptionType>)?.state
+            ?.menuIsOpen;
          const target = e.target as HTMLElement;
-          return target && !target.classList?.contains('Select__menu-list');
+          return (
+            menuIsOpen &&
+            target &&
+            !target.classList?.contains('Select__menu-list')
+          );
        },
        menuPosition: 'fixed',
      });