mirror of
https://github.com/apache/superset.git
synced 2026-04-07 10:31:50 +00:00
docs: correct spelling typos in project codebase (#35935)
This commit is contained in:
@@ -41,7 +41,7 @@ Note: Pillow is now a required dependency (previously optional) to support image
|
||||
- [33116](https://github.com/apache/superset/pull/33116) In Echarts Series charts (e.g. Line, Area, Bar, etc.) charts, the `x_axis_sort_series` and `x_axis_sort_series_ascending` form data items have been renamed with `x_axis_sort` and `x_axis_sort_asc`.
|
||||
There's a migration added that can potentially affect a significant number of existing charts.
|
||||
- [32317](https://github.com/apache/superset/pull/32317) The horizontal filter bar feature is now out of testing/beta development and its feature flag `HORIZONTAL_FILTER_BAR` has been removed.
|
||||
- [31590](https://github.com/apache/superset/pull/31590) Marks the begining of intricate work around supporting dynamic Theming, and breaks support for [THEME_OVERRIDES](https://github.com/apache/superset/blob/732de4ac7fae88e29b7f123b6cbb2d7cd411b0e4/superset/config.py#L671) in favor of a new theming system based on AntD V5. Likely this will be in disrepair until settling over the 5.x lifecycle.
|
||||
- [31590](https://github.com/apache/superset/pull/31590) Marks the beginning of intricate work around supporting dynamic Theming, and breaks support for [THEME_OVERRIDES](https://github.com/apache/superset/blob/732de4ac7fae88e29b7f123b6cbb2d7cd411b0e4/superset/config.py#L671) in favor of a new theming system based on AntD V5. Likely this will be in disrepair until settling over the 5.x lifecycle.
|
||||
- [32432](https://github.com/apache/superset/pull/31260) Moves the List Roles FAB view to the frontend and requires `FAB_ADD_SECURITY_API` to be enabled in the configuration and `superset init` to be executed.
|
||||
- [34319](https://github.com/apache/superset/pull/34319) Drill to Detail and Drill By is now supported in Embedded mode, and also with the `DASHBOARD_RBAC` FF. If you don't want to expose these features in Embedded / `DASHBOARD_RBAC`, make sure the roles used for Embedded / `DASHBOARD_RBAC`don't have the required permissions to perform D2D actions.
|
||||
|
||||
|
||||
@@ -81,7 +81,7 @@ test('sorts by clicking a column header', () => {
|
||||
expect(queryByTestId('mock-sort-desc')).not.toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('synchronizes the current sort when sortChanged event occured', async () => {
|
||||
test('synchronizes the current sort when sortChanged event occurred', async () => {
|
||||
const { findByTestId } = render(<Header {...mockedProps} />);
|
||||
act(() => {
|
||||
mockedProps.api.dispatchEvent(new Event('sortChanged'));
|
||||
|
||||
@@ -240,7 +240,7 @@ export default function exploreReducer(state = {}, action) {
|
||||
};
|
||||
|
||||
return {
|
||||
// Re run validation for dependant controls
|
||||
// Re run validation for dependent controls
|
||||
controlState: getControlStateFromControlConfig(
|
||||
controlState,
|
||||
overWrittenState,
|
||||
|
||||
@@ -163,7 +163,7 @@ class TestConnectionDatabaseCommand(BaseCommand):
|
||||
if not alive:
|
||||
raise DBAPIError(ex_str or None, None, None)
|
||||
|
||||
# Log succesful connection test with engine
|
||||
# Log successful connection test with engine
|
||||
event_logger.log_with_context(
|
||||
action=get_log_connection_action("test_connection_success", ssh_tunnel),
|
||||
engine=database.db_engine_spec.__name__,
|
||||
|
||||
@@ -221,11 +221,11 @@ class EmailNotification(BaseNotification): # pylint: disable=too-few-public-met
|
||||
return json.loads(self._recipient.recipient_config_json)["target"]
|
||||
|
||||
def _get_cc(self) -> str:
|
||||
# To accomadate backward compatability
|
||||
# To accommodate backward compatibility
|
||||
return json.loads(self._recipient.recipient_config_json).get("ccTarget", "")
|
||||
|
||||
def _get_bcc(self) -> str:
|
||||
# To accomadate backward compatability
|
||||
# To accommodate backward compatibility
|
||||
return json.loads(self._recipient.recipient_config_json).get("bccTarget", "")
|
||||
|
||||
@statsd_gauge("reports.email.send")
|
||||
|
||||
@@ -343,7 +343,7 @@ def get_event_logger_from_cfg_value(cfg_value: Any) -> AbstractEventLogger:
|
||||
textwrap.dedent(
|
||||
"""
|
||||
In superset private config, EVENT_LOGGER has been assigned a class
|
||||
object. In order to accomodate pre-configured instances without a
|
||||
object. In order to accommodate pre-configured instances without a
|
||||
default constructor, assignment of a class is deprecated and may no
|
||||
longer work at some point in the future. Please assign an object
|
||||
instance of a type that implements
|
||||
|
||||
@@ -91,7 +91,7 @@ def test_get_cache_key(screenshot_obj):
|
||||
|
||||
def test_get_from_cache_key(mocker: MockerFixture, screenshot_obj):
|
||||
"""get_from_cache_key should always return a ScreenshotCachePayload Object"""
|
||||
# backwards compatability test for retrieving plain bytes
|
||||
# backwards compatibility test for retrieving plain bytes
|
||||
fake_bytes = b"fake_screenshot_data"
|
||||
BaseScreenshot.cache = MockCache()
|
||||
BaseScreenshot.cache.set("key", fake_bytes)
|
||||
|
||||
Reference in New Issue
Block a user