mirror of
https://github.com/apache/superset.git
synced 2026-05-21 15:55:10 +00:00
fix(lint): drop unused labelsColor/labelsColorMap/cacheBusterProp destructuring
Commit 08aac73 ("address review: replace side-effect useMemo with
idiomatic hooks") removed the shouldComponentUpdate-style useMemo that
was the only consumer of these three props, but left them in the
destructuring block. This caused TS6133 "declared but never read"
errors in lint-frontend (tsc --noEmit). Drop the destructuring; the
props remain declared on the ChartRendererProps interface so the
component's public API is unchanged.
This commit is contained in:
@@ -200,8 +200,6 @@ function ChartRendererComponent({
|
||||
datasource,
|
||||
formData,
|
||||
latestQueryFormData,
|
||||
labelsColor,
|
||||
labelsColorMap,
|
||||
height,
|
||||
width,
|
||||
vizType: propVizType,
|
||||
@@ -214,7 +212,6 @@ function ChartRendererComponent({
|
||||
postTransformProps,
|
||||
source,
|
||||
emitCrossFilters,
|
||||
cacheBusterProp,
|
||||
onChartStateChange,
|
||||
} = restProps;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user