QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 07:35:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(build): remove Lodash filter and noop usage in superset-frontend (#32341)

Browse Source 
Signed-off-by: hainenber <dotronghai96@gmail.com>
This commit is contained in:
Đỗ Trọng Hải
2025-02-21 19:29:07 +07:00
committed by GitHub
parent c27aee2b14
commit f820f9a976
4 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Screengrid/Screengrid.tsx
View File

@@ -23,7 +23,6 @@
import { memo, useCallback, useEffect, useRef, useState } from 'react';
import { ScreenGridLayer } from '@deck.gl/aggregation-layers';
import { JsonObject, JsonValue, QueryFormData, t } from '@superset-ui/core';
import { noop } from 'lodash';
import sandboxedEval from '../../utils/sandbox';
import { commonLayerProps } from '../common';
import TooltipRow from '../../TooltipRow';
@@ -135,7 +134,7 @@ const DeckGLScreenGrid = (props: DeckGLScreenGridProps) => {
}, []);
const getLayers = useCallback(() => {
const layer = getLayer(props.formData, props.payload, noop, setTooltip);
const layer = getLayer(props.formData, props.payload, () => {}, setTooltip);
return [layer];
}, [props.formData, props.payload, setTooltip]);

3
superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts
View File

@@ -26,7 +26,6 @@ import {
getNumberFormatter,
getTimeFormatter,
} from '@superset-ui/core';
import { noop } from 'lodash';
import {
BaseTransformedProps,
@@ -166,7 +165,7 @@ export const allEventHandlers = (
setDataMask,
emitCrossFilters,
)
: noop,
: () => {},
contextmenu: contextMenuEventHandler(
groupby,
onContextMenu,

3
superset-frontend/src/features/home/ChartTable.tsx
View File

@@ -18,7 +18,6 @@
*/
import { useEffect, useMemo, useState } from 'react';
import { t } from '@superset-ui/core';
import { filter } from 'lodash';
import {
useChartEditModal,
useFavoriteStatus,
@@ -76,7 +75,7 @@ function ChartTable({
TableTab.Other,
);
const filteredOtherTabData = filter(otherTabData, obj => 'viz_type' in obj);
const filteredOtherTabData = otherTabData?.filter(obj => 'viz_type' in obj);
const {
state: { loading, resourceCollection: charts, bulkSelectEnabled },

6
superset-frontend/src/features/home/DashboardTable.tsx
View File

@@ -18,7 +18,6 @@
*/
import { useEffect, useMemo, useState } from 'react';
import { SupersetClient, t } from '@superset-ui/core';
import { filter } from 'lodash';
import { useFavoriteStatus, useListViewResource } from 'src/views/CRUD/hooks';
import { Dashboard, DashboardTableProps, TableTab } from 'src/views/CRUD/types';
import handleResourceExport from 'src/utils/export';
@@ -61,10 +60,7 @@ function DashboardTable({
TableTab.Other,
);
const filteredOtherTabData = filter(
otherTabData,
obj => !('viz_type' in obj),
);
const filteredOtherTabData = otherTabData.filter(obj => !('viz_type' in obj));
const {
state: { loading, resourceCollection: dashboards },