Commit Graph

462 Commits

Author SHA1 Message Date
Geido
c1b8a46d01 fix: Popover closes on change of dropdowns values (#12410) 2021-01-14 10:33:20 -08:00
Michael S. Molina
6731cd0be6 chore: apply capitalization guidelines - iteration 1 (#12447)
Apply capitalization guidelines defined in #12343 

Use sentence casing for most places.
2021-01-12 10:47:55 -08:00
Kamil Gabryjelski
ed53b0090e feat: Resizable dataset and controls panels on Explore view (#12411)
* Implement resizable panels on explore view

* Optimize chart rendering while resizing

* Make dataset column narrower

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-01-12 10:39:56 -08:00
Michael S. Molina
75f927b9eb Fixes control panel fields styling (#12236) (#12326) 2021-01-11 16:47:10 -08:00
Grace Guo
9618f0786c [explore] Prevent duplicated query by data table (#12404) 2021-01-11 11:37:54 -08:00
Yongjie Zhao
23263da9f3 feat(explore): add tooltip to timepicker label (#12401) 2021-01-10 21:52:02 -08:00
Yongjie Zhao
c327cb911e fix(explore): long metric name display (#12387)
* fix(explore): long metric name display

* add tooltip to control
2021-01-11 09:42:38 +08:00
Jesse Yang
9acf48fd1e chore: upgrade eslint, babel, and prettier (#12393) 2021-01-10 17:26:35 -08:00
Junlin Chen
6bee3a0581 chore: change Datasource to Dataset in Explore ui (#12402)
* chore(explore):change dataset to datasource in ui

* modal

* Add space

* Changing it back🤦🏾‍♀️

* Chargeback
2021-01-10 12:53:51 -08:00
Junlin Chen
f13f2e2ed3 chore: Fix typo “Rest” to “Reset” (#12392) 2021-01-09 19:40:28 -08:00
Duy Nguyen Hoang
99de8a49b6 fix: explore replace wrong standalone slice url (#12359) 2021-01-09 13:32:06 -08:00
Kamil Gabryjelski
5d04f7dbce fix: Data tables styling issues on Explore view (#12383)
* Fix sort icons wrapping

* Fix large table stretching chart section container

* Implement sticky paginattion

* Display "loading" when data is loading

* Lint fix
2021-01-09 18:04:53 +02:00
Kamil Gabryjelski
14ccbe43b3 Fix new metric popover showing previous popover's title (#12385) 2021-01-09 16:05:25 +02:00
Yongjie Zhao
64b49778c5 fix(explore): adhoc metric label and control value not consistent (#12381)
* fix(explore): adhoc metric label and control value not consistent

* minor fix

* fix lint
2021-01-09 17:59:09 +08:00
Ville Brofeldt
662b64960f fix(explore): clear custom label if removed (#12382) 2021-01-09 01:41:41 -08:00
Kamil Gabryjelski
6a3103ff49 Fix filter popover under data table (#12377) 2021-01-09 00:54:39 -08:00
Kamil Gabryjelski
41751529a6 Update samples table when datasource changes (#12378) 2021-01-09 10:11:42 +02:00
Phillip Kelley-Dotson
9c5be8e4d8 chore: make datasource search input sticky (#12365) 2021-01-08 17:08:07 -08:00
Kamil Gabryjelski
77b80c9431 fix: Fix chart resizing when using split view (#12362)
* Fix chart resizing when using split view

* Fix z-index issues
2021-01-08 15:20:51 -08:00
Kamil Gabryjelski
1d2789944c Fix running query on every change in chart controls (#12361) 2021-01-08 12:56:45 -08:00
Kamil Gabryjelski
fd15dff60e perf: Optimize performance of Results and Samples tables on Explore (#12257) 2021-01-08 12:07:51 -08:00
Nikola Gigić
737e6b4aee chore(dashboard): Add ErrorBoudary for AdhocFilter components (#12352)
* Add ErrorBoudary for AdhocFilter components

* Add tests

* typo fix
2021-01-08 20:58:26 +02:00
Victor Malai
4d279935df fix: Set width to pseudoelement to wrap filter box (#12306)
* fix: set width pseudoelement to wrap

* Fix

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
2021-01-08 10:09:37 -08:00
Lily Kuang
627642162b chore: change order of tab on explore data panel (#12335) 2021-01-07 16:50:11 -08:00
Geido
4e6613d11f fix(explore): metrics caret not expanding in datasource panel (#12305)
* Closes #12233

* Remove accordion and set both sections open
2021-01-06 22:48:22 -08:00
Phillip Kelley-Dotson
506edf432d fix: update search in datasource panel to use matchSorter (#12319)
* update search to use matchSorter

* remove conosles
2021-01-06 21:55:57 -08:00
Yongjie Zhao
1f8347228e fix(explore): timepicker show human readable string in pill (#12300)
* fix(explore): timepicker show human readable string in pill

* fix lint
2021-01-06 22:37:35 +08:00
Kamil Gabryjelski
e660723a2f fix(explore): bugs in Custom SQL editor in filter popover (#12278)
* Fix Save button disabled until clause is switched

* Fix 'undefined undefined' when sql query is empty

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-01-06 15:08:20 +02:00
Kamil Gabryjelski
c8ad5c90bd fix: Fixed width for dataset panel (#12221) 2021-01-05 21:08:03 -08:00
Michael S. Molina
1b908ab9f1 Fix tests errors and warnings - iteration 1 (#12212) (#12213) 2021-01-05 16:24:57 -08:00
Geido
147605cb40 fix: Issue #12004 timegrain not visibile (#12258)
* Fix hidden dropdown when overflowing

* Remove unnecessary space

* Remove unused var
2021-01-05 16:17:56 -08:00
Victor Malai
553b440e4b fix: Show Data panel on resize (#12250)
* Show Data panel on resize

* Revert back tableSectionHeight

* FIx lint
2021-01-05 16:13:07 -08:00
Kamil Gabryjelski
d204b024b7 Set datasource panel open by default (#12211) 2021-01-04 22:41:50 -08:00
Yongjie Zhao
b349edef29 feat(explore): Time picker enhancement follow up (#12208)
* refactor layout

* WIP

* fix typing

* styling

* fix lint

* frontend IT

* rename variable

* added quarter

* typos

* refine code structure
2021-01-04 18:29:17 -08:00
Kamil Gabryjelski
811e1b273b fix: Altered button crashing and title not updating on Explore view (#11960)
* Fix chart name not updating

* Fix AlteredSliceTag crashing

* Update name after it's changed in another modal
2021-01-04 16:14:06 -08:00
Kamil Gabryjelski
7cc0de1694 Refetch samples only when filters change (#11999) 2021-01-01 16:08:19 -08:00
Kamil Gabryjelski
f3ab1f41ee feat: Implement drag & drop for metrics and filters labels (#12184) 2020-12-24 20:46:37 -08:00
Agata Stawarz
4ac00a0954 fix(chart): rendering standalone chart and errors (#12179) 2020-12-23 11:06:08 +00:00
Ville Brofeldt
41fac6b0d9 fix(explore): save chart not working (#12178)
* fix(explore): save to dashboard not working

* fix test
2020-12-22 23:18:36 +02:00
Michael S. Molina
8682c6fc1c refactor: Fix anchor-is-valid lint warnings (#12010)
* Fix anchor-is-valid lint warnings

* Change IconTooltip to use named exports
2020-12-21 23:58:05 -08:00
Victor Malai
eecdd20301 refactor: Explore SaveModal to typescript (#11997)
* Explore SaveModal to typescript

* Fix test

* Fix

* Fix lint

* update SaveModal without any type

* Update

* Fix lint

* Fix lint

* Fix test

* Fix

* Fix

* Fix lint

* Refactor

* Fix
2020-12-21 08:56:36 -08:00
David Aaron Suddjian
b5dd0f32cc feat: Dynamically imported viz plugins (#10288)
* first attempts at dynamic plugin loading

* dynamic import working for explore

* memoize appropriately

* add a backend for dynamic plugins

* hack at getting dynamic plugins working with dashboards

* more work on making it work, + feature flag

* lint

* actions to fix explore state when plugins load

* handle dynamic control panel, functionify ExploreViewContainer

* fix: rearrange migrations branch

* fix: name and key as strings with length 50

* bundle url length 2000

* bundle url to text
for some reason not supported on my sql

* fix: too long varchart

* fix: pre-commit typing

* fix: licenses

* fix: add slice container was not initing feature flags

* fix: undo linting issue

* fix: adjust down revision again

* fix: adjust down revision again

* isort

* pylint

* god damn linters

* remove unnecessary(?) loading message

* only log non-standard errors

* testing

* python is terrible

* see above commit message

* fix imports in DynamicPluginProvider

* fix

* shift migration forward

* lint

* fix form data calculations to handle missing control config

* temp commit - waiting for superset-ui changes and crud fixes

* remove unnecessary todo

* use new superset-ui shared module function

* fetch the plugins instead of hardcoding the test one

* migration sort

* remove duplicated import statement

* format

* try moving the import 🙄

* copy

* fix frontend tests

* safe access

* comment out dead code

* isort

* disable pylint on necessary lines

* use @superset-ui/logging instead of console

* remove temp code

* rearrange some code

* try triggering mouseover in cypress before click

* use loading spinner instead of text

* trying to fix cypress

* attempt cypress fix

* customize permissions

* update package lock

* only admins can write to plugins by default

* better copy

* disable flaky tests

* use makeApi

* flaky tests

* cleanup code

* flaaaakkkyyyyyy

* dry

Co-authored-by: amitNielsen <amit.miran@nielsen.com>
2020-12-19 07:06:11 -08:00
Phillip Kelley-Dotson
585c8acd75 fix height (#12145) 2020-12-18 22:33:40 -08:00
David Aaron Suddjian
865beae3d8 feat(dashboard): Dashboard-Native Filters (#11814)
* wip: filter create modal

* add a feature flag

* automatic changes to package lock

* wip

* filter sidebar and basic state management

* move create button to the sidebar

* first step for edit filterconfig

* partially fix tests...

* edits to types and comments

* respect feature flag on the filter sidebar

* add filterconfig form

* get input state working

* feat: tree filter scopes UI

* fix: turn on flag

* sticky filter bar

* stop preferring default export

* feat: finish filter scoping

* fix: under toggle

* fix: title

* fix: add licence

* refactor: update TS

* fix: fix on reopen modal + validation

* new filter bar menu

* adding, but commenting out, bulk scoping action

* adding some placeholder buttons and styles therefor

* feat: add filter chart

* add relative path to package.json

* update modal

* a little input styling... just getting warmed up

* Revert "feat: add filter chart"

This reverts commit b1302d35b6.

* Revert "add relative path to package.json"

This reverts commit 26a7b40e18.

* https package lock idk

* feat: add filter chart

* add relative path to package.json

* flexboxes all the way down

* dynamically generate groupby and datasource in select control

* big wip

* fix target column name

* no importing nonexistent things

* styles and name editing

* Add hook for retrieval of all filter states

* start with a new filter when clicking add filter

* handle removed filters gracefully

* fix incorrect default filter configuration

* add fields to useAllFilterState

* add redux for filterconfigs

* add support for native_filters

* remove consoles

* improve filter removal

* unbreak infinite loop

* basic sidebar toggling working!

* collapsing and menu working more smoothly

* linting

* make dataset and column inputs work

* save filter values properly

* add dashboard event for filter updates

* guarded

* apply filters properly

* fix schema

* making New Filter button a link

* gridunits ftw

* centering modal

* tis not a button anymore! nixing type.

* plus and collapse buttons instead of "more" menu

* updating full size filter icons

* adding icons to filter collapsing/expanding

* turning off animation, but leaving class-based animation css

* fix linting error

* fix native filters for legacy charts

* updates test

* no individual apply buttons

* fix bugs with filter config modal

* remove redundant code

* switch to the filter with validation errors on submit

* separate form validation

* switch config button from add to edit

* update tests

* oops forgot to add the fancy new useChangeEffect hook

* comments and code reorganization

* rename native_filters to extr_form_data and move hook

* disable native filters in viz selector

* add cascading

* implement new extra form data api

* cleanup

* updates tests

* bump npm packages

* fix bad merge on package.json + lock

* lint

* replace in and not in with uppercase

* lint

* lint

* lint

* lint

* bulk test fix

* Sort select input alphabetically

* Change type for sorting elements

* fix rest of unit tests

* make filter operators all uppercase

* Hide Filter bar when there are no filters

* Show edit button for dashboard owners only

* Add visible argument to filters toggle function to avoid future regression

* Improve Toggle filters bar function

* lint

* fix js lint + set createNewOnOpen

* Handle setting extra form data in Filter Bar instead of Filter Control

* Add Handle apply filter function to Apply button

* Allow applying changes instantly

* Fix types

* remove console logs

* Add Error Boundary component to Filter bar and Filter Config Modal

* fix jest tests

* update native filters tests to pass

* reset cypress baseUrl

* remove unnecessary field

* cleanup: remove unused state fields

* move unrelated types to an appropriate location

* remove misplaced resource fetch error logic

* fix cascadeParentIds error

* fix cypress password

* initial attempt at fixing scope issue

* fix bad merge

* fix lint

* trying out makeApi for saving filters

* remove unused import

* fix test

* silence bad test

* add native-filter feat flag config

* oops fix here

* remove space

* Update superset-frontend/src/common/components/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* use styledMount in tests

* comment

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigurationLink.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* address PR feedback

* fix package lock

* null guards

* Fix charts resizing

* fix cypress tests

* add in nativefilters to form data

* fix lint and test

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Simcha Shats <simcha.shats@nielsen.com>
Co-authored-by: amitNielsen <amit.miran@nielsen.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-12-18 17:06:37 -08:00
Evan Rusackas
f653a8de30 fix(explore): overflow issue with metric options (#12129)
* fixing overflow issue

* lint!
2020-12-18 14:14:07 -08:00
Michael S. Molina
a6ac2c1245 Improves chart save and go button (#12125)
Resolves #11748
2020-12-18 13:17:31 -08:00
Kamil Gabryjelski
2a23744223 feat: Add Saved Metrics tab to metrics popover (#12123)
* Implement saved metrics

* Fix bug in sql editor

* Fix unit tests

* Fix outlines in popovers

* Add types for saved metrics

* Add translations

* Move savedMetricType to a separate file
2020-12-18 11:11:49 -08:00
Jesse Yang
8e625e0a64 fix: properly render booleans in FilterBox and explore page data preview (#12116) 2020-12-18 10:40:56 -08:00
simchaNielsen
49ec13c68c feat: Support multiple queries per request (#11880)
* refactor: add queriesData fields for multiple queries

* feat: support multi queries request

* lint: fix lint

* lint: fix lint

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

* fix: fix error case for multi queries

* feat: change queryResponse to queriesResponse

* fix: revert webpack

* test: fix tests

* chore: lint

* chore: adjust asyncEvent to multiple results

* fix: lint

* fix: eslint

* fix: another eslint rule

Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2020-12-18 09:15:27 -08:00
Phillip Kelley-Dotson
35addee3ae feat(explore-datasource): add new datasource tab to explore view (#12008)
* update to datsource tab

* second update

* style updates

* update style and fix metrics bug

* updates to datsource panel

* backgrounds and borders

* more updates

* shuffling some paddings around

* more updates

* moving some more paddings around!

* Fixing sidebar width

* using Global to adjust body layout

* update test and fix bug

* removing hotkeys

* layout fixes for short content, simplifying some class names

* more styles

* add tooltip to collapse and div clickable

* more updates

* more updates for styles and add list component

* update from comments

* vising cosmetic issue with line-wrapping drop down caret on controls sections

* controls area scrolling properly again.

* change lists to old list and updates from comments

* border radius from theme

* add length field and updates from comments

* more changes from comments

* integrate health with new control

* change callapse back from stylsheet more udpates

* substitution string

* more substitution strings

* fix tests

* datasource alignment

* taking margin off the search input

* update input to flex

* fix lint

* adjusting column/metric label stylng

* fixing scrollable area layout, one more color variable

* simplifying some styles

* nixing a bad left margin

* Using gridunit for padding

* using gridUnit for padding

* define types for datsource panel

* fixing a padding issue

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-12-18 01:49:05 -08:00