Commit Graph

462 Commits

Author SHA1 Message Date
Yongjie Zhao
b592cc7e73 feat(explore): time picker enhancement (#11418) 2020-12-17 18:27:21 -08:00
Kamil Gabryjelski
b61e243f39 feat(explore): metrics and filters controls redesign (#12095)
* Redesign metrics control

* Redesign filters control

* Bugfixes

* Fix unit tests

* Fix tests

* Code review fixes
2020-12-18 00:13:37 +02:00
Nikola Gigić
48fb8c0b77 fix(dataset): Page blanks on large data load (#11979)
* Implement pagination in <TableView> for Samples preview

* Increase page size

* Fix lint

* Render cells based on width

* Fix lint errors

* Additional tests and changes

* Search bar fix

* Additional fixes

* Suggested changes
2020-12-16 16:35:12 +02:00
Geido
0ee03ae440 fix: Closes #11864 - Duplicate PropertiesModal (#12038)
* Closes #11864

* Fix typo
2020-12-16 10:01:34 +02:00
Kamil Gabryjelski
794d318989 refactor: Migrate react-select to Antd Select in Metrics and Filters popovers (#12042)
* Migrate react-select to Antd select in Metrics popover

* Fix tests

* Migrate react-select to Antd select in Filters popover

* Migrate SelectControl to Antd Select

* Add label with number of options left
2020-12-15 21:20:10 -08:00
Grace Guo
8da1900d8a feat: add hook for dataset health check (#11970)
* feat: add hook for dataset health check

* add event log

* optimize datasource json data like certified data

* add unit test

* fix review comments

* extra code review comments
2020-12-15 18:12:06 -08:00
Geido
1afe91579e refactor: Existing Antd Collapse to enhanced (#12013)
* Move ProgressBar to Antd

* Remove trailing space

* Fix linting issues

* Export enhanced Progress only

* Move existing antd Collapse to enhanced Collapse

* Move enhanced props up to Collapse only

* Add stories for enhanced Collapse

* Add 100% height for overflow

* Improve text light story
2020-12-13 22:57:08 -08:00
Rob DiCiuccio
4d329071a1 feat(SIP-39): Async query support for charts (#11499)
* Generate JWT in Flask app

* Refactor chart data API query logic, add JWT validation and async worker

* Add redis stream implementation, refactoring

* Add chart data cache endpoint, refactor QueryContext caching

* Typing, linting, refactoring

* pytest fixes and openapi schema update

* Enforce caching be configured for async query init

* Async query processing for explore_json endpoint

* Add /api/v1/async_event endpoint

* Async frontend for dashboards [WIP]

* Chart async error message support, refactoring

* Abstract asyncEvent middleware

* Async chart loading for Explore

* Pylint fixes

* asyncEvent middleware -> TypeScript, JS linting

* Chart data API: enforce forced_cache, add tests

* Add tests for explore_json endpoints

* Add test for chart data cache enpoint (no login)

* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag

* Add tests for tasks/async_queries and address PR comments

* Bypass non-JSON result formats for async queries

* Add tests for redux middleware

* Remove debug statement

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Skip force_cached if no queryObj

* SunburstViz: don't modify self.form_data

* Fix failing annotation test

* Resolve merge/lint issues

* Reduce polling delay

* Fix new getClientErrorObject reference

* Fix flakey unit tests

* /api/v1/async_event: increment redis stream ID, add tests

* PR feedback: refactoring, configuration

* Fixup: remove debugging

* Fix typescript errors due to redux upgrade

* Update UPDATING.md

* Fix failing py tests

* asyncEvent_spec.js -> asyncEvent_spec.ts

* Refactor flakey Python 3.7 mock assertions

* Fix another shared state issue in Py tests

* Use 'sub' claim in JWT for user_id

* Refactor async middleware config

* Fixup: restore FeatureFlag boolean type

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-12-10 20:21:56 -08:00
Mayur Newase
8cc566792a fix(explore): changing metric aggregate doesn't update label (#11946)
* fix: [chart]heatmap selecting metrics does not update the query results
fixes issue #11866
title's label is overriding metric label.

* Using custom label to decide label of metrics.

* lint

* Tests fixed

* early metric label check while saving from ui

* early custom label check

* removed extra space

* no state mutations

* simplify

* removed log

* nned to fix linting issue

* Lint fixed
2020-12-10 09:30:57 +02:00
Victor Malai
e62cf0d84d fix : adhoc filter dropdown (#11963)
* Add z-index to popover

* Fix prettier

* Fix closing popover on select from dropdown

* Fix prettier

* Fix visibility change

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
2020-12-09 15:44:20 -08:00
Kamil Gabryjelski
6fe1f9d78a Debounce TextControl if change runs immediately after input (#11985) 2020-12-09 15:41:44 -08:00
Victor Malai
05258ebc6c fix(event-flow-viz): handle null metadata selection (#11885)
* Initialize object with empty array if is multiselect, fix 500 BE error

* modify data coming
2020-12-08 08:53:26 +02:00
Kamil Gabryjelski
41738df77d feat: Results table on Explore view (#11854)
* Upgrade react-split

* Implement split on ExploreChartPanel

* Implement tabs with collapse

* Fix run query button

* Fix copy to clipboard button

* Move table controls to separate file

* Make component more generic to handle samples

* Remove samples from DisplayQueryButton

* Move data tables to separate file

* Make split dynamically controlled

* Fix unit test

* Fix arrow not centered

* fixup! Fix arrow not centered

* Change copy button paddings

* Use translations

* Fix grammar in a comment

* Fix imports

* Use grid units

* Convert new files to typescript

* Fix after rebase

* Remove forceRender

* Fix big_number test

* Delay making request until panel is opened

* White background in south panel

* fixup! White background in south panel

* Lint fix

* Lint fix

* Remove redundant prop types

* Remove console log

* Delay loading samples until user switches tab

* Add debounce to filter input

* Use gridUnit for gutter sizes

* Change types object to Record<string, any>
2020-12-04 19:49:24 -08:00
Agata Stawarz
38d21acff6 fix: Check if annotation type is supported by the given chart type (#11876)
* Check if annotation type is supported by this kind of chart

* Check if annotation type exists
2020-12-03 10:23:23 -08:00
Grace Guo
61064b9634 add fix for extra comments for #11781 (#11902) 2020-12-02 18:13:42 -08:00
Victor Malai
07288789e2 fix: Show copy icon (#11847)
* Show copy icon

* Fix eslint

* Fix copy button on view query modal

* Remove comments
2020-12-01 23:40:02 -08:00
Kamil Gabryjelski
5ebc09b339 fix: Download as image not working on Dashboard view (#11778)
* Fix download as image not working on Dashboard view

* Fix menu not closing before making a screenshot

* Move hardcoded selectors to variables

* Fix linting issue

* Add comments

* Close menu before taking a screenshot on Explore view

* Use style.visibility instead of timeout to hide menu for screenshot

* Change const name to uppercase

* Move variable declarations to case
2020-11-30 09:16:38 -08:00
Agata Stawarz
43c69d52a4 fix: Adding and removing annotations (#11811)
* Fix creating new annotation layer and refactor AnnotationLayer component

* Refactor checking overrides keys in AnnotationLayer

* Fix adding and editing annotations. Refactor AnnotationLayer submit and remove functions

* Remove unused parent prop from AnnotationLayer

* Fix toggling annotation layer popover

* Revert extracting annotation props to nested object

* Clean up AnnotationLayer component

* Remove unnecessary import

* Use original name for identifying annotations in add/remove actions

* Change props order and rename removeAnnotation function

* Compare annotations by reference instead of name
2020-11-28 10:59:16 +02:00
Kamil Gabryjelski
9b68b65568 refactor: Replace react-bootstrap tooltips with Antd tooltips (#11737)
* Refactor tooltip in ColumnElement

* Refactor tooltip for Button 

* Remove redundant import

* Refactor tooltip in SqlEditor

* Increase line height in tooltip so that the text is centered

* Refactor tooltip in Link

* Refactor tooltip in AdhocMetricEditPopoverTitle

* Refactor tooltip from ControlHeader

* Refactor tooltip in DateFilterControl

* Refactor tooltip in VizTypeControl

* fixup! Refactor tooltip in AdhocMetricEditPopoverTitle

* Refactor tooltip in QueryAndSaveBtns

* fixup! Refactor tooltip in DateFilterControl

* Refactor tooltip in CopyToClipboard, fix cursor pointer

* Refactor tooltip in TooltipWrapper

* Refactor tooltip in Field/DatasourceEditor

* Remove redundant import

* Fix typing for placement prop

* Decrease margin in ColumnElement divider

* Change default export to named

* Move SqlLab Tooltip styles to Emotion

* Fix tests
2020-11-24 13:04:55 -08:00
Maxime Beauchemin
872a54d304 fix: annotation layer crashes when clearing type select (#11787) 2020-11-23 21:46:26 -08:00
Kamil Gabryjelski
cdd01f4851 fix: Null error when deleting the last owner label in DatasourceEditor/settings (#11752)
* Fix null error when deleting the last owner in SelectAsyncControl

* Replace "||" with "??"
2020-11-19 14:10:34 -08:00
Kamil Gabryjelski
8a39f2799a Fix "Select all" option in SelectControl (#11692) 2020-11-16 17:23:32 -08:00
Kamil Gabryjelski
3e6bcbb98d Remove "required" from SaveModal Add to dashboard field (#11693) 2020-11-16 15:07:24 -08:00
Elizabeth Thompson
b277f19808 keep placeholder on multiselect (#11289) 2020-11-12 11:36:24 -08:00
Ville Brofeldt
2718909314 feat: add ECharts BoxPlot chart (#11199)
* feat: add ECharts BoxPlot chart

* lint

* fix cypress tests

* lint

* remove viz.py shim

* bump plugin package

* skip non-legacy plugin cypress dashboard tests

* fix cypress tests

* disable cypress tests for non-leagcy charts

* fix bad rebase

* use midpoint interpolation for quartile calculation

* bump packages and add support for no groupby

* whitespace

* whitespace

* linting

* fix tests

* xit mathjs load test

* bump mathjs to 8.0.1

* disable cypress filter test for v1 charts
2020-11-12 10:01:04 +02:00
Kamil Gabryjelski
6ef4d2a991 Restructure chart header to wrap nicely (#11643) 2020-11-11 20:18:04 -08:00
Grace Guo
a9f9c4bbd5 [fix] handle null value in date filter (#11655) 2020-11-11 09:32:26 -08:00
Kamil Gabryjelski
98d1c6964c refactor: Remove reactable arc (#11535)
* Refactor DisplayQueryButton into functional component and use react-table

* Refactor EstimateQueryCostButton to functional component

* Use react-table instead of reactable-arc

* Remove reactable-arc dependency

* Add margin for copy button

* Make search case insensitive
2020-11-10 15:13:29 -08:00
Kamil Gabryjelski
0c6aeef927 Fix datetime picker issues (#11621) 2020-11-09 14:13:27 -08:00
Kamil Gabryjelski
a6bf95e30b fix: Filter and Metric popovers not closing after clicking Save (#11607)
* Fix filter popover not closing

* Fix metric popover not closing

* Add e2e tests
2020-11-06 14:23:12 -08:00
Kamil Gabryjelski
6d5d92a6fe fix: Issues with filters and metrics popovers (#11578)
* Fix bugs in AdhocFilterEditPopover

* Fix bugs in AdhocMetricEditPopover

* Remove handleMultiComparatorInputHeightChange function

* Fix tests
2020-11-05 20:00:43 -08:00
Kamil Gabryjelski
1490f3074d refactor: Replace react-bootstrap MenuItems with Antd Menu (#11554)
* Refactor SliceHeaderControls

* Refactor DisplayQueryButton

* Fix duplicate keys

* Refactor SliceAdder

* Move css from styles to Emotion

* Fix e2e test
2020-11-05 13:30:03 -08:00
Kasia Kucharczyk
091432ea8e Changed top overflow for charts. (#11579) 2020-11-05 11:35:41 -08:00
Kamil Gabryjelski
128ddfabb6 fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs (#11445)
* Fix paste not working in Metrics and Filter inputs

* Use noOp instead of empty function

* Use default Select component instead of OnPasteSelect

* Revert onPaste override
2020-11-04 13:48:48 -08:00
Kamil Gabryjelski
ad98981d9d refactor: Replace react-bootstrap MenuItems with Antd Menu (#11487)
* Remove MenuItem from CopyToClipboard

* Refactor DateFilterControl

* fixup! Remove MenuItem from CopyToClipboard

* Remove console log

* Refactor LanguagePicker

* Refactor HeaderActionsDropdown

* Remove dir with Menu component

* Add imports to common/components/index

* Fix after rebase
2020-11-04 13:47:25 -08:00
Kamil Gabryjelski
937f9ca277 refactor: Replace react-bootstrap dialogs with Antd dialogs (#11527)
* Refactor Dialogs in dashboard properties modal

* Refactor Dialogs in explore properties modal

* Refactor dialogs in DatasourceModal

* Refactor dialogs in ExploreResultsButton

* Remove react-bootstrap-dialog from ExploreCtasResultsButton

* Remove react-bootstrap-dialog dependency

* Remove unnecessary functions from Modal

* Bump antd version to fix a bug

* Fix unit tests

* Fix e2e test

* Change antd version to 4.5.4 to fix tests

* Reenable all tests in control

* Another version bump to fix tests
2020-11-03 22:07:21 -08:00
Jesse Yang
fac29f9dff refactor: rewrite and enhance chart control withVerification (#11435)
* refactor: rewrite and enhance chart control withVerification

* Add toasts for failed messages; fixes popover render
2020-11-02 15:06:20 -08:00
Hugh A. Miles II
6c6ded139b fix: Update "View In SQL Lab" Flow to render source query from datasource object (#11476) 2020-11-02 11:44:20 -08:00
Kamil Gabryjelski
19f2deb27f refactor: Replace react-bootstrap Modals with Antd in Explore (#11389)
* VizTypeControl

* SaveModal

* explore/PropertiesModal

* Fix e2e tests

* Remove console logs

* Fix tests

* Fix test

* Fix e2e test

* Remove unnecessary fragment

* Fix e2e tests

* Fix e2e test
2020-11-01 23:04:53 -08:00
Kamil Gabryjelski
55a3404b71 refactor: Replace react-bootstrap tabs with Antd tabs (#11118)
* Replace tabs in BuilderComponentPane

* Replace tabs in ControlPanelsContainer

* Replace tabs in AdhocMetricEditPopover

* Replace Tabs in DatasourceEditor

* Replace tabs in AdhocFilterEditPopover

* Replace tabs in DateFilterControl

* Bug fix

* Change Tab styles

* Fix tests

* Fix cypress tests

* Lint fix

* Fix tests

* Change Tabs style in ControlPanelsContainer

* Change tabs content height

* Lint fix

* Add data test

* Fix e2e test

* Move Tabs file to separate dir

* Fix after rebase

* Fix e2e tests

* Fix after rebase
2020-10-30 22:05:31 -07:00
Jesse Yang
e0503408de feat(explore): change save button text when users cannot override (#11281) 2020-10-29 09:41:29 -07:00
Kamil Gabryjelski
b2636f01bb fix: Explore popovers issues (#11428)
* Fix spaces and comas not working in filter popover

* Fix popup not opening automatically

* Add e2e test

* Remove only from test

* Remove redundant test, add checking label content

* Add comments to e2e test

* Fix unit test

* Use destructuring

* Always open popup for functions and saved metrics, too

* Fix popover for adhoc metrics too

* Small refactor to consistency

* Refactor for consistency

* Remove redundant functions

* Test fix

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2020-10-28 09:38:52 -07:00
adam-stasiak-polidea
a99d795eaf chore: cypress selectors refactor in explore module (#11309)
* cypress selectors refactor in explore module

* added delay to typing to make test more stable

* fixed missing click
2020-10-27 13:01:45 -07:00
David Aaron Suddjian
055781f4a9 fix filter highlighting (#11439) 2020-10-27 08:38:24 -07:00
Maxime Beauchemin
5b968e9651 fix: multiple issues with FilterPopover (#11412)
* fix: Custom SQL in FilterPopover

* Also fix #11394

* linting

* fix tests
2020-10-26 21:48:06 -07:00
Hugh A. Miles II
fd8f4e9215 feat(explore): update the order of datasource dropdown menu (#11424) 2020-10-26 20:44:44 -07:00
ʈᵃᵢ
910791b00b fix: better error message for chart properties modal (#11381) 2020-10-26 13:33:19 -07:00
Evan Rusackas
af337b9e5a Let the header wrap! (#10724) 2020-10-26 13:15:16 -07:00
Kamil Gabryjelski
894ca3c09b refactor: Use Modals from Antd instead of react-bootstrap (#11330)
* Refactor ModalTrigger to use antd modal

* Refactor a few components

* dynamic width

* Fix unit tests

* Use i18n for button text
2020-10-26 11:20:10 -07:00
Jesse Yang
8aecffd83b refactor: typing for explore Control and messageToasts (#11416) 2020-10-24 21:40:36 -07:00