Commit Graph

3866 Commits

Author SHA1 Message Date
John Bodley
c43d0fd378 [sqlparse] Fixing table name extraction for ill-defined query (#7029)
(cherry picked from commit 07c340cf82)
2019-03-18 15:41:57 -07:00
Maxime Beauchemin
b64a452a6d [sql lab] improve table name detection in free form SQL (#6793)
* [sql lab] improve table name detection in free form SQL

* flake

* Addressing comments

(cherry picked from commit 5a40f71710)
2019-03-18 15:41:52 -07:00
michellethomas
2357c4aabf Adding custom control overrides (#6956)
* Adding extraOverrides to line chart

* Updating extraOverrides to fit with more cases

* Moving extraOverrides to index.js

* Removing webpack-merge in package.json

* Fixing metrics control clearing metric

(cherry picked from commit e6194051f4)
2019-03-18 15:32:00 -07:00
John Bodley
9dd7e84a31 [sql-parse] Fixing LIMIT exceptions (#6963)
(cherry picked from commit 3e076cb60b)
2019-03-18 15:29:06 -07:00
John Bodley
5d8dd1424f [csv-upload] Fixing message encoding (#6971)
(cherry picked from commit 48431ab5b9)
2019-03-18 15:29:00 -07:00
John Bodley
f454dedd28 [main] Disable resetting main DB attributes (#6845)
(cherry picked from commit 60d5f89faa)
2019-03-18 15:25:32 -07:00
John Bodley
e967b268f4 [sqla] Fixing order-by for non-inner-joins (#6862)
(cherry picked from commit 5728946270)
2019-03-18 15:24:08 -07:00
michellethomas
a5d9a4e005 Adding template_params to datasource editor for sqla tables (#6869)
(cherry picked from commit b0f7f51ab7)
2019-03-18 15:23:58 -07:00
John Bodley
6b8954133a [datasource] Ensuring consistent behavior of datasource editing/saving. (#7037)
* Update datasource.py

* Update datasource.py

(cherry picked from commit c771625f10)
2019-03-18 13:28:43 -07:00
michellethomas
8ef2789f47 Adding warning message for sqllab save query (#7028)
(cherry picked from commit ead3d48133)
2019-03-18 11:26:46 -07:00
Conglei
0ebdb5643b fix inaccurate data calculation with adata rolling and contribution (#7035)
(cherry picked from commit 0782e831cd)
2019-03-17 23:33:34 -07:00
Grace Guo
b3af6a261f [fix] explore chart from dashboard missed slice title (#7046)
(cherry picked from commit a6d48d4052)
2019-03-17 23:33:12 -07:00
John Bodley
c54b067c6a [db-engine-spec] Aligning Hive/Presto partition logic (#7007)
(cherry picked from commit 05be866117)
2019-03-17 23:24:55 -07:00
michellethomas
bd65942e48 Changing time table viz to pass formatTime a date (#7020)
(cherry picked from commit 7f3c145b1f)
2019-03-17 23:20:24 -07:00
Grace Guo
50accda9d8 [fix] Cursor jumping when editing chart and dashboard titles (#7038)
(cherry picked from commit fc1770f7b7)
2019-03-17 23:20:08 -07:00
Christine Chambers
5ace576948 0.31.0rc17 2019-03-14 11:27:22 -07:00
Tom Hunter
927a584678 [WIP] fix user specified JSON metadata not updating dashboard on refresh (#7027)
(cherry picked from commit cc58f0e661)
2019-03-14 11:24:42 -07:00
Grace Guo
fafb824d9a 0.31.0rc16 2019-03-12 13:03:06 -07:00
Grace Guo
7b72985efb [fix] /superset/slice/id url is too long (#6989)
(cherry picked from commit 6a4d507ab6)
2019-03-12 10:54:33 -07:00
Hugh A. Miles II
b497d9e7d1 fix dashboard links in welcome page (#6756)
(cherry picked from commit 6b0ab2100d)
2019-03-12 10:43:20 -07:00
Christine Chambers
c42afa11b9 0.31.0rc15 2019-03-08 16:32:53 -08:00
Conglei
35c55278dd Enhancement of query context and object. (#6962)
* added more functionalities for query context and object.

* fixed cache logic

* added default value for groupby

* updated comments and removed print

(cherry picked from commit d5b9795f87)
2019-03-08 16:29:51 -08:00
Christine Chambers
1c41020c73 Split tags migration (#7002)
This PR removes the iteration over charts, dashboards and saved queries to create tags in the original migration, leaving only the logic to create the tags and the tagged objects tables.
Tested locally by running `superset db downgrade` to revert to the previous migration and then running `superset db upgrade` to the current version.

(cherry picked from commit e47a1b2868)
2019-03-08 16:28:20 -08:00
Christine Chambers
ec7a0b22ab 0.31.0rc14 2019-03-01 19:45:21 -08:00
Maxime Beauchemin
4655cb4c23 Remove Cypress from package.json (#6912)
* Remove Cypress from package.json

I'm building some Docker images these days and realizing just how big
the Cypress package is. Looks like its ~500mb or so.

I prefer adding it as needed only as opposed to having to play tricks as
in `npm ci && rm node_modules/cypress`

* Pin cypress version

* Add script entry install-cypress

* bump cypress and fix ts-jest warning

(cherry picked from commit 8f2ce75665)
2019-03-01 19:44:23 -08:00
Christine Chambers
fb8e3208db 0.31.0rc13 2019-02-28 17:59:24 -08:00
Kim Truong
b4cbe13d22 VIZ-190 fix (#6958)
(cherry picked from commit 5026401171)
2019-02-28 17:57:37 -08:00
Christine Chambers
5b7b22fd25 0.31.0rc12 2019-02-27 10:40:39 -08:00
Beto Dealmeida
5180422942 Fix deck.gl form data (#6953)
* Fix deck.gl viz

* Fix more form data

* Fix a few more places

* Fix unit tests

(cherry picked from commit e0feec9117)
2019-02-27 10:39:22 -08:00
Christine Chambers
9939a52d0d 0.31.0rc11 2019-02-25 16:31:36 -08:00
Christine Chambers
c3db74d902 Fix rendering regression from the introduction of bignumber (#6937)
In superset-ui 0.8.0, we used bignumber.js to transform numbers in chartProps' payload from plain 64-bit floats to BigNumber instances. This causes a number of charts to render incorrectly when comparison functions in the rendering algorithms operate on BigNumber objects instead of floats. This PR uses the preTransformProps step in SuperChart to transform BigNumber instances back to floats so charts can render properly.

(cherry picked from commit 73cdb37f7e)
2019-02-25 16:29:34 -08:00
Christine Chambers
9940d30a7f 0.31.0rc10 2019-02-20 16:12:08 -08:00
Christine Chambers
3df2b8d57b Add a safety check before getting clientHeight (#6923)
Seeing an intermittent repro of the `current` nodes of the sql editor and south pane refs returning null. Adding a safety check for both nodes.

(cherry picked from commit c04c0cd8f0)
2019-02-20 14:31:59 -08:00
Christine Chambers
ccb51385e4 v0.31.0rc9 2019-02-19 16:24:51 -08:00
Beto Dealmeida
db0235fbdb Fix database typeahead in SQL Lab (#6917)
* Fix database typeahead in SQL Lab

* Fix lint

* Use string interpolation

(cherry picked from commit 25ec00b3c6)
2019-02-19 16:11:09 -08:00
Christine Chambers
953d6dc9d6 Address tooltip's disappearance and stickiness (#6898)
* Address tooltip's disappearance and stickiness

Nvd3 attaches tooltips to the body of the dom, not the chart the tooltip is meant fo. On hover, it sets their opacity to 1. In order to address both their stickiness when chart reloads (PR #6805) and thier disappearance on scroll in dashboards (PR #6852), we introduce a shouldRemove parameter to `hideTooltips` and only remove them befor chart reloads. For the scroll events triggered on dashboards, we only hide the tooltips by setting their opacity to 0. When they get hovered over again, nvd3 sets their opacity to 1 which causes them to reappear.

* adding a comment about the shouldRemove parameter
2019-02-19 15:45:16 -08:00
Beto Dealmeida
c0eaa5f62d Fix extra_filters in multi line viz (#6868)
(cherry picked from commit b035185b1c5c4f4332bfc8c9f748166f8d43151f)
2019-02-19 12:51:08 -08:00
Beto Dealmeida
ebcadc1f50 Fix tooltip (#6895)
(cherry picked from commit 3f96b0c5c4)
2019-02-19 12:12:51 -08:00
Christine Chambers
5fa5acb5d5 Add show metadata button back to the explore view (#6911)
* Add show metadata button back to the explore view

- Add the show metadta button, accidentally removed from PR #6046, back to the explore view
- Remove dead code that is no longer reachable from DataSourceModal.jsx.

* Adding additional code back to make the button function and remove more dead code.

(cherry picked from commit f8cf0fb7f3)
2019-02-19 09:47:04 -08:00
Christine Chambers
ce76560ae8 v0.31.0rc8 2019-02-14 20:30:35 -08:00
Christine Chambers
8c549b46bd Relayout SQL Editor (#6872)
* Relayout SQL Editor

- Refactor SQL editor to remove usage of bootstrap col, row and collapse to simplify the layout
- Replace the react-split-pane libraray with react-split to allow custom styling of the gutter area without sacrifice correctness of the ace editor height calculation
- Rewrite the left pane animation via plain css transition and animate it to slide in and out
- General code and css clean up

* Smooth out the visual transition during dragging

(cherry picked from commit 19f82b729c7a939f12b1c5da6022c0fd76fa3ec9)

* Adjust how the height of the south pane is computed, fixing cypress tests

(cherry picked from commit ec6657ab2d)
2019-02-14 20:28:45 -08:00
Maxime Beauchemin
bfe18963d7 [cosmetic] TableSelector use <i> instead of <Button> for refresh (#6783)
* [cosmetic] TableSelector use <i> instead of <Button> for refresh

* Add ASF licenses

* css hover

* missing license

* remove license header

(cherry picked from commit 713b0ae4f4)
2019-02-14 20:28:20 -08:00
Christine Chambers
19b588b52b 0.31.0rc7 2019-02-12 10:21:18 -08:00
michellethomas
d7e038eaa5 Fixing issue where tooltip gets hidden on dashboard for all charts (#6852)
(cherry picked from commit 4638618545)
2019-02-11 16:52:32 -08:00
Christine Chambers
38e0ddacf1 0.31.0rc6 2019-02-08 15:17:17 -08:00
Krist Wongsuphasawat
b7d2bd09a7 Fix line chart overflowing the right side (#6829)
* Fix line chart overflowing the right side

* revert package-lock.json

* revert again

(cherry picked from commit 823555e07d)
2019-02-08 15:17:17 -08:00
Maxime Beauchemin
b7e02ab776 [sql lab] fix stuck offline (#6782)
(cherry picked from commit 36176f3e20)
2019-02-08 09:27:43 -08:00
Christine Chambers
8a7c245c54 0.31.0rc5 2019-02-06 14:29:26 -08:00
Beto Dealmeida
f24efa7250 Backend only tagging system (#6823)
This PR introduces the backend changes for a tagging system for Superset, allowing dashboards, charts and queries to be tagged. It also allows searching for a given tag, and will be the basis for a new landing page (see #5327).

# Implicit tags
Dashboard, chart and (saved) queries have implicit tags related to their owners, types and favorites. For example, all objects owned by the admin have the tag `owner:1`. All charts have the tag `type:chart`. Objects favorited by the admin have the tag `favorited_by:1`.

These tags are automatically added by a migration script, and kept in sync through SQLAlchemy event listeners. They are currently not surfaced to the user, but can be searched for. For example, it's possible to search for `owner:1` in the welcome page to see all objects owned by the admin, or even search for `owner:{{ current_user_id() }}`.

(cherry picked from commit 8041b63af6)
2019-02-06 14:18:50 -08:00
John Bodley
1ddacc42d0 [wtforms] Using wtforms-json which supports None (#5445)
(cherry picked from commit e1b907783a)
2019-02-06 14:17:51 -08:00