Hugh A. Miles II
c03771dc6d
fix: Owners selection in dataset edit UX ( #17063 )
...
* boilerplate
* update owner select component
* this is working
* update onchange
* refactorig
* you need to useMemo or things break
* update test
* prettier
* move logic into bootstrap data endpoint
* address concerns
* oops
* oops
* fix test
(cherry picked from commit 959fd763a8
2021-10-27 13:38:54 -07:00
Elizabeth Thompson
ed98027adc
add logging on successful data uploads ( #17065 )
...
(cherry picked from commit c2e1ab6550
2021-10-27 13:38:54 -07:00
Daniel Vaz Gaspar
6d1fbb0668
fix: don't log invalid redirect URL send by user ( #16955 )
2021-10-04 13:52:57 +01:00
Craig Rueda
ace9c78684
fix(explore): Ensuring parameters key is included ( #16949 )
...
* Ensuring parameters key is included
* Fixing linter
2021-10-03 15:07:13 -07:00
ofekisr
0d0c759cfe
refactor: sql lab command: separate concerns into different modules ( #16917 )
...
* chore move sql_execution_context to sqllab package
* add new helper methods into base Dao
* refactor separate get existing query concern from command
* refactor separate query access validation concern
* refactor separate get query's database concern from command
* refactor separate get query rendering concern from command
* refactor sqllab_execution_context
* refactor separate creating payload for view
* chore decouple command from superset app
* fix pylint issues
* fix failed tests
* fix pylint issues
* fix failed test
* fix failed black
* fix failed black
* fix failed test
2021-10-03 11:15:46 +03:00
ofekisr
3f784cc1c7
refactor: sql lab: handling command exceptions ( #16852 )
...
* chore: support error_type in SupersetException and method to convert the exception to dictionary
* chore: support error_type in SupersetException and method to convert the exception to dictionary
* refactor handling command exceptions fix update query status when query was not created
2021-09-29 16:20:42 +03:00
ofekisr
c520eb79b0
refactor: sqllab: move sqllab ralated enumns and utils to more logical place ( #16843 )
...
* refactor move QueryStatus to common
* refactor move apply_display_max_row_limit to sqllab package
* refactor move limiting_factor to sqllab package
* fix pylint issues
2021-09-26 21:15:57 +03:00
Michael S. Molina
596e1cdf9b
refactor: Changes the DatabaseSelector and TableSelector to use the new Select component ( #16483 )
2021-09-22 07:43:46 -03:00
Ville Brofeldt
4e3d4f6daf
feat: add global max row limit ( #16683 )
...
* feat: add global max limit
* fix lint and tests
* leave SAMPLES_ROW_LIMIT unchanged
* fix sample rowcount test
* replace max global limit with existing sql max row limit
* fix test
* make max_limit optional in util
* improve comments
2021-09-16 19:33:41 +03:00
John Bodley
fb4650a6eb
chore(pylint): Remove top-level disable ( #16589 )
...
* chore(pylint): Remove top-level disable
* Update examples.py
* Update command.py
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-09-15 09:30:23 -07:00
Beto Dealmeida
7f804d62d1
feat: show nice error page in prod ( #16695 )
2021-09-14 16:56:25 -07:00
Daniel Vaz Gaspar
5ac8ac0e6c
fix: don't send invalid URLs back to the user ( #16687 )
...
* fix: don't send bogus URLs back to the user
* lint, remove f string
2021-09-14 11:29:05 +01:00
John Bodley
1669947bcd
chore(pylint): Reenable too-many-lines check ( #16287 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-09-13 13:22:19 -07:00
cccs-joel
c6ac10716a
feat: show build number value in the About if present in the config ( #14955 )
2021-09-13 10:59:08 -07:00
ofekisr
29b635a0a1
refactor sql_json view endpoint: move all logic from view to ExecuteSqlCommand ( #16682 )
2021-09-13 20:04:59 +03:00
ofekisr
1cc726364a
refactor: sql_json view endpoint: use execution context instead of query ( #16677 )
...
* refactor sql_json view endpoint: use execution context instead of query
* fix failed tests
* fix failed tests
* refactor renaming enum options
2021-09-13 11:02:57 +03:00
ofekisr
51acadad74
refactor sql_json view endpoint: separate a response creation ( #16676 )
2021-09-12 15:02:55 +03:00
ofekisr
1429d9dab6
refactor sql_json view endpoint: extract methods and rearrange code ordering ( #16675 )
...
Co-authored-by: Jack Fragassi <jfragassi98@gmail.com >
2021-09-12 12:56:50 +03:00
ofekisr
dad55a78f4
refactor sql_json view endpoint: separate set the query's limiting concern into ad hod method ( #16653 )
2021-09-09 19:38:37 +03:00
ofekisr
267b327a3c
refactor sql_json view endpoint: separate query rendering concern into ad hod method ( #16649 )
2021-09-09 18:25:58 +03:00
ofekisr
62637f275f
refactor sql_json view endpoint: separate validate the query concern into ad hod method ( #16647 )
2021-09-09 17:11:17 +03:00
ofekisr
df7d9d5515
refactor sql_json view endpoint: separate save query concern into ad hod method ( #16646 )
2021-09-09 14:50:49 +03:00
Amit Miran
420dd5b94a
chore: Pylint downgrade ( #16617 )
...
* Update testing.in
* chore: downgrade pylint to 2.9.6
* downgrade dependence for pylint
* trim space
* pylint rules
Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com >
2021-09-08 08:19:15 +03:00
ofekisr
e60b489867
refactor sql_json view endpoint: separate concern into ad hod method ( #16595 )
2021-09-05 23:18:17 +03:00
ofekisr
be77ad2288
refactor: sql_json view endpoint: encapsulate ctas parameters ( #16548 )
...
* refactor sql_json view endpoint: encapsulate ctas parameters
* fix failed tests
* fix failed tests and ci issues
2021-09-05 16:34:26 +03:00
Rob DiCiuccio
4e380db3fd
fix: Support Jinja template functions in global async queries ( #16412 )
...
* Support Jinja template functions in async queries
* Pylint
* Add tests for async tasks
* Remove redundant has_request_context check
2021-09-03 14:33:29 +03:00
ofekisr
e947f8a4c8
refactor sql_json view endpoint: extract to method reuse code ( #16546 )
2021-09-01 19:24:33 +03:00
ofekisr
68c2a6d43a
refactor sql_json view endpoint: separate getting and checking existing query to ad hoc methods ( #16449 )
2021-08-31 19:55:45 +03:00
Ville Brofeldt
c5a5cf7db9
fix(datasets): add support for removing owners ( #16461 )
...
* fix(datasets): add support for removing owners
* default to current user
2021-08-31 22:27:09 +08:00
Shiva Raisinghani
d25b0967a1
feat: Add parquet upload ( #14449 )
...
* allow csv upload to accept parquet file
* fix mypy
* fix if statement
* add test for specificying columns in CSV upload
* clean up test
* change order in test
* fix failures
* upload parquet to seperate table in test
* fix error message
* fix mypy again
* rename other extensions to columnar
* add new form for columnar upload
* add support for zip files
* undo csv form changes except usecols
* add more tests for zip
* isort & black
* pylint
* fix trailing space
* address more review comments
* pylint
* black
* resolve remaining issues
2021-08-31 10:20:25 +03:00
AAfghahi
e2469162fa
fix: select database fix ( #16472 )
...
* select database fix
* made a backend change
2021-08-30 17:04:10 -07:00
Erik Ritter
8adc31d14c
Revert "chore: Changes the DatabaseSelector to use the new Select component ( #16334 )" ( #16478 )
...
This reverts commit c768941f2f
2021-08-26 22:28:04 -03:00
Ville Brofeldt
ac1d779a30
chore(ci): bump pylint to 2.10.2 ( #16463 )
2021-08-26 20:30:41 +03:00
Ville Brofeldt
18be181946
fix(explore): update overwrite button on perm change ( #16437 )
...
* fix(explore): update overwrite on perm change
* remove redundant user_id prop
* fix types
* fix user type
* fix tests
* fix lint
2021-08-26 06:24:33 +03:00
ofekisr
93c60e4021
refactor: sql_json view endpoint ( #16441 )
...
* refactor sql_json view endpoint
* fix pylint
* renaming
* renaming
Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com >
2021-08-25 15:51:48 +03:00
Grace Guo
78d8089b18
fix: Disable Slack notification method if no api token ( #16367 )
...
* feat: allow company choose alert/report notification methods
* fix: disable Slack as notification method if no api token
* fix unit test
* improve typing
2021-08-24 17:28:50 -07:00
Evan Rusackas
81241b6024
Revert "fix(explore): let admin overwrite slice ( #16290 )" ( #16408 )
...
This reverts commit d13b081cfe
2021-08-24 09:38:41 -06:00
Ville Brofeldt
f6637cac7d
fix(api): return total count on related endpoint ( #16397 )
...
* fix(api): return total count on related endpoint
* update response code from 400 to 422
2021-08-24 15:07:58 +03:00
David Aaron Suddjian
486ef6b81f
feat: config to customize bootstrap data overrides ( #16386 )
...
* feat: config to customize bootstrap data overrides
* comments
2021-08-23 14:40:14 -07:00
Michael S. Molina
c768941f2f
chore: Changes the DatabaseSelector to use the new Select component ( #16334 )
2021-08-23 15:41:03 -03:00
John Bodley
7e4c940314
chore(pylint): Enable useless-suppression check ( #16388 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-24 03:58:41 +12:00
Ville Brofeldt
d13b081cfe
fix(explore): let admin overwrite slice ( #16290 )
2021-08-17 10:55:33 +03:00
John Bodley
be7065faf8
chore(pylint): Reenable raise-missing-from check ( #16266 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-17 10:26:10 +12:00
John Bodley
8e07dd28bc
chore(pylint): Re-enable super-with-arguments check ( #16138 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-17 04:00:24 +12:00
John Bodley
24b43beff9
chore(pylint): Bump Pylint to 2.9.6 ( #16146 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com >
2021-08-14 10:32:28 +12:00
Michael S. Molina
720e5b111a
chore: Shows the dataset description in the gallery dropdown ( #16200 )
...
* chore: Shows the dataset description in the gallery dropdown
* chore: Adjusts the tooltip positioning, fixes the search and removes unnecessary bootstrap data
2021-08-13 15:08:12 -03:00
Yongjie Zhao
6cd15d54a0
refactor: external metadata fetch API ( #16193 )
...
* refactor: external metadata api
* fix comments
* fix ut
* fix fe lint
* fix UT
* fix UT
2021-08-13 20:56:42 +08:00
Phillip Kelley-Dotson
f0e3b68cc2
fix: ensure that users viewing chart does not automatically save edit data ( #16077 )
...
* add last_change_at migration
* add last_saved_by db migration
* finish rest of api migration
* run precommit
* fix name
* run precommitt
* remove unused mods
* merge migrations
* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* Update superset/migrations/versions/f6196627326f_update_chart_permissions.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
* fix test
* precommit
* remove print
* fix test
* change test
* test commit
* test 2
* test 3
* third time the charm
* fix put req
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net >
2021-08-10 10:29:49 -06:00
Elizabeth Thompson
5488a8a948
add config to hide some user menu items ( #16156 )
2021-08-10 09:03:13 -07:00
Grace Guo
85329c374e
refactor: remove unnecessary dataset queries from dashboard requests ( #16110 )
...
* refactor: remove unnecessary dataset queries from dashboard requests
* fix comments
2021-08-06 19:01:05 -07:00
