QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-11 19:05:24 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,469 Commits 483 Branches 544 Tags
dfd0ed395c7fc2abe0cf49b1cdba82936681e3b2
Commit Graph

8469 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Erik Ritter
dfd0ed395c fix: prevent caching error pages (#17100) 
(cherry picked from commit 031f594fa3)
 2021-11-22 16:11:45 -08:00
Beto Dealmeida
cca78f1b6e fix: accept headers on import (#17080) 
* fix: accept headers on import

* Add unit test

(cherry picked from commit 40e9add641)
 2021-11-22 16:11:44 -08:00
jinghua-qa
b4f4f4cdfa fix(other): column name in created content on profile page (#17029) 
* fix: fix name in created content on profile page

* add more fix on mutater

(cherry picked from commit f2d41dc416)
 2021-11-22 16:11:44 -08:00
Geido
5899ae163a fix: Exclude SUPERSET_DEFAULT from the list of available color schemes (#17018) 
* Handle SUPERSET_DEFAULT theme

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
(cherry picked from commit 14b7f6cdba)
 2021-11-22 16:11:44 -08:00
Phillip Kelley-Dotson
9459d09ae7 initial fix (#16998) 
(cherry picked from commit 2c8e06e929)
 2021-11-22 16:11:44 -08:00
Beto Dealmeida
0b8507fe77 fix: import should accept old keys (#17330) 
* fix: import should accept old keys

* Fix lint

* Preserve V1 schema
 2021-11-22 11:58:13 -08:00
Beto Dealmeida
c015e661a9 fix: clear 'delete' confirmation (#17345) 
* fix: clear 'delete' confirmation

* Add tests

(cherry picked from commit 43f4ab845a)
 2021-11-22 11:56:56 -08:00
Elizabeth Thompson
7d9f63eda7 fix: add fallback and validation for report and cron timezones (#17338) 
* add fallback and validation for report and cron timezones

* add logging to exception catch

* Run black

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
(cherry picked from commit f10bc6d8fe)
 2021-11-22 11:53:45 -08:00
Hugh A. Miles II
30c6ec07ef fix: Allow users to update database in Dataset Edit Modal (#17265) 
* add condition to fix save

* remove console.log

(cherry picked from commit d0bad96b1a)
 2021-11-22 11:53:45 -08:00
Elizabeth Thompson
680cdca14a fix: update values for default timezone selector (#17124) 
* update values for default timezone selector

* fix casing and comment

* Update TimezoneSelector.test.tsx

(cherry picked from commit ae4ced8da6)
 2021-11-22 11:53:45 -08:00
AAfghahi
8a24374f9f fix(AlertReportModal): Text Area Change (#17176) 
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention

(cherry picked from commit 5948a9fd02)
 2021-11-22 11:31:20 -08:00
Kamil Gabryjelski
33826cd50f fix(explore): Metrics disappearing after removing metric from dataset (#17201) 
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls

(cherry picked from commit fa44325a36)
 2021-11-22 11:31:20 -08:00
Ville Brofeldt
c4b57e6b3e ci: fix broken test skips (#17005) 
(cherry picked from commit 9e980b6f2b)
 2021-11-22 11:31:20 -08:00
Michael S. Molina
7db1caa2ad fix: Unnecessary queries when changing filter values (#16994) 
(cherry picked from commit c471a85170)
 2021-11-22 11:31:20 -08:00
jinghua-qa
687676cb09 fix: letter format of sort chart in dashboard edit (#17003) 
(cherry picked from commit 6dc00b3e3f)
 2021-11-22 11:31:20 -08:00
serenajiang
2eaf5c854e fix(sqllab): SqlJsonExecutionContext.query null pointer (#16997) 
(cherry picked from commit cde4cdcd0c)
 2021-11-22 11:31:20 -08:00
Lyndsi Kay Williams
09b853c831 fix: FilterableTable result div width (#16912) 
* FilterableTable result div width is now inherit

* Changed style to css

(cherry picked from commit 90cfa7fb22)
 2021-11-22 11:31:20 -08:00
Erik Ritter
5f34ae2cf3 fix: Use production build config for cypress tests (#16978) 
* fix: Use production build config for cypress tests

* set usedExports to global

(cherry picked from commit 2757b93fea)
 2021-11-22 11:31:20 -08:00
Geido
ea3d51efec fix: Color consistency (#17089) 
* Update label colors on the fly

* Clean up

* Improve getFormDataWithExtraFilters

* Improve code structure

* Remove labelColors from formData

* Exclude label_colors from URL

* Refactor color scheme implementation

* Clean up

* Refactor and simplify

* Fix lint

* Remove unnecessary ColorMapControl

* Lint

* Give json color scheme precedence

* Add label_colors prop in metadata

* Separate owners and dashboard meta requests

* Remove label_colors control

* bump superset-ui 0.18.19

* Fix end of file

* Update tests

* Fix lint

* Update Cypress

* Update setColorScheme method

* Use Antd modal body
 2021-11-22 10:55:21 -08:00
Phillip Kelley-Dotson
55b3da661e fix: show onhover menu only in edit mode (#17034) 
* fix on markdown hover menu

* lint-fix
 2021-11-22 10:49:04 -08:00
Geido
b775193f9f fix: Verify when null value should be undefined in Select (#17013) 
* Check for null value

* Safety chek SelectControl and SelectAsyncControl
 2021-11-22 10:46:23 -08:00
Geido
7c966c52dc chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609) 
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
 2021-11-22 10:46:07 -08:00
CodeingBoy
6da69a821f fix(sqllab): Bugfix for tracking url transformation (#17263) 
* Bugfix for tracking url transformation

* Fix linting

(cherry picked from commit 2544a4a8ac)
 2021-11-17 13:09:20 -08:00
Christian Pfarr
03481fe28d feat: Drill ODBC/JDBC Impersonation feature (#17353) 
* Added Drill ODBC Impersonation feature and necessary translations/docs

* Code Cleanup

* add jdbc impersonation_target parameter

* add unittests for DrillEngineSpec.modify_url_for_impersonation method

* reformat test_drill.py with black formatter

* run pre-commit locally

Co-authored-by: Christian Pfarr <Christian.Pfarr@deutschebahn.com>
Co-authored-by: Christian Pfarr <z0ltrix+gitlab@pm.me>
(cherry picked from commit 333b1371f7)
 2021-11-17 13:09:19 -08:00
Étienne Boisseau-Sierra
f467a7ca57 fix(cli): fail CLI script on failed import/export (#16976) 
* Test that failing export or import is done properly

For each CLI entry-point we will modify, we make sure that:

- a failing process exits with a non-0 exit code,
- an error is logged.

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* Exit process with error if export/import failed

Bubble exception up when failing import or export

During a CLI import or export of dashboards, if the process fails, the
exception it caught and a simple message is sent to the logger.
This makes that from a shell point of view, the script was successfull —
cf. #16956.

To prevent this, we want to ensure that the process exits with an error
(i.e., a non-0 exit-code) should the export or import fail mid-flight.

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>
(cherry picked from commit f0c0ef7048)
 2021-11-17 13:09:18 -08:00
simcha90
35d8a40634 fix(native-filters): Fix update ownState (#17181) 
* fix:fix get permission function

* fix: fix own state update

* refactor: fix CR notes

(cherry picked from commit cf284ba3c7)
 2021-11-17 13:09:18 -08:00
Geido
5d43a5926c chore(Dashboard): Disable save button in Native Filters when an error is present (#17037) 
* Disable save on error

* Remove removed erroredFilter

* Fix cdisabled check
 2021-10-27 14:09:07 -07:00
Geido
52ac5ecdbb chore(Dashboard): Highlight errored filters on the left pane of the Native Filters form plus several enhancements (#16940) 
* Implement errored filters

* Clean up

* Handle errors on the fly

* Implement handleErroredFilters

* Reset errors

(cherry picked from commit a6173f1929)
 2021-10-27 14:07:23 -07:00
Erik Ritter
e80c8ea980 fix: error alert levels again (#17027) 2021-10-27 13:57:42 -07:00
Erik Ritter
43019a1b9d fix: error alerts again (#17026) 2021-10-27 13:50:41 -07:00
Erik Ritter
3f869aded2 fix: error alerts js crash (#17015) 2021-10-27 13:49:30 -07:00
Michael S. Molina
f3bde45e5c fix: Filtering db names while creating dataset is not working (#17023) 2021-10-27 13:46:30 -07:00
Hugh A. Miles II
cf4e129f5d use typing_extension instead (#17174) 
(cherry picked from commit aa0f4d6c4f)
 2021-10-27 13:38:55 -07:00
Geido
23313fdb1f fix(Explore): Undefined owners (#17167) 
* Reconcile owners data

* Fix on save

(cherry picked from commit f580f6bcba)
 2021-10-27 13:38:55 -07:00
Ville Brofeldt
d90bfa65ef fix(filter-indicator): show filters handled by jinja as applied (#17140) 
(cherry picked from commit d7834f17e3)
 2021-10-27 13:38:54 -07:00
simcha90
4e3fa1a141 feat: Custom filters control (#17006) 
* fix:fix get permission function

* feat: customize filter control

* fix: fix types

* fix: fix merge

* refactor: update according CR

* refactor: fix CR notes

(cherry picked from commit eebc953dd5)
 2021-10-27 13:38:54 -07:00
Ville Brofeldt
35dda573cf fix: escape bind-like strings in virtual table query (#17111) 
(cherry picked from commit 434b5767c9)
 2021-10-27 13:38:54 -07:00
Daniel Vaz Gaspar
5bfa6e96cd fix: Bump FAB to 3.3.4 (#17113) 
(cherry picked from commit d944503873)
 2021-10-27 13:38:54 -07:00
Kamil Gabryjelski
81da0fb466 fix(dashboard): race condition between hydrating dashboard and set active tabs (#17084) 
* fix(dashboard): race condition between hydrating dashboard and set active tabs

* Fix linting

* Change variable name

(cherry picked from commit 3ad7483dc1)
 2021-10-27 13:38:54 -07:00
Hugh A. Miles II
c03771dc6d fix: Owners selection in dataset edit UX (#17063) 
* boilerplate

* update owner select component

* this is working

* update onchange

* refactorig

* you need to useMemo or things break

* update test

* prettier

* move logic into bootstrap data endpoint

* address concerns

* oops

* oops

* fix test

(cherry picked from commit 959fd763a8)
 2021-10-27 13:38:54 -07:00
Elizabeth Thompson
ed98027adc add logging on successful data uploads (#17065) 
(cherry picked from commit c2e1ab6550)
 2021-10-27 13:38:54 -07:00
Beto Dealmeida
43e27b1137 fix: clear modal state after adding dataset (#17044) 
* fix: clear modal state after adding dataset

* Fix test

* Small fixes

(cherry picked from commit 16a1df75fc)
 2021-10-27 13:38:53 -07:00
Michael S. Molina
bd5d787257 fix: Loading indicator of table and schema selectors (#17040) 
(cherry picked from commit 7c1c89c94b)
 2021-10-27 13:38:53 -07:00
AAfghahi
f56a3d8b1a bug fix (#17019) 
(cherry picked from commit e32a12fa0b)
 2021-10-27 13:38:53 -07:00
Kamil Gabryjelski
3d77daaf68 fix(dashboard): Race condition when setting activeTabs with nested tabs (#17007) 
* fix(dashboard): Race condition when setting activeTabs with nested tabs

* Remove activeTabs prop from Tabs

(cherry picked from commit 45908ff104)
 2021-10-27 13:38:52 -07:00
Yongjie Zhao
19d2fef490 fix: rolling and cum operator on multiple series (#16945) 
* fix: rolling and cum operator on multiple series

* add UT

* updates

(cherry picked from commit fd8461406d)
 2021-10-27 13:38:52 -07:00
Hugh A. Miles II
4d33f7b7b6 fix: check if owners are actually being updated in PUT /datasets/<id> (#16941) 
* check if owners are actually being updated

* move logic to FE

* fix

* fix

(cherry picked from commit 40861b3db3)
 2021-10-27 13:38:52 -07:00
Beto Dealmeida
ddb35a3633 fix(BigQuery): explicitly quote columns in select_star (#16822) 
* fix (BigQuery): explicitly quote columns in select_star

* Fix test

* Fix SELECT * in BQ

* Add unit tests

* Remove type changes

(cherry picked from commit c993c5845f)
 2021-10-27 13:38:52 -07:00
Michael S. Molina
8755911765 chore: Translates the favorite filter param (#16990) 
(cherry picked from commit 191033cb44)
 2021-10-27 13:38:52 -07:00
Michael S. Molina
012f6ac206 fix: When click on "View all" from favorite tab, get error (#16988) 
(cherry picked from commit c57719128f)
 2021-10-27 13:38:51 -07:00