chore: resolve lingering CI issues after upgrading Node to v24

feat(build): update Node version constraint in superset-websocket
feat(build): update Node version in Dockerfiles to v24
2026-06-10 01:59:17 +00:00 · 2026-06-07 15:18:53 +07:00 · 2026-06-07 14:18:03 +07:00 · 2026-06-07 14:15:35 +07:00 · 2026-06-07 13:44:27 +07:00
14 changed files with 484 additions and 679 deletions
--- a/.github/workflows/pre-commit.yml
+++ b/.github/workflows/pre-commit.yml
@@ -48,9 +48,9 @@ jobs:
      - name: Setup Node.js
        uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
        with:
-          node-version: '20'
-          cache: 'npm'
-          cache-dependency-path: 'superset-frontend/package-lock.json'
+          node-version-file: "superset-frontend/.nvmrc"
+          cache: "npm"
+          cache-dependency-path: "superset-frontend/package-lock.json"

      - name: Install Frontend Dependencies
        run: |
@@ -74,7 +74,7 @@ jobs:
        id: changed_files
        uses: ./.github/actions/file-changes-action
        with:
-          output: ' '
+          output: " "

      - name: pre-commit
        env:
--- a/2
+++ b/2
@@ -29,7 +29,7 @@ ARG BUILD_TRANSLATIONS="false"
 ######################################################################
 # superset-node-ci used as a base for building frontend assets and CI
 ######################################################################
-FROM --platform=${BUILDPLATFORM} node:22-trixie-slim AS superset-node-ci
+FROM --platform=${BUILDPLATFORM} node:24-trixie-slim AS superset-node-ci
 ARG BUILD_TRANSLATIONS
 ENV BUILD_TRANSLATIONS=${BUILD_TRANSLATIONS}
 ARG DEV_MODE="false"           # Skip frontend build in dev mode
--- a/docs/.nvmrc
+++ b/docs/.nvmrc
@@ -1 +1 @@
-v22.22.0
+v24.16.0
--- a/superset-embedded-sdk/.nvmrc
+++ b/superset-embedded-sdk/.nvmrc
@@ -1 +1 @@
-v22.22.0
+v24.16.0
--- a/superset-frontend/.nvmrc
+++ b/superset-frontend/.nvmrc
@@ -1 +1 @@
-v22.22.0
+v24.16.0
--- a/superset-frontend/cypress-base/package-lock.json
+++ b/superset-frontend/cypress-base/package-lock.json
@@ -2058,6 +2058,24 @@
        "node": ">=8"
      }
    },
+    "node_modules/@istanbuljs/load-nyc-config/node_modules/argparse": {
+      "version": "2.0.1",
+      "resolved": "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz",
+      "integrity": "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q==",
+      "license": "Python-2.0"
+    },
+    "node_modules/@istanbuljs/load-nyc-config/node_modules/js-yaml": {
+      "version": "4.1.1",
+      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.1.tgz",
+      "integrity": "sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA==",
+      "license": "MIT",
+      "dependencies": {
+        "argparse": "^2.0.1"
+      },
+      "bin": {
+        "js-yaml": "bin/js-yaml.js"
+      }
+    },
    "node_modules/@istanbuljs/schema": {
      "version": "0.1.2",
      "resolved": "https://registry.npmjs.org/@istanbuljs/schema/-/schema-0.1.2.tgz",
@@ -2934,6 +2952,8 @@
      "version": "1.0.10",
      "resolved": "https://registry.npmjs.org/argparse/-/argparse-1.0.10.tgz",
      "integrity": "sha512-o5Roy6tNG4SL/FOkCAN6RzjiakZS25RLYFrcMttJqbdd8BWrnA+fGz57iN5Pb06pvBGvl5gQ0B48dJlslXvoTg==",
+      "dev": true,
+      "peer": true,
      "dependencies": {
        "sprintf-js": "~1.0.2"
      }
@@ -4353,6 +4373,8 @@
      "version": "4.0.1",
      "resolved": "https://registry.npmjs.org/esprima/-/esprima-4.0.1.tgz",
      "integrity": "sha512-eGuFFw7Upda+g4p+QHvnW0RyTX/SVeJBDM/gCtMARO0cLuT2HcEKnTPvhjV6aGeqrCB/sbNop0Kszm0jsaWU4A==",
+      "dev": true,
+      "peer": true,
      "bin": {
        "esparse": "bin/esparse.js",
        "esvalidate": "bin/esvalidate.js"
@@ -5594,7 +5616,9 @@
      "version": "3.14.2",
      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-3.14.2.tgz",
      "integrity": "sha512-PMSmkqxr106Xa156c2M265Z+FTrPl+oxd/rgOQy2tijQeK5TxQ43psO1ZCwhVOSdnn+RzkzlRz/eY4BgJBYVpg==",
+      "dev": true,
      "license": "MIT",
+      "peer": true,
      "dependencies": {
        "argparse": "^1.0.7",
        "esprima": "^4.0.0"
@@ -7756,7 +7780,9 @@
    "node_modules/sprintf-js": {
      "version": "1.0.3",
      "resolved": "https://registry.npmjs.org/sprintf-js/-/sprintf-js-1.0.3.tgz",
-      "integrity": "sha1-BOaSb2YolTVPPdAVIDYzuFcpfiw="
+      "integrity": "sha1-BOaSb2YolTVPPdAVIDYzuFcpfiw=",
+      "dev": true,
+      "peer": true
    },
    "node_modules/sshpk": {
      "version": "1.18.0",
@@ -10202,8 +10228,23 @@
        "camelcase": "^5.3.1",
        "find-up": "^4.1.0",
        "get-package-type": "^0.1.0",
-        "js-yaml": "^3.13.1",
+        "js-yaml": "4.1.1",
        "resolve-from": "^5.0.0"
+      },
+      "dependencies": {
+        "argparse": {
+          "version": "2.0.1",
+          "resolved": "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz",
+          "integrity": "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q=="
+        },
+        "js-yaml": {
+          "version": "4.1.1",
+          "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.1.tgz",
+          "integrity": "sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA==",
+          "requires": {
+            "argparse": "^2.0.1"
+          }
+        }
      }
    },
    "@istanbuljs/schema": {
@@ -11006,6 +11047,8 @@
      "version": "1.0.10",
      "resolved": "https://registry.npmjs.org/argparse/-/argparse-1.0.10.tgz",
      "integrity": "sha512-o5Roy6tNG4SL/FOkCAN6RzjiakZS25RLYFrcMttJqbdd8BWrnA+fGz57iN5Pb06pvBGvl5gQ0B48dJlslXvoTg==",
+      "dev": true,
+      "peer": true,
      "requires": {
        "sprintf-js": "~1.0.2"
      }
@@ -12051,7 +12094,9 @@
    "esprima": {
      "version": "4.0.1",
      "resolved": "https://registry.npmjs.org/esprima/-/esprima-4.0.1.tgz",
-      "integrity": "sha512-eGuFFw7Upda+g4p+QHvnW0RyTX/SVeJBDM/gCtMARO0cLuT2HcEKnTPvhjV6aGeqrCB/sbNop0Kszm0jsaWU4A=="
+      "integrity": "sha512-eGuFFw7Upda+g4p+QHvnW0RyTX/SVeJBDM/gCtMARO0cLuT2HcEKnTPvhjV6aGeqrCB/sbNop0Kszm0jsaWU4A==",
+      "dev": true,
+      "peer": true
    },
    "esquery": {
      "version": "1.4.0",
@@ -12953,6 +12998,8 @@
      "version": "3.14.2",
      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-3.14.2.tgz",
      "integrity": "sha512-PMSmkqxr106Xa156c2M265Z+FTrPl+oxd/rgOQy2tijQeK5TxQ43psO1ZCwhVOSdnn+RzkzlRz/eY4BgJBYVpg==",
+      "dev": true,
+      "peer": true,
      "requires": {
        "argparse": "^1.0.7",
        "esprima": "^4.0.0"
@@ -14463,7 +14510,9 @@
    "sprintf-js": {
      "version": "1.0.3",
      "resolved": "https://registry.npmjs.org/sprintf-js/-/sprintf-js-1.0.3.tgz",
-      "integrity": "sha1-BOaSb2YolTVPPdAVIDYzuFcpfiw="
+      "integrity": "sha1-BOaSb2YolTVPPdAVIDYzuFcpfiw=",
+      "dev": true,
+      "peer": true
    },
    "sshpk": {
      "version": "1.18.0",
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -391,8 +391,8 @@
    "regenerator-runtime": "^0.14.1"
  },
  "engines": {
-    "node": "^22.22.0",
-    "npm": "^10.8.1"
+    "node": "^24.16.0",
+    "npm": "^11.13.0"
  },
  "overrides": {
    "uuid": "$uuid",
--- a/superset-frontend/packages/superset-ui-core/test/number-format/factories/createDurationFormatter.test.ts
+++ b/superset-frontend/packages/superset-ui-core/test/number-format/factories/createDurationFormatter.test.ts
@@ -35,7 +35,7 @@ test('format milliseconds in human readable format with default options', () =>
 });
 test('format seconds in human readable format with default options', () => {
  const formatter = createDurationFormatter({ multiplier: 1000 });
-  expect(formatter(-0.5)).toBe('-0s');
+  expect(formatter(-0.5)).toBe('0s');
  expect(formatter(0.5)).toBe('0s');
  expect(formatter(1)).toBe('1s');
  expect(formatter(30)).toBe('30s');
--- a/superset-websocket/.nvmrc
+++ b/superset-websocket/.nvmrc
@@ -1 +1 @@
-v22.22.0
+v24.16.0
--- a/superset-websocket/Dockerfile
+++ b/superset-websocket/Dockerfile
@@ -12,7 +12,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-FROM node:22-alpine AS build
+FROM node:24-alpine AS build

 WORKDIR /home/superset-websocket

@@ -22,7 +22,7 @@ RUN npm ci && \
  npm run build


-FROM node:22-alpine
+FROM node:24-alpine

 ENV NODE_ENV=production
 WORKDIR /home/superset-websocket
--- a/superset-websocket/package-lock.json
+++ b/superset-websocket/package-lock.json
@@ -40,8 +40,8 @@
        "typescript-eslint": "^8.60.0"
      },
      "engines": {
-        "node": "^22.22.0",
-        "npm": "^10.8.2"
+        "node": "^24.16.0",
+        "npm": "^11.13.0"
      }
    },
    "node_modules/@aashutoshrathi/word-wrap": {
--- a/superset-websocket/package.json
+++ b/superset-websocket/package.json
@@ -48,7 +48,7 @@
    "typescript-eslint": "^8.60.0"
  },
  "engines": {
-    "node": "^22.22.0",
-    "npm": "^10.8.2"
+    "node": "^24.16.0",
+    "npm": "^11.13.0"
  }
 }
--- a/superset-websocket/utils/client-ws-app/.nvmrc
+++ b/superset-websocket/utils/client-ws-app/.nvmrc
@@ -1 +1 @@
-v22.22.0
+v24.16.0
Author	SHA1	Message	Date
hainenber	c7ba8c3310	chore: resolve lingering CI issues after upgrading Node to v24	2026-06-07 15:18:53 +07:00
hainenber	134fba3022	feat(build): update Node version constraint in `superset-websocket`	2026-06-07 14:18:03 +07:00
hainenber	9073a6d3c1	feat(build): update Node version in Dockerfiles to v24	2026-06-07 14:15:35 +07:00
hainenber	bf9e2fb5ff	feat(build): update Node version to v24	2026-06-07 13:44:27 +07:00