Merge remote-tracking branch 'origin/master' into msyavuz/chore/react-18.3-bump

chore(deps): sync package-lock for d3-cloud ^1.2.9
2026-06-10 18:19:28 +00:00 · 2026-06-08 22:45:39 +03:00 · 2026-06-01 23:22:51 +03:00 · 2026-06-01 21:35:36 +03:00 · 2026-05-29 18:23:55 +03:00 · 2026-05-29 18:23:48 +03:00
60 changed files with 515 additions and 406 deletions
--- a/superset-frontend/babel.config.js
+++ b/superset-frontend/babel.config.js
@@ -106,7 +106,13 @@ module.exports = {
        [
          'babel-plugin-jsx-remove-data-test-id',
          {
-            attributes: 'data-test',
+            // The plugin matches attribute names exactly (no prefix match),
+            // so each data-test* attribute must be listed explicitly.
+            attributes: [
+              'data-test',
+              'data-test-drag-source-id',
+              'data-test-drop-target-id',
+            ],
          },
        ],
      ],
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
@@ -120,13 +120,13 @@
        "ol": "^10.9.0",
        "query-string": "9.4.0",
        "re-resizable": "^6.11.2",
-        "react": "^18.2.0",
+        "react": "^18.3.0",
        "react-arborist": "^3.8.0",
        "react-checkbox-tree": "^1.8.0",
        "react-diff-viewer-continued": "^4.2.2",
        "react-dnd": "^11.1.3",
        "react-dnd-html5-backend": "^11.1.3",
-        "react-dom": "^18.2.0",
+        "react-dom": "^18.3.0",
        "react-google-recaptcha": "^3.1.0",
        "react-intersection-observer": "^10.0.3",
        "react-json-tree": "^0.20.0",
@@ -210,8 +210,8 @@
        "@types/json-bigint": "^1.0.4",
        "@types/mousetrap": "^1.6.15",
        "@types/node": "^25.9.1",
-        "@types/react": "^18.2.0",
-        "@types/react-dom": "^18.2.0",
+        "@types/react": "^18.3.0",
+        "@types/react-dom": "^18.3.0",
        "@types/react-loadable": "^5.5.11",
        "@types/react-redux": "^7.1.10",
        "@types/react-resizable": "^4.0.0",
@@ -275,6 +275,7 @@
        "prettier": "3.8.3",
        "prettier-plugin-packagejson": "^3.0.2",
        "process": "^0.11.10",
+        "react-dnd-test-backend": "^11.1.3",
        "react-refresh": "^0.18.0",
        "react-resizable": "^4.0.1",
        "redux-mock-store": "^1.5.4",
@@ -40478,6 +40479,16 @@
        "dnd-core": "^11.1.3"
      }
    },
+    "node_modules/react-dnd-test-backend": {
+      "version": "11.1.3",
+      "resolved": "https://registry.npmjs.org/react-dnd-test-backend/-/react-dnd-test-backend-11.1.3.tgz",
+      "integrity": "sha512-5qFm+NI2GdWIUfiYun0A8Gv0xjbq0NGOPS+f6z3x/3nTuliApjmqcM1lfTgePoz1FDG47ZofF58N8y96If62+Q==",
+      "dev": true,
+      "license": "MIT",
+      "dependencies": {
+        "dnd-core": "^11.1.3"
+      }
+    },
    "node_modules/react-docgen": {
      "version": "7.1.1",
      "resolved": "https://registry.npmjs.org/react-docgen/-/react-docgen-7.1.1.tgz",
@@ -49284,8 +49295,8 @@
        "jed": "^1.1.1",
        "lodash": "^4.18.1",
        "nanoid": "^5.0.9",
-        "react": "^18.2.0",
-        "react-dom": "^18.2.0",
+        "react": "^18.3.0",
+        "react-dom": "^18.3.0",
        "react-loadable": "^5.5.0",
        "tinycolor2": "*"
      }
@@ -49311,9 +49322,9 @@
        "ace-builds": "^1.4.14",
        "brace": "^0.11.1",
        "memoize-one": "^5.1.1",
-        "react": "^18.2.0",
+        "react": "^18.3.0",
        "react-ace": "^10.1.0",
-        "react-dom": "^18.2.0"
+        "react-dom": "^18.3.0"
      }
    },
    "packages/superset-ui-core": {
@@ -49354,7 +49365,7 @@
        "react-js-cron": "^5.2.0",
        "react-markdown": "^8.0.7",
        "react-resize-detector": "^7.1.2",
-        "react-syntax-highlighter": "^16.1.0",
+        "react-syntax-highlighter": "^16.1.1",
        "react-ultimate-pagination": "^1.3.2",
        "regenerator-runtime": "^0.14.1",
        "rehype-raw": "^7.0.0",
@@ -49398,8 +49409,8 @@
        "@types/tinycolor2": "*",
        "antd": "^5.26.0",
        "nanoid": "^5.0.9",
-        "react": "^18.2.0",
-        "react-dom": "^18.2.0",
+        "react": "^18.3.0",
+        "react-dom": "^18.3.0",
        "react-loadable": "^5.5.0",
        "tinycolor2": "*"
      }
@@ -49579,7 +49590,7 @@
        "@emotion/react": "^11.4.1",
        "@superset-ui/chart-controls": "*",
        "@superset-ui/core": "*",
-        "react": "^18.2.0"
+        "react": "^18.3.0"
      }
    },
    "plugins/legacy-plugin-chart-calendar/node_modules/d3-array": {
@@ -49640,7 +49651,7 @@
        "@apache-superset/core": "*",
        "@superset-ui/chart-controls": "*",
        "@superset-ui/core": "*",
-        "react": "^18.2.0"
+        "react": "^18.3.0"
      }
    },
    "plugins/legacy-plugin-chart-country-map/node_modules/d3-array": {
@@ -49668,7 +49679,7 @@
        "@apache-superset/core": "*",
        "@superset-ui/chart-controls": "*",
        "@superset-ui/core": "*",
-        "react": "^18.2.0"
+        "react": "^18.3.0"
      }
    },
    "plugins/legacy-plugin-chart-horizon/node_modules/d3-array": {
@@ -49702,7 +49713,7 @@
        "@apache-superset/core": "*",
        "@superset-ui/chart-controls": "*",
        "@superset-ui/core": "*",
-        "react": "^18.2.0"
+        "react": "^18.3.0"
      }
    },
    "plugins/legacy-plugin-chart-parallel-coordinates": {
@@ -49717,7 +49728,7 @@
        "@apache-superset/core": "*",
        "@superset-ui/chart-controls": "*",
        "@superset-ui/core": "*",
-        "react": "^18.2.0"
+        "react": "^18.3.0"
      }
    },
    "plugins/legacy-plugin-chart-partition": {
@@ -49735,8 +49746,8 @@
        "@superset-ui/core": "*",
        "@testing-library/jest-dom": "*",
        "@testing-library/react": "^14.0.0",
-        "react": "^18.2.0",
-        "react-dom": "^18.2.0"
+        "react": "^18.3.0",
+        "react-dom": "^18.3.0"
      }
    },
    "plugins/legacy-plugin-chart-rose": {
@@ -49753,7 +49764,7 @@
        "@emotion/react": "^11.4.1",
        "@superset-ui/chart-controls": "*",
        "@superset-ui/core": "*",
-        "react": "^18.2.0"
+        "react": "^18.3.0"
      }
    },
    "plugins/legacy-plugin-chart-world-map": {
@@ -49771,7 +49782,7 @@
        "@apache-superset/core": "*",
        "@superset-ui/chart-controls": "*",
        "@superset-ui/core": "*",
-        "react": "^18.2.0"
+        "react": "^18.3.0"
      }
    },
    "plugins/legacy-plugin-chart-world-map/node_modules/d3-array": {
@@ -49858,7 +49869,7 @@
        "@superset-ui/chart-controls": "*",
        "@superset-ui/core": "*",
        "dayjs": "^1.11.21",
-        "react": "^18.2.0"
+        "react": "^18.3.0"
      }
    },
    "plugins/legacy-preset-chart-nvd3/node_modules/dompurify": {
@@ -49895,8 +49906,8 @@
        "@testing-library/react": "^14.0.0",
        "@testing-library/user-event": "*",
        "@types/react": "*",
-        "react": "^18.2.0",
-        "react-dom": "^18.2.0"
+        "react": "^18.3.0",
+        "react-dom": "^18.3.0"
      }
    },
    "plugins/plugin-chart-ag-grid-table/node_modules/d3-array": {
@@ -49940,8 +49951,8 @@
        "geostyler-wfs-parser": "^3.0.1",
        "ol": "^10.8.0",
        "polished": "*",
-        "react": "^18.2.0",
-        "react-dom": "^18.2.0"
+        "react": "^18.3.0",
+        "react-dom": "^18.3.0"
      }
    },
    "plugins/plugin-chart-echarts": {
@@ -49963,7 +49974,7 @@
        "dayjs": "^1.11.21",
        "echarts": "*",
        "memoize-one": "*",
-        "react": "^18.2.0"
+        "react": "^18.3.0"
      }
    },
    "plugins/plugin-chart-echarts/node_modules/acorn": {
@@ -50021,9 +50032,9 @@
        "dayjs": "^1.11.21",
        "handlebars": "^4.7.8",
        "lodash": "^4.18.1",
-        "react": "^18.2.0",
+        "react": "^18.3.0",
        "react-ace": "^10.1.0",
-        "react-dom": "^18.2.0"
+        "react-dom": "^18.3.0"
      }
    },
    "plugins/plugin-chart-handlebars/node_modules/just-handlebars-helpers": {
@@ -50054,8 +50065,8 @@
        "@superset-ui/core": "*",
        "lodash": "^4.18.1",
        "prop-types": "*",
-        "react": "^18.2.0",
-        "react-dom": "^18.2.0"
+        "react": "^18.3.0",
+        "react-dom": "^18.3.0"
      }
    },
    "plugins/plugin-chart-point-cluster-map": {
@@ -50073,8 +50084,8 @@
        "@apache-superset/core": "*",
        "@superset-ui/chart-controls": "*",
        "@superset-ui/core": "*",
-        "react": "^18.2.0",
-        "react-dom": "^18.2.0"
+        "react": "^18.3.0",
+        "react-dom": "^18.3.0"
      }
    },
    "plugins/plugin-chart-point-cluster-map/node_modules/react-map-gl": {
@@ -50127,8 +50138,8 @@
        "@testing-library/user-event": "*",
        "@types/react": "*",
        "match-sorter": "^8.2.0",
-        "react": "^18.2.0",
-        "react-dom": "^18.2.0"
+        "react": "^18.3.0",
+        "react-dom": "^18.3.0"
      }
    },
    "plugins/plugin-chart-table/node_modules/d3-array": {
@@ -50167,7 +50178,7 @@
        "@superset-ui/core": "*",
        "@types/lodash": "*",
        "@types/react": "*",
-        "react": "^18.2.0"
+        "react": "^18.3.0"
      }
    },
    "plugins/plugin-chart-word-cloud/node_modules/@types/d3-scale": {
@@ -50236,8 +50247,8 @@
        "@superset-ui/core": "*",
        "dayjs": "^1.11.21",
        "mapbox-gl": ">=1.0.0",
-        "react": "^18.2.0",
-        "react-dom": "^18.2.0"
+        "react": "^18.3.0",
+        "react-dom": "^18.3.0"
      },
      "peerDependenciesMeta": {
        "mapbox-gl": {
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -203,13 +203,13 @@
    "ol": "^10.9.0",
    "query-string": "9.4.0",
    "re-resizable": "^6.11.2",
-    "react": "^18.2.0",
+    "react": "^18.3.0",
    "react-arborist": "^3.8.0",
    "react-checkbox-tree": "^1.8.0",
    "react-diff-viewer-continued": "^4.2.2",
    "react-dnd": "^11.1.3",
    "react-dnd-html5-backend": "^11.1.3",
-    "react-dom": "^18.2.0",
+    "react-dom": "^18.3.0",
    "react-google-recaptcha": "^3.1.0",
    "react-intersection-observer": "^10.0.3",
    "react-json-tree": "^0.20.0",
@@ -293,8 +293,8 @@
    "@types/json-bigint": "^1.0.4",
    "@types/mousetrap": "^1.6.15",
    "@types/node": "^25.9.1",
-    "@types/react": "^18.2.0",
-    "@types/react-dom": "^18.2.0",
+    "@types/react": "^18.3.0",
+    "@types/react-dom": "^18.3.0",
    "@types/react-loadable": "^5.5.11",
    "@types/react-redux": "^7.1.10",
    "@types/react-resizable": "^4.0.0",
@@ -358,6 +358,7 @@
    "prettier": "3.8.3",
    "prettier-plugin-packagejson": "^3.0.2",
    "process": "^0.11.10",
+    "react-dnd-test-backend": "^11.1.3",
    "react-refresh": "^0.18.0",
    "react-resizable": "^4.0.1",
    "redux-mock-store": "^1.5.4",
--- a/superset-frontend/packages/superset-core/package.json
+++ b/superset-frontend/packages/superset-core/package.json
@@ -97,8 +97,8 @@
    "@fontsource/ibm-plex-mono": "^5.2.7",
    "@fontsource/inter": "^5.2.6",
    "nanoid": "^5.0.9",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0",
+    "react": "^18.3.0",
+    "react-dom": "^18.3.0",
    "react-loadable": "^5.5.0",
    "tinycolor2": "*",
    "lodash": "^4.18.1",
--- a/superset-frontend/packages/superset-core/src/utils/logging.test.ts
+++ b/superset-frontend/packages/superset-core/src/utils/logging.test.ts
@@ -16,13 +16,26 @@
 * specific language governing permissions and limitations
 * under the License.
 */
+export {}; // ensure this file is treated as a module so top-level declarations don't leak into global scope
+
+type LoggingModule = typeof import('./index');
+
+const loadLogging = (): LoggingModule['logging'] => {
+  let logging: LoggingModule['logging'] | undefined;
+  jest.isolateModules(() => {
+    ({ logging } = jest.requireActual<LoggingModule>(
+      '@apache-superset/core/utils',
+    ));
+  });
+  return logging!;
+};
+
 beforeEach(() => {
-  jest.resetModules();
  jest.resetAllMocks();
 });

 test('should pipe to `console` methods', () => {
-  const { logging } = require('@apache-superset/core/utils');
+  const logging = loadLogging();

  jest.spyOn(logging, 'debug').mockImplementation();
  jest.spyOn(logging, 'log').mockImplementation();
@@ -50,20 +63,24 @@ test('should pipe to `console` methods', () => {
 });

 test('should use noop functions when console unavailable', () => {
+  const originalConsole = window.console;
  Object.assign(window, { console: undefined });
-  const { logging } = require('@apache-superset/core/utils');
+  try {
+    const logging = loadLogging();

-  expect(() => {
-    logging.debug();
-    logging.log();
-    logging.info();
-    logging.warn('warn');
-    logging.error('error');
-    logging.trace();
-    logging.table([
-      [1, 2],
-      [3, 4],
-    ]);
-  }).not.toThrow();
-  Object.assign(window, { console });
+    expect(() => {
+      logging.debug();
+      logging.log();
+      logging.info();
+      logging.warn('warn');
+      logging.error('error');
+      logging.trace();
+      logging.table([
+        [1, 2],
+        [3, 4],
+      ]);
+    }).not.toThrow();
+  } finally {
+    Object.assign(window, { console: originalConsole });
+  }
 });
--- a/superset-frontend/packages/superset-ui-chart-controls/package.json
+++ b/superset-frontend/packages/superset-ui-chart-controls/package.json
@@ -40,9 +40,9 @@
    "ace-builds": "^1.4.14",
    "brace": "^0.11.1",
    "memoize-one": "^5.1.1",
-    "react": "^18.2.0",
+    "react": "^18.3.0",
    "react-ace": "^10.1.0",
-    "react-dom": "^18.2.0"
+    "react-dom": "^18.3.0"
  },
  "publishConfig": {
    "access": "public"
--- a/superset-frontend/packages/superset-ui-core/package.json
+++ b/superset-frontend/packages/superset-ui-core/package.json
@@ -101,8 +101,8 @@
    "@types/tinycolor2": "*",
    "antd": "^5.26.0",
    "nanoid": "^5.0.9",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0",
+    "react": "^18.3.0",
+    "react-dom": "^18.3.0",
    "react-loadable": "^5.5.0",
    "tinycolor2": "*"
  },
--- a/superset-frontend/packages/superset-ui-core/src/components/Avatar/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Avatar/index.tsx
@@ -17,15 +17,23 @@
 * under the License.
 */

+import { forwardRef } from 'react';
 import { Avatar as AntdAvatar } from 'antd';
 import type { AvatarProps, GroupProps as AvatarGroupProps } from './types';

-export function Avatar(props: AvatarProps) {
-  return <AntdAvatar {...props} />;
-}
+export const Avatar = forwardRef<HTMLSpanElement, AvatarProps>((props, ref) => (
+  <AntdAvatar ref={ref} {...props} />
+));

-export function AvatarGroup(props: AvatarGroupProps) {
-  return <AntdAvatar.Group {...props} />;
-}
+// antd Avatar.Group is a plain function component without forwardRef; wrap in
+// a span so this component can be a Tooltip / Popover trigger and skip the
+// findDOMNode fallback.
+export const AvatarGroup = forwardRef<HTMLSpanElement, AvatarGroupProps>(
+  (props, ref) => (
+    <span ref={ref}>
+      <AntdAvatar.Group {...props} />
+    </span>
+  ),
+);

 export type { AvatarProps, AvatarGroupProps };
--- a/superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx
@@ -16,7 +16,7 @@
 * specific language governing permissions and limitations
 * under the License.
 */
-import { Children, ReactElement, Fragment } from 'react';
+import { Children, ReactElement, Fragment, forwardRef, Ref } from 'react';
 import cx from 'classnames';
 import { Button as AntdButton } from 'antd';
 import { useTheme } from '@apache-superset/core/theme';
@@ -100,7 +100,7 @@ const BUTTON_STYLE_MAP: Record<
  link: { type: 'link' },
 };

-export function Button(props: ButtonProps) {
+function ButtonInner(props: ButtonProps, ref: Ref<HTMLElement>) {
  const {
    tooltip,
    placement,
@@ -160,6 +160,7 @@ export function Button(props: ButtonProps) {

  const button = (
    <AntdButton
+      ref={ref as Ref<HTMLButtonElement & HTMLAnchorElement>}
      href={disabled ? undefined : href}
      disabled={disabled}
      type={antdType}
@@ -235,4 +236,6 @@ export function Button(props: ButtonProps) {
  return button;
 }

+export const Button = forwardRef<HTMLElement, ButtonProps>(ButtonInner);
+
 export type { ButtonProps, OnClickHandler };
--- a/superset-frontend/packages/superset-ui-core/src/components/DropdownButton/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/DropdownButton/index.tsx
@@ -75,7 +75,10 @@ export const DropdownButton = ({
        id={`${kebabCase(tooltip)}-tooltip`}
        title={tooltip}
      >
-        {button}
+        {/* antd Dropdown.Button is a plain function component without
+            forwardRef; wrap in a span so the Tooltip can attach a ref to a
+            real DOM node and skip the findDOMNode fallback. */}
+        <span>{button}</span>
      </Tooltip>
    );
  }
--- a/superset-frontend/packages/superset-ui-core/src/components/EditableTitle/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/EditableTitle/index.tsx
@@ -240,7 +240,10 @@ export function EditableTitle({
              t("You don't have the rights to alter this title.")
        }
      >
-        {titleComponent}
+        {/* Wrap in span so the Tooltip can attach a ref to a DOM element.
+            antd's Input.TextArea forwards a non-DOM imperative handle, which
+            triggers a React 18 findDOMNode deprecation warning. */}
+        <span>{titleComponent}</span>
      </Tooltip>
    );
  }
--- a/superset-frontend/packages/superset-ui-core/src/components/IconTooltip/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/IconTooltip/index.tsx
@@ -16,47 +16,54 @@
 * specific language governing permissions and limitations
 * under the License.
 */
+import { forwardRef } from 'react';
 import { Tooltip } from '../Tooltip';
 import { Button } from '../Button';
 import type { IconTooltipProps } from './types';

-export const IconTooltip = ({
-  children = null,
-  className = '',
-  onClick = () => undefined,
-  placement = 'top',
-  style = {},
-  tooltip = null,
-  mouseEnterDelay = 0.3,
-  mouseLeaveDelay = 0.15,
-}: IconTooltipProps) => {
-  const iconTooltip = (
-    <Button
-      onClick={onClick}
-      style={{
-        padding: 0,
-        ...style,
-      }}
-      buttonStyle="link"
-      className={`IconTooltip ${className}`}
-    >
-      {children}
-    </Button>
-  );
-  if (tooltip) {
-    return (
-      <Tooltip
-        id="tooltip"
-        title={tooltip}
-        placement={placement}
-        mouseEnterDelay={mouseEnterDelay}
-        mouseLeaveDelay={mouseLeaveDelay}
+export const IconTooltip = forwardRef<HTMLElement, IconTooltipProps>(
+  (
+    {
+      children = null,
+      className = '',
+      onClick = () => undefined,
+      placement = 'top',
+      style = {},
+      tooltip = null,
+      mouseEnterDelay = 0.3,
+      mouseLeaveDelay = 0.15,
+    },
+    ref,
+  ) => {
+    const iconTooltip = (
+      <Button
+        ref={ref}
+        onClick={onClick}
+        style={{
+          padding: 0,
+          ...style,
+        }}
+        buttonStyle="link"
+        className={`IconTooltip ${className}`}
      >
-        {iconTooltip}
-      </Tooltip>
+        {children}
+      </Button>
    );
-  }
-  return iconTooltip;
-};
+    if (tooltip) {
+      return (
+        <Tooltip
+          id="tooltip"
+          title={tooltip}
+          placement={placement}
+          mouseEnterDelay={mouseEnterDelay}
+          mouseLeaveDelay={mouseLeaveDelay}
+        >
+          {iconTooltip}
+        </Tooltip>
+      );
+    }
+    return iconTooltip;
+  },
+);

 export type { IconTooltipProps };
--- a/superset-frontend/packages/superset-ui-core/src/components/Icons/AntdEnhanced.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Icons/AntdEnhanced.tsx
@@ -165,7 +165,7 @@ import {
  SlackOutlined,
  ApiOutlined,
 } from '@ant-design/icons';
-import { FC } from 'react';
+import { ForwardRefExoticComponent, RefAttributes, forwardRef } from 'react';
 import { IconType } from './types';
 import { BaseIconComponent } from './BaseIcon';

@@ -323,19 +323,25 @@ type AntdIconNames = keyof typeof AntdIcons;

 export const antdEnhancedIcons: Record<
  AntdIconNames,
-  FC<IconType>
+  ForwardRefExoticComponent<IconType & RefAttributes<HTMLSpanElement>>
 > = Object.keys(AntdIcons)
  .filter(key => !EXCLUDED_ICONS.some(excluded => key.includes(excluded)))
  .reduce(
    (acc, key) => {
-      acc[key as AntdIconNames] = (props: IconType) => (
-        <BaseIconComponent
-          component={AntdIcons[key as AntdIconNames]}
-          fileName={key}
-          {...props}
-        />
+      acc[key as AntdIconNames] = forwardRef<HTMLSpanElement, IconType>(
+        (props, ref) => (
+          <BaseIconComponent
+            ref={ref}
+            component={AntdIcons[key as AntdIconNames]}
+            fileName={key}
+            {...props}
+          />
+        ),
      );
      return acc;
    },
-    {} as Record<AntdIconNames, FC<IconType>>,
+    {} as Record<
+      AntdIconNames,
+      ForwardRefExoticComponent<IconType & RefAttributes<HTMLSpanElement>>
+    >,
  );
--- a/superset-frontend/packages/superset-ui-core/src/components/Icons/AsyncIcon.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Icons/AsyncIcon.tsx
@@ -17,12 +17,12 @@
 * under the License.
 */

-import { FC, SVGProps, useEffect, useRef, useState } from 'react';
+import { FC, SVGProps, forwardRef, useEffect, useRef, useState } from 'react';
 import TransparentIcon from './svgs/transparent.svg';
 import { IconType } from './types';
 import { BaseIconComponent } from './BaseIcon';

-const AsyncIcon = (props: IconType) => {
+const AsyncIcon = forwardRef<HTMLSpanElement, IconType>((props, ref) => {
  const [, setLoaded] = useState(false);
  const ImportedSVG = useRef<FC<SVGProps<SVGSVGElement>>>();
  const { fileName, customIcons, iconSize, iconColor, viewBox, ...restProps } =
@@ -46,6 +46,7 @@ const AsyncIcon = (props: IconType) => {

  return (
    <BaseIconComponent
+      ref={ref}
      component={ImportedSVG.current || TransparentIcon}
      fileName={fileName}
      customIcons={customIcons}
@@ -55,6 +56,6 @@ const AsyncIcon = (props: IconType) => {
      {...restProps}
    />
  );
-};
+});

 export default AsyncIcon;
--- a/superset-frontend/packages/superset-ui-core/src/components/Icons/BaseIcon.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Icons/BaseIcon.tsx
@@ -17,6 +17,7 @@
 * under the License.
 */

+import { forwardRef, type ComponentType } from 'react';
 import { css, useTheme, getFontSize } from '@apache-superset/core/theme';
 import { AntdIconType, BaseIconProps, CustomIconType, IconType } from './types';

@@ -35,65 +36,78 @@ const genAriaLabel = (fileName: string) => {
  return name.toLowerCase();
 };

-export const BaseIconComponent: React.FC<
+export const BaseIconComponent = forwardRef<
+  HTMLSpanElement | SVGSVGElement,
  BaseIconProps & Omit<IconType, 'component'>
-> = ({
-  component: Component,
-  iconColor,
-  iconSize,
-  viewBox,
-  customIcons,
-  fileName,
-  ...rest
-}) => {
-  const theme = useTheme();
-  const whatRole = rest?.onClick ? 'button' : 'img';
-  const ariaLabel = genAriaLabel(fileName || '');
-  const style = {
-    color: iconColor,
-    fontSize: iconSize
-      ? `${getFontSize(theme, iconSize)}px`
-      : `${theme.fontSize}px`,
-    cursor: rest?.onClick ? 'pointer' : undefined,
-  };
+>(
+  (
+    {
+      component: Component,
+      iconColor,
+      iconSize,
+      viewBox,
+      customIcons,
+      fileName,
+      ...rest
+    },
+    ref,
+  ) => {
+    const theme = useTheme();
+    const whatRole = rest?.onClick ? 'button' : 'img';
+    const ariaLabel = genAriaLabel(fileName || '');
+    const style = {
+      color: iconColor,
+      fontSize: iconSize
+        ? `${getFontSize(theme, iconSize)}px`
+        : `${theme.fontSize}px`,
+      cursor: rest?.onClick ? 'pointer' : undefined,
+    };

-  return customIcons ? (
-    <span
-      role={whatRole}
-      aria-label={ariaLabel}
-      data-test={ariaLabel}
-      css={[
-        css`
-          display: inline-flex;
-          align-items: center;
-          line-height: 0;
-          vertical-align: middle;
-        `,
-      ]}
-    >
-      <Component
-        viewBox={viewBox || '0 0 24 24'}
+    const AntdComponent = Component as ComponentType<
+      Record<string, unknown> & {
+        ref?: React.Ref<HTMLSpanElement | SVGSVGElement>;
+      }
+    >;
+    return customIcons ? (
+      <span
+        ref={ref as React.Ref<HTMLSpanElement>}
+        role={whatRole}
+        aria-label={ariaLabel}
+        data-test={ariaLabel}
+        css={[
+          css`
+            display: inline-flex;
+            align-items: center;
+            line-height: 0;
+            vertical-align: middle;
+          `,
+        ]}
+      >
+        <Component
+          viewBox={viewBox || '0 0 24 24'}
+          style={style}
+          width={
+            iconSize
+              ? `${getFontSize(theme, iconSize) || theme.fontSize}px`
+              : `${theme.fontSize}px`
+          }
+          height={
+            iconSize
+              ? `${getFontSize(theme, iconSize) || theme.fontSize}px`
+              : `${theme.fontSize}px`
+          }
+          {...(rest as CustomIconType)}
+        />
+      </span>
+    ) : (
+      <AntdComponent
+        ref={ref}
+        role={whatRole}
        style={style}
-        width={
-          iconSize
-            ? `${getFontSize(theme, iconSize) || theme.fontSize}px`
-            : `${theme.fontSize}px`
-        }
-        height={
-          iconSize
-            ? `${getFontSize(theme, iconSize) || theme.fontSize}px`
-            : `${theme.fontSize}px`
-        }
-        {...(rest as CustomIconType)}
+        aria-label={ariaLabel}
+        data-test={ariaLabel}
+        {...(rest as AntdIconType)}
      />
-    </span>
-  ) : (
-    <Component
-      role={whatRole}
-      style={style}
-      aria-label={ariaLabel}
-      data-test={ariaLabel}
-      {...(rest as AntdIconType)}
-    />
-  );
-};
+    );
+  },
+);
--- a/superset-frontend/packages/superset-ui-core/src/components/Icons/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Icons/index.tsx
@@ -17,12 +17,16 @@
 * under the License.
 */

-import { FC } from 'react';
+import { ForwardRefExoticComponent, RefAttributes, forwardRef } from 'react';
 import { antdEnhancedIcons } from './AntdEnhanced';
 import AsyncIcon from './AsyncIcon';

 import type { IconType } from './types';

+type IconComponent = ForwardRefExoticComponent<
+  IconType & RefAttributes<HTMLSpanElement>
+>;
+
 /**
 * Filename is going to be inferred from the icon name.
 * i.e. BigNumberChartTile => assets/images/icons/big_number_chart_tile
@@ -58,15 +62,17 @@ const customIcons = [
  'Undo',
 ] as const;

-type CustomIconType = Record<(typeof customIcons)[number], FC<IconType>>;
+type CustomIconType = Record<(typeof customIcons)[number], IconComponent>;

 const iconOverrides: CustomIconType = {} as CustomIconType;
 customIcons.forEach(customIcon => {
  const fileName = customIcon
    .replace(/([a-z0-9])([A-Z])/g, '$1_$2')
    .toLowerCase();
-  iconOverrides[customIcon] = (props: IconType) => (
-    <AsyncIcon customIcons fileName={fileName} {...props} />
+  iconOverrides[customIcon] = forwardRef<HTMLSpanElement, IconType>(
+    (props, ref) => (
+      <AsyncIcon ref={ref} customIcons fileName={fileName} {...props} />
+    ),
  );
 });

@@ -74,7 +80,7 @@ export type IconNameType =
  | keyof typeof antdEnhancedIcons
  | keyof typeof iconOverrides;

-type IconComponentType = Record<IconNameType, FC<IconType>>;
+type IconComponentType = Record<IconNameType, IconComponent>;

 export const Icons: IconComponentType = {
  ...antdEnhancedIcons,
--- a/superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx
@@ -16,6 +16,7 @@
 * specific language governing permissions and limitations
 * under the License.
 */
+import { forwardRef } from 'react';
 import { Tag } from '@superset-ui/core/components/Tag';
 import { css } from '@emotion/react';
 import { useTheme, getColorVariants } from '@apache-superset/core/theme';
@@ -23,7 +24,7 @@ import { DatasetTypeLabel } from './reusable/DatasetTypeLabel';
 import { PublishedLabel } from './reusable/PublishedLabel';
 import type { LabelProps } from './types';

-export function Label(props: LabelProps) {
+export const Label = forwardRef<HTMLSpanElement, LabelProps>((props, ref) => {
  const theme = useTheme();
  // Use Ant Design's motion duration instead of deprecated transitionTiming
  const {
@@ -71,6 +72,7 @@ export function Label(props: LabelProps) {

  return (
    <Tag
+      ref={ref}
      onClick={onClick}
      role={onClick ? 'button' : undefined}
      style={style}
@@ -81,6 +83,6 @@ export function Label(props: LabelProps) {
      {children}
    </Tag>
  );
-}
+});
 export { DatasetTypeLabel, PublishedLabel };
 export type { LabelType } from './types';
--- a/superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
@@ -371,6 +371,9 @@ const CustomModal = ({
            disabled={!draggable || dragDisabled}
            bounds={bounds}
            onStart={(event, uiData) => onDragStart(event, uiData)}
+            // Pass nodeRef so react-draggable does not fall back to
+            // ReactDOM.findDOMNode (deprecated in React 18+ Strict Mode).
+            nodeRef={draggableRef}
            {...draggableConfig}
          >
            {resizable ? (
--- a/superset-frontend/packages/superset-ui-core/src/components/Popover/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Popover/index.tsx
@@ -16,11 +16,15 @@
 * specific language governing permissions and limitations
 * under the License.
 */
+import { forwardRef } from 'react';
 import { Popover as AntdPopover } from 'antd';
 import { PopoverProps as AntdPopoverProps } from 'antd/es/popover';
+import type { TooltipRef } from 'antd/es/tooltip';

 export interface PopoverProps extends AntdPopoverProps {
  forceRender?: boolean;
 }

-export const Popover = (props: PopoverProps) => <AntdPopover {...props} />;
+export const Popover = forwardRef<TooltipRef, PopoverProps>((props, ref) => (
+  <AntdPopover ref={ref} {...props} />
+));
--- a/superset-frontend/packages/superset-ui-core/src/components/RefreshLabel/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/RefreshLabel/index.tsx
@@ -16,10 +16,9 @@
 * specific language governing permissions and limitations
 * under the License.
 */
-import { MouseEventHandler, forwardRef } from 'react';
+import { MouseEventHandler } from 'react';
 import { SupersetTheme } from '@apache-superset/core/theme';
 import { Icons } from '@superset-ui/core/components/Icons';
-import type { IconType } from '@superset-ui/core/components/Icons/types';
 import { Tooltip } from '../Tooltip';

 export interface RefreshLabelProps {
@@ -32,25 +31,19 @@ const RefreshLabel = ({
  onClick,
  tooltipContent,
  disabled,
-}: RefreshLabelProps) => {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  const IconWithoutRef = forwardRef((props: IconType, ref: any) => (
-    <Icons.SyncOutlined iconSize="l" {...props} />
-  ));
-
-  return (
-    <Tooltip title={tooltipContent}>
-      <IconWithoutRef
-        role="button"
-        onClick={disabled ? undefined : onClick}
-        css={(theme: SupersetTheme) => ({
-          cursor: 'pointer',
-          color: theme.colorIcon,
-          '&:hover': { color: theme.colorPrimary },
-        })}
-      />
-    </Tooltip>
-  );
-};
+}: RefreshLabelProps) => (
+  <Tooltip title={tooltipContent}>
+    <Icons.SyncOutlined
+      iconSize="l"
+      role="button"
+      onClick={disabled ? undefined : onClick}
+      css={(theme: SupersetTheme) => ({
+        cursor: 'pointer',
+        color: theme.colorIcon,
+        '&:hover': { color: theme.colorPrimary },
+      })}
+    />
+  </Tooltip>
+);

 export default RefreshLabel;
--- a/superset-frontend/packages/superset-ui-core/src/components/Tooltip/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Tooltip/index.tsx
@@ -16,17 +16,22 @@
 * specific language governing permissions and limitations
 * under the License.
 */
+import { forwardRef } from 'react';
 import { Tooltip as AntdTooltip } from 'antd';
+import type { TooltipRef } from 'antd/es/tooltip';

 import type { TooltipProps, TooltipPlacement } from './types';

-export const Tooltip = ({ overlayStyle, ...props }: TooltipProps) => (
-  <AntdTooltip
-    styles={{
-      body: { overflow: 'hidden', textOverflow: 'ellipsis' },
-      root: overlayStyle ?? {},
-    }}
-    {...props}
-  />
+export const Tooltip = forwardRef<TooltipRef, TooltipProps>(
+  ({ overlayStyle, ...props }, ref) => (
+    <AntdTooltip
+      ref={ref}
+      styles={{
+        body: { overflow: 'hidden', textOverflow: 'ellipsis' },
+        root: overlayStyle ?? {},
+      }}
+      {...props}
+    />
+  ),
 );
 export type { TooltipProps, TooltipPlacement };
--- a/superset-frontend/plugins/legacy-plugin-chart-calendar/package.json
+++ b/superset-frontend/plugins/legacy-plugin-chart-calendar/package.json
@@ -33,7 +33,7 @@
    "@superset-ui/chart-controls": "*",
    "@superset-ui/core": "*",
    "@apache-superset/core": "*",
-    "react": "^18.2.0"
+    "react": "^18.3.0"
  },
  "publishConfig": {
    "access": "public"
--- a/superset-frontend/plugins/legacy-plugin-chart-country-map/package.json
+++ b/superset-frontend/plugins/legacy-plugin-chart-country-map/package.json
@@ -34,6 +34,6 @@
    "@apache-superset/core": "*",
    "@superset-ui/chart-controls": "*",
    "@superset-ui/core": "*",
-    "react": "^18.2.0"
+    "react": "^18.3.0"
  }
 }
--- a/superset-frontend/plugins/legacy-plugin-chart-horizon/package.json
+++ b/superset-frontend/plugins/legacy-plugin-chart-horizon/package.json
@@ -31,7 +31,7 @@
    "@superset-ui/chart-controls": "*",
    "@superset-ui/core": "*",
    "@apache-superset/core": "*",
-    "react": "^18.2.0"
+    "react": "^18.3.0"
  },
  "publishConfig": {
    "access": "public"
--- a/superset-frontend/plugins/legacy-plugin-chart-paired-t-test/package.json
+++ b/superset-frontend/plugins/legacy-plugin-chart-paired-t-test/package.json
@@ -31,7 +31,7 @@
    "@superset-ui/chart-controls": "*",
    "@superset-ui/core": "*",
    "@apache-superset/core": "*",
-    "react": "^18.2.0"
+    "react": "^18.3.0"
  },
  "publishConfig": {
    "access": "public"
--- a/superset-frontend/plugins/legacy-plugin-chart-parallel-coordinates/package.json
+++ b/superset-frontend/plugins/legacy-plugin-chart-parallel-coordinates/package.json
@@ -36,6 +36,6 @@
    "@superset-ui/chart-controls": "*",
    "@superset-ui/core": "*",
    "@apache-superset/core": "*",
-    "react": "^18.2.0"
+    "react": "^18.3.0"
  }
 }
--- a/superset-frontend/plugins/legacy-plugin-chart-partition/package.json
+++ b/superset-frontend/plugins/legacy-plugin-chart-partition/package.json
@@ -33,8 +33,8 @@
    "@apache-superset/core": "*",
    "@testing-library/jest-dom": "*",
    "@testing-library/react": "^14.0.0",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0"
+    "react": "^18.3.0",
+    "react-dom": "^18.3.0"
  },
  "publishConfig": {
    "access": "public"
--- a/superset-frontend/plugins/legacy-plugin-chart-rose/package.json
+++ b/superset-frontend/plugins/legacy-plugin-chart-rose/package.json
@@ -32,7 +32,7 @@
    "@superset-ui/chart-controls": "*",
    "@superset-ui/core": "*",
    "@apache-superset/core": "*",
-    "react": "^18.2.0"
+    "react": "^18.3.0"
  },
  "publishConfig": {
    "access": "public"
--- a/superset-frontend/plugins/legacy-plugin-chart-world-map/package.json
+++ b/superset-frontend/plugins/legacy-plugin-chart-world-map/package.json
@@ -39,6 +39,6 @@
    "@superset-ui/chart-controls": "*",
    "@superset-ui/core": "*",
    "@apache-superset/core": "*",
-    "react": "^18.2.0"
+    "react": "^18.3.0"
  }
 }
--- a/superset-frontend/plugins/legacy-preset-chart-nvd3/package.json
+++ b/superset-frontend/plugins/legacy-preset-chart-nvd3/package.json
@@ -43,6 +43,6 @@
    "@superset-ui/chart-controls": "*",
    "@superset-ui/core": "*",
    "dayjs": "^1.11.21",
-    "react": "^18.2.0"
+    "react": "^18.3.0"
  }
 }
--- a/superset-frontend/plugins/plugin-chart-ag-grid-table/package.json
+++ b/superset-frontend/plugins/plugin-chart-ag-grid-table/package.json
@@ -44,8 +44,8 @@
    "@testing-library/react": "^14.0.0",
    "@testing-library/user-event": "*",
    "@types/react": "*",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0"
+    "react": "^18.3.0",
+    "react-dom": "^18.3.0"
  },
  "publishConfig": {
    "access": "public"
--- a/superset-frontend/plugins/plugin-chart-cartodiagram/package.json
+++ b/superset-frontend/plugins/plugin-chart-cartodiagram/package.json
@@ -47,7 +47,7 @@
    "geostyler-wfs-parser": "^3.0.1",
    "ol": "^10.8.0",
    "polished": "*",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0"
+    "react": "^18.3.0",
+    "react-dom": "^18.3.0"
  }
 }
--- a/superset-frontend/plugins/plugin-chart-echarts/package.json
+++ b/superset-frontend/plugins/plugin-chart-echarts/package.json
@@ -38,7 +38,7 @@
    "dayjs": "^1.11.21",
    "echarts": "*",
    "memoize-one": "*",
-    "react": "^18.2.0"
+    "react": "^18.3.0"
  },
  "publishConfig": {
    "access": "public"
--- a/superset-frontend/plugins/plugin-chart-handlebars/package.json
+++ b/superset-frontend/plugins/plugin-chart-handlebars/package.json
@@ -39,9 +39,9 @@
    "handlebars": "^4.7.8",
    "lodash": "^4.18.1",
    "dayjs": "^1.11.21",
-    "react": "^18.2.0",
+    "react": "^18.3.0",
    "react-ace": "^10.1.0",
-    "react-dom": "^18.2.0"
+    "react-dom": "^18.3.0"
  },
  "devDependencies": {
    "@types/jest": "^30.0.0",
--- a/superset-frontend/plugins/plugin-chart-pivot-table/package.json
+++ b/superset-frontend/plugins/plugin-chart-pivot-table/package.json
@@ -33,8 +33,8 @@
    "@superset-ui/core": "*",
    "lodash": "^4.18.1",
    "prop-types": "*",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0"
+    "react": "^18.3.0",
+    "react-dom": "^18.3.0"
  },
  "devDependencies": {
    "@babel/types": "^7.29.7",
--- a/superset-frontend/plugins/plugin-chart-point-cluster-map/package.json
+++ b/superset-frontend/plugins/plugin-chart-point-cluster-map/package.json
@@ -36,8 +36,8 @@
    "@apache-superset/core": "*",
    "@superset-ui/chart-controls": "*",
    "@superset-ui/core": "*",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0"
+    "react": "^18.3.0",
+    "react-dom": "^18.3.0"
  },
  "publishConfig": {
    "access": "public"
--- a/superset-frontend/plugins/plugin-chart-table/package.json
+++ b/superset-frontend/plugins/plugin-chart-table/package.json
@@ -45,8 +45,8 @@
    "@testing-library/user-event": "*",
    "@types/react": "*",
    "match-sorter": "^8.2.0",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0"
+    "react": "^18.3.0",
+    "react-dom": "^18.3.0"
  },
  "publishConfig": {
    "access": "public"
--- a/superset-frontend/plugins/plugin-chart-word-cloud/package.json
+++ b/superset-frontend/plugins/plugin-chart-word-cloud/package.json
@@ -39,7 +39,7 @@
    "@superset-ui/core": "*",
    "@types/lodash": "*",
    "@types/react": "*",
-    "react": "^18.2.0"
+    "react": "^18.3.0"
  },
  "devDependencies": {
    "@types/d3-cloud": "^1.2.9"
--- a/superset-frontend/plugins/preset-chart-deckgl/package.json
+++ b/superset-frontend/plugins/preset-chart-deckgl/package.json
@@ -67,8 +67,8 @@
    "@superset-ui/core": "*",
    "dayjs": "^1.11.21",
    "mapbox-gl": ">=1.0.0",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0"
+    "react": "^18.3.0",
+    "react-dom": "^18.3.0"
  },
  "peerDependenciesMeta": {
    "mapbox-gl": {
--- a/superset-frontend/spec/helpers/shim.tsx
+++ b/superset-frontend/spec/helpers/shim.tsx
@@ -16,7 +16,7 @@
 * specific language governing permissions and limitations
 * under the License.
 */
-import { AriaAttributes } from 'react';
+import { AriaAttributes, Ref } from 'react';
 import 'core-js/stable';
 import 'regenerator-runtime/runtime';
 import jQuery from 'jquery';
@@ -98,31 +98,39 @@ jest.mock('rehype-raw', () => () => jest.fn());
 // Tests should override this when needed
 jest.mock('@superset-ui/core/components/Icons/AsyncIcon', () => ({
  __esModule: true,
-  default: ({
-    fileName,
-    role,
-    'aria-label': ariaLabel,
-    onClick,
-    ...rest
-  }: {
-    fileName: string;
-    role?: string;
-    'aria-label'?: AriaAttributes['aria-label'];
-    onClick?: () => void;
-  }) => {
-    // Simple mock that provides the essential attributes for testing
-    const label = ariaLabel || fileName?.replace(/_/g, '-').toLowerCase() || '';
-    return (
-      // eslint-disable-next-line jsx-a11y/no-static-element-interactions
-      <span
-        role={role || (onClick ? 'button' : 'img')}
-        aria-label={label}
-        data-test={label}
-        onClick={onClick}
-        {...rest}
-      />
-    );
-  },
+  // eslint-disable-next-line global-require
+  default: require('react').forwardRef(
+    (
+      {
+        fileName,
+        role,
+        'aria-label': ariaLabel,
+        onClick,
+        ...rest
+      }: {
+        fileName: string;
+        role?: string;
+        'aria-label'?: AriaAttributes['aria-label'];
+        onClick?: () => void;
+      },
+      ref: Ref<HTMLSpanElement>,
+    ) => {
+      // Simple mock that provides the essential attributes for testing
+      const label =
+        ariaLabel || fileName?.replace(/_/g, '-').toLowerCase() || '';
+      return (
+        // eslint-disable-next-line jsx-a11y/no-static-element-interactions
+        <span
+          ref={ref}
+          role={role || (onClick ? 'button' : 'img')}
+          aria-label={label}
+          data-test={label}
+          onClick={onClick}
+          {...rest}
+        />
+      );
+    },
+  ),
  StyledIcon: ({
    component: Component,
    role,
--- a/superset-frontend/src/SqlLab/components/QueryAutoRefresh/QueryAutoRefresh.test.tsx
+++ b/superset-frontend/src/SqlLab/components/QueryAutoRefresh/QueryAutoRefresh.test.tsx
@@ -16,7 +16,7 @@
 * specific language governing permissions and limitations
 * under the License.
 */
-import { act } from 'react-dom/test-utils';
+import { act } from 'react';
 import { QueryState } from '@superset-ui/core';
 import fetchMock from 'fetch-mock';
 import configureStore from 'redux-mock-store';
--- a/superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
+++ b/superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
@@ -189,15 +189,19 @@ const SqlEditorLeftBar = ({ queryEditorId }: SqlEditorLeftBarProps) => {
        placement="bottomLeft"
        trigger="click"
      >
-        <DatabaseSelector
-          key={`db-selector-${db ? db.id : 'no-db'}:${catalog ?? 'no-catalog'}:${
-            schema ?? 'no-schema'
-          }`}
-          {...dbSelectorProps}
-          emptyState={<EmptyState />}
-          sqlLabMode
-          onOpenModal={openSelectorModal}
-        />
+        {/* Wrap in a span so the Popover can attach a ref without relying
+            on findDOMNode (deprecated in React 18+). */}
+        <span>
+          <DatabaseSelector
+            key={`db-selector-${db ? db.id : 'no-db'}:${catalog ?? 'no-catalog'}:${
+              schema ?? 'no-schema'
+            }`}
+            {...dbSelectorProps}
+            emptyState={<EmptyState />}
+            sqlLabMode
+            onOpenModal={openSelectorModal}
+          />
+        </span>
      </Popover>
      <StyledDivider />
      <TableExploreTree queryEditorId={activeQEId} />
--- a/superset-frontend/src/components/CopyToClipboard/index.tsx
+++ b/superset-frontend/src/components/CopyToClipboard/index.tsx
@@ -98,7 +98,10 @@ class CopyToClip extends Component<CopyToClipboardProps> {
            trigger={['hover']}
            arrow={{ pointAtCenter: true }}
          >
-            {this.getDecoratedCopyNode()}
+            {/* Wrap in a span so antd Tooltip has a real DOM ref target;
+                avoids findDOMNode fallback when copyNode is a function
+                component without forwardRef. */}
+            <span>{this.getDecoratedCopyNode()}</span>
          </Tooltip>
        ) : (
          this.getDecoratedCopyNode()
--- a/superset-frontend/src/components/GenericLink/index.tsx
+++ b/superset-frontend/src/components/GenericLink/index.tsx
@@ -17,21 +17,25 @@
 * under the License.
 */
 import { sanitizeUrl } from '@braintree/sanitize-url';
-import { PropsWithoutRef, RefAttributes } from 'react';
+import { forwardRef, PropsWithoutRef, Ref, RefAttributes } from 'react';
 import { Link, LinkProps } from 'react-router-dom';
 import { isUrlExternal, parseUrl } from 'src/utils/urlUtils';

-export const GenericLink = <S,>({
-  to,
-  component,
-  replace,
-  innerRef,
-  children,
-  ...rest
-}: PropsWithoutRef<LinkProps<S>> & RefAttributes<HTMLAnchorElement>) => {
+type GenericLinkProps<S> = PropsWithoutRef<LinkProps<S>> &
+  RefAttributes<HTMLAnchorElement>;
+
+const GenericLinkInner = <S,>(
+  { to, component, replace, innerRef, children, ...rest }: GenericLinkProps<S>,
+  ref: Ref<HTMLAnchorElement>,
+) => {
  if (typeof to === 'string' && isUrlExternal(to)) {
    return (
-      <a data-test="external-link" href={sanitizeUrl(parseUrl(to))} {...rest}>
+      <a
+        ref={ref}
+        data-test="external-link"
+        href={sanitizeUrl(parseUrl(to))}
+        {...rest}
+      >
        {children}
      </a>
    );
@@ -42,10 +46,14 @@ export const GenericLink = <S,>({
      to={to}
      component={component}
      replace={replace}
-      innerRef={innerRef}
+      innerRef={innerRef ?? ref}
      {...rest}
    >
      {children}
    </Link>
  );
 };
+
+export const GenericLink = forwardRef(GenericLinkInner) as <S>(
+  props: GenericLinkProps<S> & { ref?: Ref<HTMLAnchorElement> },
+) => ReturnType<typeof GenericLinkInner>;
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.tsx
@@ -193,52 +193,57 @@ export default function getControlItemsMap({
              t('Populate "Default value" to enable this control')
            }
          >
-            <StyledRowFormItem
-              expanded={expanded}
-              key={controlItem.name}
-              name={['filters', filterId, 'controlValues', controlItem.name]}
-              initialValue={initialValue}
-              valuePropName="checked"
-              colon={false}
-            >
-              <Checkbox
-                disabled={controlItem.config.affectsDataMask && disabled}
-                onChange={checked => {
-                  if (controlItem.config.requiredFirst) {
-                    setNativeFilterFieldValues(form, filterId, {
-                      requiredFirst: {
-                        ...formFilter?.requiredFirst,
-                        [controlItem.name]: checked,
-                      },
-                    });
-                  }
-                  if (controlItem.config.resetConfig) {
-                    setNativeFilterFieldValues(form, filterId, {
-                      defaultDataMask: null,
-                    });
-                  }
-                  formChanged();
-                  forceUpdate();
-                }}
+            {/* Wrap in span so antd Tooltip can attach a ref without
+                relying on findDOMNode (deprecated in React 18+). */}
+            <span>
+              <StyledRowFormItem
+                expanded={expanded}
+                key={controlItem.name}
+                name={['filters', filterId, 'controlValues', controlItem.name]}
+                initialValue={initialValue}
+                valuePropName="checked"
+                colon={false}
              >
-                <>
-                  {typeof controlItem.config.label === 'function'
-                    ? (controlItem.config.label as Function)()
-                    : controlItem.config.label}
-                  &nbsp;
-                  {controlItem.config.description && (
-                    <InfoTooltip
-                      placement="top"
-                      tooltip={
-                        typeof controlItem.config.description === 'function'
-                          ? (controlItem.config.description as Function)()
-                          : (controlItem.config.description as React.ReactNode)
-                      }
-                    />
-                  )}
-                </>
-              </Checkbox>
-            </StyledRowFormItem>
+                <Checkbox
+                  disabled={controlItem.config.affectsDataMask && disabled}
+                  onChange={checked => {
+                    if (controlItem.config.requiredFirst) {
+                      setNativeFilterFieldValues(form, filterId, {
+                        requiredFirst: {
+                          ...formFilter?.requiredFirst,
+                          [controlItem.name]: checked,
+                        },
+                      });
+                    }
+                    if (controlItem.config.resetConfig) {
+                      setNativeFilterFieldValues(form, filterId, {
+                        defaultDataMask: null,
+                      });
+                    }
+                    formChanged();
+                    forceUpdate();
+                  }}
+                >
+                  <>
+                    {typeof controlItem.config.label === 'function'
+                      ? (controlItem.config.label as Function)()
+                      : controlItem.config.label}
+                    &nbsp;
+                    {controlItem.config.description && (
+                      <InfoTooltip
+                        placement="top"
+                        tooltip={
+                          typeof controlItem.config.description === 'function'
+                            ? (controlItem.config.description as Function)()
+                            : (controlItem.config
+                                .description as React.ReactNode)
+                        }
+                      />
+                    )}
+                  </>
+                </Checkbox>
+              </StyledRowFormItem>
+            </span>
          </Tooltip>
        </>
      );
--- a/superset-frontend/src/explore/components/controls/ColorBreakpointsControl/ColorBreakpointPopoverTrigger.tsx
+++ b/superset-frontend/src/explore/components/controls/ColorBreakpointsControl/ColorBreakpointPopoverTrigger.tsx
@@ -54,7 +54,9 @@ const ColorBreakpointsPopoverTrigger = ({
      onOpenChange={setVisibility}
      destroyOnHidden
    >
-      {props.children}
+      {/* Wrap in span so the Popover can attach a ref without relying
+          on findDOMNode (deprecated in React 18+). */}
+      <span>{props.children}</span>
    </ControlPopover>
  );
 };
--- a/superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverTrigger.tsx
+++ b/superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverTrigger.tsx
@@ -52,7 +52,9 @@ const ContourPopoverTrigger = ({
      onOpenChange={setVisibility}
      destroyOnHidden
    >
-      {props.children}
+      {/* Wrap in span so the Popover can attach a ref without relying
+          on findDOMNode (deprecated in React 18+). */}
+      <span>{props.children}</span>
    </ControlPopover>
  );
 };
--- a/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
+++ b/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
@@ -369,16 +369,21 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
      overlayClassName="time-range-popover"
    >
      <Tooltip placement="top" title={tooltipTitle}>
-        <DateLabel
-          name={name}
-          aria-labelledby={`filter-name-${props.name}`}
-          aria-describedby={`date-label-${props.name}`}
-          label={actualTimeRange}
-          isActive={show}
-          isPlaceholder={actualTimeRange === NO_TIME_RANGE}
-          data-test={DateFilterTestKey.PopoverOverlay}
-          ref={labelRef}
-        />
+        {/* Wrap in a span so the Popover gets a stable DOM ref target;
+            DateLabel forwards its ref to an inner span used for measuring
+            text truncation, which would otherwise become the popover's
+            positioning anchor in React 18. */}
+        <span data-test={DateFilterTestKey.PopoverOverlay}>
+          <DateLabel
+            name={name}
+            aria-labelledby={`filter-name-${props.name}`}
+            aria-describedby={`date-label-${props.name}`}
+            label={actualTimeRange}
+            isActive={show}
+            isPlaceholder={actualTimeRange === NO_TIME_RANGE}
+            ref={labelRef}
+          />
+        </span>
      </Tooltip>
    </ControlPopover>
  );
--- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopoverTrigger.tsx
+++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopoverTrigger.tsx
@@ -201,7 +201,9 @@ const ColumnSelectPopoverTriggerInner = ({
        title={popoverTitle}
        destroyOnHidden
      >
-        {children}
+        {/* Wrap in span so the Popover can attach a ref without relying
+            on findDOMNode (deprecated in React 18+). */}
+        <span>{children}</span>
      </ControlPopover>
    </>
  );
--- a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/index.tsx
+++ b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/index.tsx
@@ -104,14 +104,6 @@ interface AdhocFilterControlState {

 const { warning } = Modal;

-const defaultProps = {
-  name: '',
-  onChange: () => {},
-  columns: [],
-  savedMetrics: [],
-  selectedMetrics: [],
-};
-
 function optionsForSelect(props: AdhocFilterControlProps): FilterOption[] {
  const options = [
    ...(props.columns || []),
@@ -391,7 +383,7 @@ class AdhocFilterControl extends Component<
    return (
      <div className="metrics-select" data-test="adhoc-filter-control">
        <HeaderContainer>
-          <ControlHeader {...this.props} />
+          <ControlHeader {...this.props} name={this.props.name ?? ''} />
        </HeaderContainer>
        <LabelsContainer>
          {[
@@ -413,7 +405,4 @@ class AdhocFilterControl extends Component<
  }
 }

-// @ts-expect-error - defaultProps for backward compatibility
-AdhocFilterControl.defaultProps = defaultProps;
-
 export default withTheme(AdhocFilterControl);
--- a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterPopoverTrigger/index.tsx
+++ b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterPopoverTrigger/index.tsx
@@ -112,7 +112,9 @@ class AdhocFilterPopoverTrigger extends PureComponent<
        onOpenChange={togglePopover}
        destroyOnHidden
      >
-        {this.props.children}
+        {/* Wrap in span so the Popover can attach a ref without relying
+            on findDOMNode (deprecated in React 18+). */}
+        <span>{this.props.children}</span>
      </ControlPopover>
    );
  }
--- a/superset-frontend/src/explore/components/controls/FixedOrMetricControl/index.tsx
+++ b/superset-frontend/src/explore/components/controls/FixedOrMetricControl/index.tsx
@@ -64,10 +64,7 @@ interface FixedOrMetricControlState {
  metricValue: MetricValue | null;
 }

-const defaultProps = {
-  onChange: () => {},
-  default: { type: controlTypes.fixed, value: 5 },
-};
+const DEFAULT_VALUE: ControlValue = { type: controlTypes.fixed, value: 5 };

 export default class FixedOrMetricControl extends Component<
  FixedOrMetricControlProps,
@@ -79,10 +76,11 @@ export default class FixedOrMetricControl extends Component<
    this.setType = this.setType.bind(this);
    this.setFixedValue = this.setFixedValue.bind(this);
    this.setMetric = this.setMetric.bind(this);
+    const defaultValue = props.default ?? DEFAULT_VALUE;
    const type = (props.value?.type ??
-      props.default?.type ??
+      defaultValue.type ??
      controlTypes.fixed) as 'fix' | 'metric';
-    const rawValue = props.value?.value ?? props.default?.value ?? '100';
+    const rawValue = props.value?.value ?? defaultValue.value ?? '100';
    const fixedValue =
      type === controlTypes.fixed && typeof rawValue !== 'object'
        ? rawValue
@@ -121,7 +119,7 @@ export default class FixedOrMetricControl extends Component<
  }

  render() {
-    const value = this.props.value ?? this.props.default;
+    const value = this.props.value ?? this.props.default ?? DEFAULT_VALUE;
    const type = value?.type ?? controlTypes.fixed;
    const columns = this.props.datasource
      ? this.props.datasource.columns
@@ -203,6 +201,3 @@ export default class FixedOrMetricControl extends Component<
    );
  }
 }
-
-// @ts-expect-error - defaultProps for backward compatibility
-FixedOrMetricControl.defaultProps = defaultProps;
--- a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.tsx
+++ b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.tsx
@@ -34,7 +34,6 @@ import {
  Tooltip,
 } from '@superset-ui/core/components';
 import sqlKeywords from 'src/SqlLab/utils/sqlKeywords';
-import { noOp } from 'src/utils/common';
 import {
  AGGREGATES_OPTIONS,
  POPOVER_INITIAL_HEIGHT,
@@ -106,12 +105,6 @@ interface AdhocMetricEditPopoverState {
  height: number;
 }

-const defaultProps = {
-  columns: [],
-  getCurrentTab: noOp,
-  isNewMetric: false,
-};
-
 const StyledSelect = styled(Select)`
  .metric-option {
    & > svg {
@@ -199,8 +192,12 @@ class AdhocMetricEditPopover extends PureComponent<
  }

  getDefaultTab() {
-    const { adhocMetric, savedMetric, savedMetricsOptions, isNewMetric } =
-      this.props;
+    const {
+      adhocMetric,
+      savedMetric,
+      savedMetricsOptions,
+      isNewMetric = false,
+    } = this.props;
    if (isDefined(adhocMetric.column) || isDefined(adhocMetric.sqlExpression)) {
      return adhocMetric.expressionType;
    }
@@ -353,7 +350,7 @@ class AdhocMetricEditPopover extends PureComponent<
      onClose,
      onResize,
      datasource,
-      isNewMetric,
+      isNewMetric = false,
      isLabelModified,
      ...popoverProps
    } = this.props;
@@ -606,8 +603,6 @@ class AdhocMetricEditPopover extends PureComponent<
    );
  }
 }
-// @ts-expect-error - defaultProps for backward compatibility
-AdhocMetricEditPopover.defaultProps = defaultProps;

 // ---------------------------------------------------------------------------
 // Thin functional wrapper that injects compatibility data from Redux.
--- a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricPopoverTrigger.tsx
+++ b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricPopoverTrigger.tsx
@@ -274,7 +274,9 @@ class AdhocMetricPopoverTrigger extends PureComponent<
          title={popoverTitle}
          destroyOnHidden
        >
-          {this.props.children}
+          {/* Wrap in span so the Popover can attach a ref without relying
+              on findDOMNode (deprecated in React 18+). */}
+          <span>{this.props.children}</span>
        </ControlPopover>
      </>
    );
--- a/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.tsx
+++ b/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.tsx
@@ -32,13 +32,6 @@ import MetricDefinitionValue from './MetricDefinitionValue';
 import AdhocMetric from './AdhocMetric';
 import AdhocMetricPopoverTrigger from './AdhocMetricPopoverTrigger';

-const defaultProps = {
-  onChange: () => {},
-  clearable: true,
-  savedMetrics: [],
-  columns: [],
-};
-
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 function getOptionsForSavedMetrics(
  savedMetrics: any,
@@ -122,11 +115,11 @@ export interface MetricsControlProps {
 }

 const MetricsControl = ({
-  onChange,
+  onChange = () => {},
  multi,
  value: propsValue,
-  columns,
-  savedMetrics,
+  columns = [],
+  savedMetrics = [],
  datasource,
  ...props
 }: MetricsControlProps) => {
@@ -351,6 +344,4 @@ const MetricsControl = ({
  );
 };

-MetricsControl.defaultProps = defaultProps;
-
 export default MetricsControl;
--- a/superset-frontend/src/features/home/ChartTable.test.tsx
+++ b/superset-frontend/src/features/home/ChartTable.test.tsx
@@ -24,7 +24,7 @@ import {
 } from 'spec/helpers/testing-library';
 import { VizType } from '@superset-ui/core';
 import fetchMock from 'fetch-mock';
-import { act } from 'react-dom/test-utils';
+import { act } from 'react';
 import handleResourceExport from 'src/utils/export';
 import { LocalStorageKeys } from 'src/utils/localStorageHelpers';
 import ChartTable from './ChartTable';
--- a/superset-frontend/src/theme/tests/ThemeController.test.ts
+++ b/superset-frontend/src/theme/tests/ThemeController.test.ts
@@ -111,12 +111,15 @@ const createController = (
    ...options,
  });

-// Shared console spies
-const consoleSpy = jest.spyOn(console, 'warn').mockImplementation();
-const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
+// Shared console spies — re-installed in beforeEach so each test starts
+// with a fresh call count and a clean implementation.
+let consoleSpy: jest.SpyInstance;
+let consoleErrorSpy: jest.SpyInstance;

 beforeEach(() => {
  jest.clearAllMocks();
+  consoleSpy = jest.spyOn(console, 'warn').mockImplementation();
+  consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();

  // Setup DOM environment
  Object.defineProperty(window, 'localStorage', {
--- a/superset/db_engine_specs/lint_metadata.py
+++ b/superset/db_engine_specs/lint_metadata.py
@@ -454,7 +454,7 @@ def print_report(reports: list[MetadataReport], verbose: bool = False) -> None:
    print("=" * 60)

    all_fields = {**REQUIRED_FIELDS, **RECOMMENDED_FIELDS, **OPTIONAL_FIELDS}
-    field_counts: dict[str, int] = {f: 0 for f in all_fields}
+    field_counts: dict[str, int] = dict.fromkeys(all_fields, 0)

    for r in reports:
        for field in r.present_fields:
--- a/superset/reports/notifications/email.py
+++ b/superset/reports/notifications/email.py
@@ -59,7 +59,7 @@ ALLOWED_TAGS = {
    "ul",
 }.union(TABLE_TAGS)

-ALLOWED_TABLE_ATTRIBUTES = {tag: TABLE_ATTRIBUTES for tag in TABLE_TAGS}
+ALLOWED_TABLE_ATTRIBUTES = dict.fromkeys(TABLE_TAGS, TABLE_ATTRIBUTES)
 ALLOWED_ATTRIBUTES = {
    "a": {"href", "title"},
    "abbr": {"title"},
--- a/superset/reports/notifications/slack_mixin.py
+++ b/superset/reports/notifications/slack_mixin.py
@@ -94,7 +94,7 @@ class SlackMixin:
        # need to truncate the data
        for i in range(len(df) - 1):
            truncated_df = df[: i + 1].fillna("")
-            truncated_row = pd.Series({k: "..." for k in df.columns})
+            truncated_row = pd.Series(dict.fromkeys(df.columns, "..."))
            truncated_df = pd.concat(
                [truncated_df, truncated_row.to_frame().T], ignore_index=True
            )
@@ -104,7 +104,7 @@ class SlackMixin:
            if len(message) > MAXIMUM_MESSAGE_SIZE:
                # Decrement i and build a message that is under the limit
                truncated_df = df[:i].fillna("")
-                truncated_row = pd.Series({k: "..." for k in df.columns})
+                truncated_row = pd.Series(dict.fromkeys(df.columns, "..."))
                truncated_df = pd.concat(
                    [truncated_df, truncated_row.to_frame().T], ignore_index=True
                )
Author	SHA1	Message	Date
Mehmet Salih Yavuz	2dedfc2139	Merge remote-tracking branch 'origin/master' into msyavuz/chore/react-18.3-bump	2026-06-08 22:45:39 +03:00
Mehmet Salih Yavuz	ba87f127af	Merge remote-tracking branch 'origin/master' into msyavuz/chore/react-18.3-bump	2026-06-01 23:22:51 +03:00
Mehmet Salih Yavuz	838c4f1384	chore(deps): sync package-lock for d3-cloud ^1.2.9	2026-06-01 21:35:36 +03:00
Mehmet Salih Yavuz	3b30328690	Merge remote-tracking branch 'origin/master' into msyavuz/chore/react-18.3-bump	2026-05-29 18:23:55 +03:00
Mehmet Salih Yavuz	4c8269fe91	fix(react18): address review feedback on dnd test attrs and defaultProps - Rename data-drag-source-id/data-drop-target-id to data-test-* so they are stripped from production bundles; add both names to the babel-plugin-jsx-remove-data-test-id allowlist (it matches names exactly, not by prefix). - Fully remove defaultProps from AdhocFilterControl, FixedOrMetricControl and AdhocMetricEditPopover; default at use sites instead.	2026-05-29 18:23:48 +03:00
Mehmet Salih Yavuz	4cf0fbb05a	Merge remote-tracking branch 'origin/master' into msyavuz/chore/react-18.3-bump # Conflicts: # superset-frontend/package-lock.json # superset-frontend/package.json	2026-05-27 18:10:19 +03:00
Mehmet Salih Yavuz	beda35f63b	fix(react18): make logging.test a module to avoid global-scope collision The test file declared a top-level `loadLogging` const without any top-level import/export, so TypeScript treated it as a script. Because `@apache-superset/core` is symlinked into node_modules as a workspace, tsc compiled the same file twice and `loadLogging` collided in global scope (TS2451), cascading into spyOn overload (TS2769) and possibly-undefined (TS18048) errors. Add an `export {}` so the file is treated as a module.	2026-05-22 17:26:10 +03:00
Mehmet Salih Yavuz	471f01356b	Merge remote-tracking branch 'origin/master' into msyavuz/chore/react-18.3-bump # Conflicts: # superset-frontend/spec/helpers/testing-library.tsx	2026-05-22 17:26:02 +03:00
Mehmet Salih Yavuz	77d63e183d	fix(react18): address review feedback on logging test + AvatarGroup - logging.test: replace require() with jest.isolateModules() + jest.requireActual() so the file passes @typescript-eslint/no-require-imports. - AvatarGroup: re-introduce forwardRef parity with Avatar by wrapping AntdAvatar.Group (plain FC) in a span the ref attaches to, so it can be used as a Tooltip / Popover anchor without findDOMNode fallback.	2026-05-20 13:35:33 +03:00
Mehmet Salih Yavuz	cbb84778dc	Merge remote-tracking branch 'origin/master' into msyavuz/chore/react-18.3-bump	2026-05-20 13:34:57 +03:00
Mehmet Salih Yavuz	660b83d8be	Merge remote-tracking branch 'origin/master' into msyavuz/chore/react-18.3-bump # Conflicts: # superset-frontend/package-lock.json # superset-frontend/package.json	2026-05-18 10:51:38 +03:00
Mehmet Salih Yavuz	f6bb9f3e7c	Merge branch 'master' into msyavuz/chore/react-18.3-bump	2026-05-15 18:04:52 +03:00
Mehmet Salih Yavuz	5e64af51a8	test: drop jest-fail-on-console Now that the surfaced React 18 / React 19 deprecation warnings have been fixed at their source, the global fail-on-console no longer adds signal — remove the setup and the dependency. ThemeController.test still installs its own console.warn / console.error spies in beforeEach to assert what the LocalStorageAdapter logs; updated the comment to reflect that they're no longer working around a wrapper.	2026-05-15 10:35:09 +03:00
Mehmet Salih Yavuz	cd01d1d433	test(react18): drive reorder drag tests with react-dnd-test-backend Replace the test.skip with a real fix. The two failing tests (DndMetricSelect > "can drag metrics" and DndColumnMetricSelect > "can drag and reorder items") drove drags via fireEvent.dragStart/dragOver/drop, which under React 18 + react-dnd@^11 raced the redux dispatch and tripped `Cannot call hover while not dragging`. Switch the test wrapper to support `useDnd: 'test'` (TestBackend) and have the two tests drive the drag via the backend's programmatic simulateBeginDrag/simulateHover/simulateDrop API. Sidesteps the jsdom HTML5-event/preventDefault/zero-rect gaps entirely; this is the pattern react-dnd itself recommends for tests. Expose `data-drag-source-id` / `data-drop-target-id` from OptionWrapper and OptionControls (sourced from `monitor.getHandlerId()` in the collect fn) so the tests can hand the backend the right handler IDs without hardcoding "S1"/"T4". No runtime change otherwise.	2026-05-14 21:36:35 +03:00
Mehmet Salih Yavuz	84178bf4e3	docs(react18): expand TODO on skipped drag tests with three fix paths The previous skip just said "upgrade react-dnd". After actually testing the upgrade locally I confirmed two things: 1. react-dnd@16 alone does fix the original "Cannot call hover while not dragging" Invariant — but v14+ requires `type` at the top level of every `useDrag` call (DatasourcePanelDragOption, OptionWrapper, OptionControls, and the dashboard legacy `DragSource` HOC sites), which is a bigger migration than belongs in a React-version bump. 2. Even with the upgrade, these specific tests still fail at a second hurdle: OptionWrapper.hover compares `monitor.getClientOffset` against `getBoundingClientRect`, both of which jsdom returns as zeroes/null, so the in-place reorder never fires. Replace the one-line "upgrade react-dnd" TODO with the three concrete paths (library bump, react-dnd-test-backend in spec/helpers, or local DOM mocks) so the follow-up is actionable without re-doing the investigation.	2026-05-14 20:28:10 +03:00
Mehmet Salih Yavuz	daf78c9374	test(react18): silence jest/no-disabled-tests on the skipped drag tests oxlint's jest/no-disabled-tests fires on the two `test.skip` calls added in the previous commit. Add a targeted eslint-disable-next-line so the skip stays explicit (TODO points at the react-dnd upgrade) without breaking lint.	2026-05-14 19:28:37 +03:00
Mehmet Salih Yavuz	705653f3ba	test(react18): skip 2 reorder-within-list drag tests pending react-dnd upgrade react-dnd@^11.1.3 is 5 majors behind current. Under React 18 the dragStart redux dispatch from react-dnd-html5-backend@11 doesn't reach `monitor.isDragging()` before the next fireEvent, so drag tests that combine useDrag + useDrop on the same element raise "Cannot call hover while not dragging" at drop. Pure source-only drag tests in these same files still pass. Skip the two affected tests with a TODO so the rest of the suite stays green; the proper fix is upgrading react-dnd to v14+ (full React 18 support), which is out of scope for this bump.	2026-05-14 19:09:43 +03:00
Mehmet Salih Yavuz	c6442adde1	fix(react18): resolve lint and findDOMNode/console-spy test failures Lint / type errors: - antd v5 doesn't re-export TooltipRef at the top level; import it from antd/es/tooltip in Tooltip and Popover wrappers. - AntdAvatar.Group is a plain React.FC and rejects refs — drop forwardRef on the AvatarGroup wrapper. - BaseIcon forwardRef target straddled HTMLSpanElement and SVGSVGElement; widen the ref type and cast the antd Icon branch to bypass the intersection. Test failures from console / DOM behaviour change in React 18: - ThemeController: re-spy console.warn/error in beforeEach so the jest-fail-on-console wrapper doesn't replace the spy each test. - logging.test: restore window.console in a finally so the failOnConsole afterEach can read console[methodName]. - QueryAutoRefresh / ChartTable: import `act` from `react` instead of the deprecated `react-dom/test-utils`. - CopyToClipboard: wrap the cloneElement copy node in a span so antd Tooltip has a real DOM ref target. - GenericLink: convert to forwardRef so it can be a Tooltip trigger. - DateFilterLabel: wrap the DateLabel trigger in a span — DateLabel forwards its ref to an inner span, which would otherwise become the popover's positioning anchor under React 18. - getControlItemsMap: wrap StyledRowFormItem inside the Tooltip in a span so antd doesn't fall back to findDOMNode. - SqlEditorLeftBar: wrap DatabaseSelector inside the Popover in a span for the same reason. - IconTooltip: forwardRef so it can be used as a tooltip / popover trigger child. Also pick up pre-commit auto-fixes (ruff PERF -> dict.fromkeys, prettier formatting) so pre-commit passes cleanly on CI.	2026-05-14 18:27:13 +03:00
Mehmet Salih Yavuz	bf4840dea1	fix(react18): forwardRef Popover wrapper, wrap explore popover trigger children in span - Popover (superset-ui-core): forward refs to antd Popover so consumers that pass it as a trigger child can attach a DOM ref without triggering findDOMNode. - Explore popover triggers (ColorBreakpoint, Contour, DndColumnSelect, AdhocFilter): the popover children are arbitrary user nodes which are often function components without forwardRef. Wrapping them in a span gives antd's resize observer a real DOM ref to attach, eliminating the React 18 deprecation warning.	2026-05-14 16:23:33 +03:00
Mehmet Salih Yavuz	f80000102b	fix(react18): forwardRef Avatar/AvatarGroup, wrap DropdownButton in span - Avatar / AvatarGroup: antd Avatar.Group children pass through a resize observer, so the wrappers need to support refs to skip the findDOMNode fallback. - DropdownButton: antd Dropdown.Button is a plain function component, so the Tooltip wrapping it cannot attach a ref. Wrap in a span so the resize observer attaches to a real DOM node.	2026-05-14 16:13:46 +03:00
Mehmet Salih Yavuz	f67bd7eadf	fix(react18): silence findDOMNode / defaultProps deprecations from popovers and modal - Modal: pass nodeRef to react-draggable so it stops falling back to ReactDOM.findDOMNode (deprecated in React 18). - MetricsControl: replace the static MetricsControl.defaultProps assignment with destructured parameter defaults (React 18 deprecates defaultProps on function components). - AdhocMetricPopoverTrigger: wrap the popover trigger child in a span so antd Popover's resize observer can attach a ref to a real DOM node, avoiding the findDOMNode fallback path.	2026-05-14 15:59:51 +03:00
Mehmet Salih Yavuz	bcea2c2668	fix(react18): forwardRef on superset-ui-core wrappers used as tooltip/dropdown triggers React 18.3 promotes findDOMNode to a deprecation warning. rc-resize-observer (inside antd Tooltip/Dropdown) falls back to findDOMNode when its child does not support refs. Without forwardRef on Button, Label, Tooltip, BaseIconComponent, AsyncIcon, the antd-generated Icons (antdEnhancedIcons + iconOverrides), and the AsyncIcon jest mock, every Tooltip/Dropdown wrapping these would emit the warning and fail jest-fail-on-console. EditableTitle wraps antd Input.TextArea in a Tooltip. TextArea's imperative ref returns { resizableTextArea, focus, blur } (not a DOM node), so the resize observer's findDOMNode-fallback fires anyway; wrap in a span to attach a real DOM ref. Also drop the empty IconWithoutRef helper in RefreshLabel that was wrapping an icon in forwardRef without forwarding the ref.	2026-05-14 15:48:24 +03:00
Mehmet Salih Yavuz	8cfbf24b81	chore(deps): bump react to ^18.3.0	2026-05-11 11:23:40 +03:00