fix: remove redundant event handler

fix(AlertReportModal): visible button text for new filters
2026-06-12 11:09:15 +00:00 · 2026-02-20 10:45:24 +03:00 · 2026-02-20 09:50:02 +03:00
1 changed files with 4 additions and 14 deletions
--- a/superset-frontend/src/features/alerts/AlertReportModal.tsx
+++ b/superset-frontend/src/features/alerts/AlertReportModal.tsx
@@ -34,6 +34,7 @@ import {
  VizType,
  getExtensionsRegistry,
 } from '@superset-ui/core';
+import { Button } from '@superset-ui/core/components';
 import { css, styled, SupersetTheme, useTheme } from '@apache-superset/core/ui';
 import rison from 'rison';
 import { useSingleViewResource } from 'src/views/CRUD/hooks';
@@ -380,11 +381,6 @@ export const StyledInputContainer = styled.div`
      .filters-add-container {
        flex: '.25';
        padding: '${theme.sizeUnit * 3} 0';
-
-        .filters-add-btn {
-          padding: ${theme.sizeUnit * 2}px;
-          color: ${theme.colorWhite};
-        }
      }
    }
  `}
@@ -2512,23 +2508,17 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
                              <div className="filters-add-container">
                                {filterNativeFilterOptions().length > 0 && (
                                  // eslint-disable-next-line jsx-a11y/anchor-is-valid
-                                  <a
+                                  <Button
                                    className="filters-add-btn"
-                                    role="button"
+                                    buttonStyle="link"
                                    tabIndex={0}
                                    onClick={() => {
                                      handleAddFilterField();
                                      add();
                                    }}
-                                    onKeyDown={e => {
-                                      if (e.key === 'Enter' || e.key === ' ') {
-                                        handleAddFilterField();
-                                        add();
-                                      }
-                                    }}
                                  >
                                    + {t('Apply another dashboard filter')}
-                                  </a>
+                                  </Button>
                                )}
                              </div>
                            </div>
Author	SHA1	Message	Date
Mehmet Salih Yavuz	b94e1e9deb	fix: remove redundant event handler	2026-02-20 10:45:24 +03:00
Mehmet Salih Yavuz	e3027f67d1	fix(AlertReportModal): visible button text for new filters	2026-02-20 09:50:02 +03:00