QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-05-27 14:34:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(settings/debugs): migrate in-cell <details> to DS::Disclosure :inline (#1916)

Browse Source 
#1858's :inline variant landed (commit 8de14ed2), unblocking the third
sure-design drift finding on this file (#1895 / #1898).

The :inline variant is the right shape for an in-table-cell metadata
expander — no surface, no padding, no shadow; the summary reads as plain
text-link copy. The bot recommended this exact variant when filing the
issues; previous PR (#1903) covered the two token findings but deferred
the <details> migration until the variant was available.

Closes #1895. Closes #1898.
This commit is contained in:
Guillem Arias Fauste
2026-05-23 08:45:45 +02:00
committed by GitHub
parent ced133d06e
commit 814505c5ea
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/views/settings/debugs/show.html.erb
View File

@@ -87,10 +87,12 @@
</td>
<td class="px-4 py-3 text-xs text-secondary align-top">
<% if entry.metadata.present? %>
<details>
<summary class="cursor-pointer"><%= t(".table.view_metadata") %></summary>
<pre class="mt-2 whitespace-pre-wrap break-words"><%= JSON.pretty_generate(entry.metadata) %></pre>
</details>
<%= render DS::Disclosure.new(variant: :inline) do |disclosure| %>
<% disclosure.with_summary_content do %>
<span class="text-xs text-secondary"><%= t(".table.view_metadata") %></span>
<% end %>
<pre class="whitespace-pre-wrap break-words"><%= JSON.pretty_generate(entry.metadata) %></pre>
<% end %>
<% else %>
<%= t(".missing_value") %>
<% end %>