Falloutman and Justin
fc130a1957
fix: add Schwab to SimpleFIN total-basis cost_basis allowlist ( #2986 )
...
Charles Schwab's SimpleFIN feed reports `cost_basis` as the total
position cost rather than per-share, violating the spec in the same
way Vanguard (#1182 ) and Fidelity (#1718 ) already do. Schwab wasn't on
the TOTAL_BASIS_INSTITUTIONS allowlist, so the raw total was stored
directly into holdings.cost_basis and treated as per-share downstream.
Holding#calculate_trend multiplies avg_cost by qty again when
reconstructing original cost, so an unadjusted total gets squared by
share count — a $46,950 position with a true +55.7% gain rendered as
-99.8% / -$19.6M "return" on the dashboard and per-account holdings
views.
Picks up where #2626 left off: adds the allowlist entry, fixes the
now-outdated compliant-institution test case it broke, and adds a
dedicated regression test using real observed Schwab payload values.
Fixes #2626
Co-authored-by: Justin <justin@local>
2026-08-10 07:20:55 +02:00
..
2026-07-26 07:40:25 +02:00
2026-07-04 03:27:59 +02:00
2026-06-02 21:44:57 +02:00
2026-07-30 02:29:13 +02:00
2026-07-25 20:11:25 +02:00
2026-08-04 23:33:01 +02:00
2026-07-25 20:14:56 +02:00
2026-07-25 05:59:32 +02:00
2026-08-04 23:55:18 +02:00
2026-05-27 23:58:00 +02:00
2026-05-13 18:13:48 +02:00
2026-07-30 02:29:13 +02:00
2026-05-13 18:13:48 +02:00
2026-05-30 00:12:54 +02:00
2026-07-17 06:35:57 +02:00
2026-04-11 21:37:07 +02:00
2026-07-30 02:29:13 +02:00
2026-06-20 21:43:20 +02:00
2026-07-25 03:35:35 +02:00
2026-07-04 03:22:53 +02:00
2026-08-01 08:44:30 +02:00
2026-07-30 02:29:13 +02:00
2026-08-01 08:27:59 +02:00
2026-07-30 03:05:14 +02:00
2026-08-01 08:45:14 +02:00
2026-06-08 21:45:35 +02:00
2026-07-14 01:33:35 +02:00
2026-05-26 22:48:23 +02:00
2026-05-12 23:45:19 +02:00
2026-06-03 00:37:21 +02:00
2026-06-27 00:57:03 +00:00
2026-07-30 02:29:13 +02:00
2026-04-27 18:33:22 +02:00
2026-08-01 08:47:50 +02:00
2026-06-18 20:18:18 +02:00
2026-06-30 07:35:14 +02:00
2026-06-30 07:35:14 +02:00
2026-07-08 08:08:10 +02:00
2026-07-30 02:29:13 +02:00
2026-07-17 22:49:31 +02:00
2026-05-30 23:27:18 +02:00
2026-07-30 02:29:13 +02:00
2026-06-30 07:37:14 +02:00
2026-07-04 08:24:31 +02:00
2026-03-25 17:47:04 +01:00
2026-07-17 07:22:50 +02:00
2026-03-13 08:11:51 +01:00
2026-07-25 04:47:58 +02:00
2026-08-04 23:33:01 +02:00
2026-08-04 23:55:18 +02:00
2026-06-09 23:02:26 +02:00
2026-07-08 09:00:49 +02:00
2026-07-08 09:00:49 +02:00
2026-06-18 12:28:32 +02:00
2026-07-26 07:40:25 +02:00
2026-07-26 07:40:25 +02:00
2026-08-05 19:55:15 +02:00
2026-06-19 17:07:09 +02:00
2026-08-10 07:20:55 +02:00
2026-07-30 01:13:02 +02:00
2026-07-17 06:57:54 +02:00
2026-07-25 18:54:37 +02:00
2026-08-01 20:57:43 +02:00
2026-04-19 11:16:04 +02:00
2026-07-30 02:29:13 +02:00
2026-05-09 21:55:20 +02:00
2026-06-03 00:37:21 +02:00
2026-06-19 16:54:37 +02:00
2026-07-25 04:54:30 +02:00
2026-07-25 04:54:30 +02:00
2026-06-01 22:02:01 +02:00
2026-08-05 19:47:34 +02:00
2026-06-20 20:33:09 +02:00
2026-07-30 02:29:13 +02:00
2026-06-20 20:33:09 +02:00
2026-06-08 21:35:12 +02:00
2026-07-14 03:16:28 +02:00
2026-07-14 03:16:28 +02:00
2026-07-30 02:29:13 +02:00
2026-07-14 03:16:28 +02:00
2026-05-13 20:07:00 +02:00
2026-05-19 13:37:10 +02:00
2026-03-25 10:50:23 +01:00
2026-05-30 00:22:25 +02:00
2026-07-25 04:54:30 +02:00
2026-06-11 09:04:56 +02:00
2026-06-02 21:44:57 +02:00
2026-06-02 21:44:57 +02:00
2026-06-26 06:47:38 +02:00
2026-03-14 20:14:18 +01:00
2026-05-03 20:33:29 +02:00
2026-08-04 23:33:01 +02:00
2026-05-01 13:31:32 +02:00
2026-07-21 05:50:40 +02:00
2026-06-25 05:44:44 +02:00
2026-03-25 10:50:23 +01:00
2026-04-07 14:43:17 +02:00
2026-04-07 14:43:17 +02:00
2026-05-13 18:13:48 +02:00
2026-05-13 18:13:48 +02:00
2026-08-01 08:51:08 +02:00
2026-08-01 08:51:08 +02:00
2026-07-25 05:04:30 +02:00
2026-08-04 23:03:12 +02:00
2026-06-25 05:44:44 +02:00
2026-03-19 15:17:55 +01:00
2026-04-07 16:28:01 +02:00
2026-04-01 20:25:06 +02:00
2026-04-01 20:25:06 +02:00
2026-05-13 18:13:48 +02:00
2026-05-18 20:49:28 +02:00
2026-07-25 03:35:35 +02:00
2026-07-26 07:40:25 +02:00
2026-05-17 16:55:01 +02:00
2026-05-31 16:24:01 +02:00
2026-07-08 08:08:10 +02:00
2026-06-04 19:53:52 +02:00
2026-05-31 22:17:56 +02:00
2026-08-04 23:03:12 +02:00
2026-03-29 17:30:12 +02:00
2026-04-13 00:51:23 +02:00
2026-02-11 15:22:56 +01:00
2026-07-25 05:04:30 +02:00
2026-07-26 01:38:31 +02:00
2026-07-26 07:40:25 +02:00
2026-06-30 06:55:29 +02:00
2026-06-30 07:26:23 +02:00
2026-08-01 08:51:08 +02:00
2026-05-12 23:45:19 +02:00
2026-05-12 23:45:19 +02:00
2026-07-25 03:35:35 +02:00
2026-07-25 05:04:30 +02:00
2026-06-04 11:48:44 +02:00
2026-07-25 05:04:30 +02:00
2026-07-25 04:59:29 +02:00
2026-03-19 15:17:55 +01:00
2026-05-17 09:52:49 +02:00
2026-08-01 08:39:04 +02:00
2026-06-27 00:57:03 +00:00
2026-06-27 00:57:03 +00:00
2026-07-17 07:39:11 +02:00
2026-07-14 01:39:26 +02:00
2026-05-12 00:22:37 +02:00
2026-05-12 00:22:37 +02:00
2026-07-15 19:47:42 +02:00
2026-06-11 20:26:40 +02:00
2026-07-08 08:08:10 +02:00
2026-05-12 12:18:17 +02:00
2026-04-09 18:33:59 +02:00
2026-07-25 05:04:30 +02:00
2026-03-19 15:17:55 +01:00
2026-05-03 10:56:31 +02:00
2026-06-14 22:09:02 +02:00
2026-05-12 00:00:49 +02:00
2026-07-17 23:00:18 +02:00
2026-07-04 08:24:31 +02:00
2026-07-25 05:04:30 +02:00
2026-06-04 23:11:43 +02:00
2026-05-17 09:52:49 +02:00
2026-07-25 03:35:35 +02:00
2026-05-05 01:04:29 +02:00
2026-07-26 07:40:25 +02:00
2026-07-26 07:40:25 +02:00
2026-07-25 04:47:58 +02:00
2026-05-05 01:12:48 +02:00
2026-07-08 09:00:49 +02:00
2026-07-08 09:00:49 +02:00
2026-06-03 00:04:32 +02:00
2026-07-26 07:40:25 +02:00
2026-07-26 07:40:25 +02:00
2026-07-25 05:04:30 +02:00
2026-05-14 21:56:49 +02:00
2026-07-17 23:00:18 +02:00
2026-06-19 17:07:09 +02:00
2026-07-25 04:47:58 +02:00
2026-06-25 05:38:06 +02:00
2026-07-25 03:35:35 +02:00
2026-07-31 02:20:03 +02:00
2026-07-31 02:20:03 +02:00
2026-05-17 09:52:49 +02:00
2026-05-09 21:55:20 +02:00
2026-05-05 00:47:45 +02:00
2026-05-17 09:52:49 +02:00
2026-06-04 11:48:44 +02:00
2026-07-25 03:35:35 +02:00
2026-02-23 17:43:00 -05:00
2026-05-13 20:07:00 +02:00
2026-05-12 23:45:19 +02:00
2026-07-25 04:54:30 +02:00
2026-07-25 04:54:30 +02:00
2026-05-13 20:07:00 +02:00
2026-08-04 23:03:12 +02:00
2026-08-05 19:47:34 +02:00
2026-07-04 03:13:39 +02:00
2026-06-20 20:33:09 +02:00
2026-06-20 20:33:09 +02:00
2026-05-03 20:33:29 +02:00
2026-07-26 07:18:23 +02:00
2026-02-11 15:22:56 +01:00
2026-05-03 22:13:28 +02:00
2026-07-14 03:16:28 +02:00
2026-07-14 03:16:28 +02:00
2026-06-16 08:32:17 +02:00