PrplHaz4
5fb8f4f81a
Don’t re-create pending SimpleFIN transactions when pending sync is disabled ( #2835 )
...
* fix(simplefin): skip pending entries in processor when pending is disabled
When SIMPLEFIN_INCLUDE_PENDING/syncs_include_pending is off, pending rows
already stored in raw_transactions_payload were still (re)created as
entries on every sync - including ones the user manually deleted - because
the setting only affected the API request, not reprocessing of the stored
payload.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com >
* chore(simplefin): add rake task to prune stale pending rows from payload store
raw_transactions_payload accumulates transactions across syncs and is
never pruned, so pending rows fetched before pending inclusion was
disabled keep getting re-imported. This one-time maintenance task removes
them (dry-run by default; scope by item_id/account_id).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com >
* fix(simplefin): address PR #2835 review feedback on pending detection
Fix epoch-zero pending check treating non-numeric posted strings (e.g.
"unavailable") as pending via String#to_i coercion; compare against
explicit zero representations instead, matching posted_date. Dedupe the
prune_pending rake task's copy of this logic by delegating to a new
public SimplefinEntry::Processor.pending? class method. Also close a
test gap where SIMPLEFIN_INCLUDE_PENDING env var precedence over the
Setting wasn't actually exercised.
* test(simplefin): cover pending-guard precedence and add rake task tests
Add the missing mirror case for pending_enabled? precedence (env var
disabling pending over a permissive Setting) and add test coverage for
the prune_pending rake task, which previously had none: dry_run safety
default, correct pruning via the shared Processor.pending? predicate
(including the malformed-posted regression), and that it never touches
Entry/Transaction rows.
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com >
2026-07-29 16:14:55 -07:00
..
2026-07-26 07:40:25 +02:00
2026-07-04 03:27:59 +02:00
2026-06-02 21:44:57 +02:00
2026-06-02 21:44:57 +02:00
2026-07-25 20:11:25 +02:00
2026-07-26 04:47:15 +02:00
2026-07-25 20:14:56 +02:00
2026-07-25 05:59:32 +02:00
2026-05-27 23:58:00 +02:00
2026-05-27 23:58:00 +02:00
2026-05-13 18:13:48 +02:00
2026-05-13 18:13:48 +02:00
2026-05-13 18:13:48 +02:00
2026-05-30 00:12:54 +02:00
2026-07-17 06:35:57 +02:00
2026-01-21 22:56:39 +01:00
2026-04-11 21:37:07 +02:00
2026-04-01 20:25:06 +02:00
2026-06-20 21:43:20 +02:00
2026-07-25 03:35:35 +02:00
2026-07-04 03:22:53 +02:00
2026-07-21 09:15:24 +02:00
2026-05-12 00:17:49 +02:00
2026-07-17 21:33:32 +02:00
2026-02-06 18:04:03 +01:00
2026-07-17 07:09:29 +02:00
2026-07-26 07:40:25 +02:00
2026-06-08 21:45:35 +02:00
2026-07-14 01:33:35 +02:00
2026-05-26 22:48:23 +02:00
2026-05-12 23:45:19 +02:00
2026-06-03 00:37:21 +02:00
2026-06-27 00:57:03 +00:00
2026-07-26 01:47:53 +02:00
2026-04-27 18:33:22 +02:00
2026-07-14 02:19:39 +02:00
2026-06-18 20:18:18 +02:00
2026-06-30 07:35:14 +02:00
2026-06-30 07:35:14 +02:00
2026-07-08 08:08:10 +02:00
2026-02-19 18:58:01 +01:00
2026-07-17 22:49:31 +02:00
2026-05-30 23:27:18 +02:00
2026-01-22 20:37:07 +01:00
2026-06-30 07:37:14 +02:00
2026-06-30 07:37:14 +02:00
2026-07-04 08:24:31 +02:00
2026-03-25 17:47:04 +01:00
2026-07-17 07:22:50 +02:00
2026-03-13 08:11:51 +01:00
2026-07-25 04:47:58 +02:00
2026-07-26 07:40:25 +02:00
2026-06-09 23:02:26 +02:00
2026-07-08 09:00:49 +02:00
2026-07-08 09:00:49 +02:00
2026-06-18 12:28:32 +02:00
2026-07-26 07:40:25 +02:00
2026-07-26 07:40:25 +02:00
2026-07-17 23:00:18 +02:00
2026-06-19 17:07:09 +02:00
2026-01-05 22:11:47 +01:00
2026-07-17 07:22:50 +02:00
2026-07-29 16:14:55 -07:00
2026-07-17 06:57:54 +02:00
2026-07-25 18:54:37 +02:00
2026-07-24 22:45:44 +02:00
2026-04-19 11:16:04 +02:00
2026-04-19 11:16:04 +02:00
2026-05-09 21:55:20 +02:00
2026-06-03 00:37:21 +02:00
2026-06-19 16:54:37 +02:00
2026-07-25 04:54:30 +02:00
2026-07-25 04:54:30 +02:00
2026-06-01 22:02:01 +02:00
2026-06-28 19:47:53 +00:00
2026-06-20 20:33:09 +02:00
2026-06-30 08:19:25 +02:00
2026-06-20 20:33:09 +02:00
2026-06-08 21:35:12 +02:00
2026-07-14 03:16:28 +02:00
2026-07-14 03:16:28 +02:00
2026-07-14 03:16:28 +02:00
2026-07-14 03:16:28 +02:00
2026-05-13 20:07:00 +02:00
2026-05-19 13:37:10 +02:00
2026-01-07 15:59:04 +01:00
2026-03-25 10:50:23 +01:00
2026-05-30 00:22:25 +02:00
2026-07-25 04:54:30 +02:00
2026-06-11 09:04:56 +02:00
2026-06-02 21:44:57 +02:00
2026-06-02 21:44:57 +02:00
2026-06-26 06:47:38 +02:00
2026-03-14 20:14:18 +01:00
2026-05-03 20:33:29 +02:00
2026-06-21 12:01:39 +02:00
2026-05-01 13:31:32 +02:00
2026-07-21 05:50:40 +02:00
2026-06-25 05:44:44 +02:00
2026-03-25 10:50:23 +01:00
2026-04-07 14:43:17 +02:00
2026-04-07 14:43:17 +02:00
2026-05-13 18:13:48 +02:00
2026-05-13 18:13:48 +02:00
2026-05-30 00:51:16 +02:00
2026-06-27 00:57:03 +00:00
2026-07-25 05:04:30 +02:00
2026-07-21 10:00:15 +02:00
2026-06-25 05:44:44 +02:00
2026-03-19 15:17:55 +01:00
2026-04-07 16:28:01 +02:00
2026-04-01 20:25:06 +02:00
2026-04-01 20:25:06 +02:00
2026-05-13 18:13:48 +02:00
2026-05-18 20:49:28 +02:00
2026-07-25 03:35:35 +02:00
2026-07-26 07:40:25 +02:00
2026-05-17 16:55:01 +02:00
2026-05-31 16:24:01 +02:00
2026-07-08 08:08:10 +02:00
2026-06-04 19:53:52 +02:00
2026-05-31 22:17:56 +02:00
2026-06-16 10:51:51 +02:00
2026-03-29 17:30:12 +02:00
2026-04-13 00:51:23 +02:00
2026-02-11 15:22:56 +01:00
2026-07-25 05:04:30 +02:00
2026-01-09 19:38:04 +01:00
2026-07-26 01:38:31 +02:00
2026-07-26 07:40:25 +02:00
2026-06-30 06:55:29 +02:00
2026-06-30 07:26:23 +02:00
2026-06-30 07:26:23 +02:00
2026-05-12 23:45:19 +02:00
2026-05-12 23:45:19 +02:00
2026-07-25 03:35:35 +02:00
2026-07-25 05:04:30 +02:00
2026-06-04 11:48:44 +02:00
2026-07-25 05:04:30 +02:00
2026-07-25 04:59:29 +02:00
2026-03-19 15:17:55 +01:00
2026-05-17 09:52:49 +02:00
2026-07-14 02:19:39 +02:00
2026-06-27 00:57:03 +00:00
2026-06-27 00:57:03 +00:00
2026-07-17 07:39:11 +02:00
2026-07-14 01:39:26 +02:00
2026-01-23 22:05:28 +01:00
2026-05-12 00:22:37 +02:00
2026-05-12 00:22:37 +02:00
2026-07-15 19:47:42 +02:00
2026-06-11 20:26:40 +02:00
2026-07-08 08:08:10 +02:00
2026-05-12 12:18:17 +02:00
2026-04-09 18:33:59 +02:00
2026-07-25 05:04:30 +02:00
2026-03-19 15:17:55 +01:00
2026-05-03 10:56:31 +02:00
2026-06-14 22:09:02 +02:00
2026-05-12 00:00:49 +02:00
2026-02-06 18:04:29 +01:00
2026-07-17 23:00:18 +02:00
2026-07-04 08:24:31 +02:00
2026-07-25 05:04:30 +02:00
2026-06-04 23:11:43 +02:00
2026-05-17 09:52:49 +02:00
2026-07-25 03:35:35 +02:00
2026-05-05 01:04:29 +02:00
2026-07-26 07:40:25 +02:00
2026-07-26 07:40:25 +02:00
2026-07-25 04:47:58 +02:00
2026-05-05 01:12:48 +02:00
2026-07-08 09:00:49 +02:00
2026-07-08 09:00:49 +02:00
2026-06-03 00:04:32 +02:00
2026-07-26 07:40:25 +02:00
2026-07-26 07:40:25 +02:00
2026-07-25 05:04:30 +02:00
2026-05-14 21:56:49 +02:00
2026-07-17 23:00:18 +02:00
2026-06-19 17:07:09 +02:00
2026-01-23 22:05:28 +01:00
2026-07-25 04:47:58 +02:00
2026-06-25 05:38:06 +02:00
2026-07-25 03:35:35 +02:00
2026-07-24 22:45:44 +02:00
2026-07-25 03:35:35 +02:00
2026-05-17 09:52:49 +02:00
2026-05-09 21:55:20 +02:00
2026-01-03 17:56:42 -05:00
2026-05-05 00:47:45 +02:00
2026-05-17 09:52:49 +02:00
2026-01-23 18:55:51 +01:00
2026-06-04 11:48:44 +02:00
2026-07-25 03:35:35 +02:00
2026-02-23 17:43:00 -05:00
2026-05-13 20:07:00 +02:00
2026-05-12 23:45:19 +02:00
2026-07-25 04:54:30 +02:00
2026-07-25 04:54:30 +02:00
2026-05-13 20:07:00 +02:00
2026-07-26 07:40:25 +02:00
2026-06-30 18:00:13 +00:00
2026-07-04 03:13:39 +02:00
2026-06-20 20:33:09 +02:00
2026-06-20 20:33:09 +02:00
2026-05-03 20:33:29 +02:00
2026-07-26 07:18:23 +02:00
2026-02-11 15:22:56 +01:00
2026-05-03 22:13:28 +02:00
2026-07-14 03:16:28 +02:00
2026-07-14 03:16:28 +02:00
2026-06-16 08:32:17 +02:00